Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>
Cc: mani@kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com,
	 bvanassche@acm.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org,  andersson@kernel.org,
	konradybcio@kernel.org, agross@kernel.org,
	 James.Bottomley@hansenpartnership.com,
	martin.petersen@oracle.com, linux-arm-msm@vger.kernel.org,
	 linux-scsi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/4] ufs: dt-bindings: Document gear and rate limit properties
Date: Sun, 24 Aug 2025 11:29:18 +0200	[thread overview]
Message-ID: <20250824-elated-granite-leopard-5633c7@kuoka> (raw)
In-Reply-To: <20250821101609.20235-2-quic_rdwivedi@quicinc.com>

On Thu, Aug 21, 2025 at 03:46:06PM +0530, Ram Kumar Dwivedi wrote:
> +  limit-hs-gear:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 1
> +    maximum: 5

default:

> +    description:
> +      Restricts the maximum HS gear used in both TX and RX directions,
> +      typically for hardware or power constraints in automotive use cases.
> +
> +  limit-rate:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [1, 2]

default:

> +    description:
> +      Restricts the UFS controller to Rate A (1) or Rate B (2) for both

Is 1 and 2 known in UFS spec? Feels like you wanted here string for 'a'
and 'b'.

Best regards,
Krzysztof


  reply	other threads:[~2025-08-24  9:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-21 10:16 [PATCH V2 0/4] Add DT-based gear and rate limiting support Ram Kumar Dwivedi
2025-08-21 10:16 ` [PATCH V2 1/4] ufs: dt-bindings: Document gear and rate limit properties Ram Kumar Dwivedi
2025-08-24  9:29   ` Krzysztof Kozlowski [this message]
2025-08-26 14:53     ` Ram Kumar Dwivedi
2025-08-21 10:16 ` [PATCH V2 2/4] ufs: ufs-qcom: Remove redundant re-assignment to hs_rate Ram Kumar Dwivedi
2025-08-21 10:16 ` [PATCH V2 3/4] ufs: pltfrm: Allow limiting HS gear and rate via DT Ram Kumar Dwivedi
2025-08-21 10:16 ` [PATCH V2 4/4] ufs: ufs-qcom: Add support for limiting HS gear and rate Ram Kumar Dwivedi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250824-elated-granite-leopard-5633c7@kuoka \
    --to=krzk@kernel.org \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=agross@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=andersson@kernel.org \
    --cc=avri.altman@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=quic_rdwivedi@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox