* [PATCH 2/2] hwmon: tmp102: Add support for label
2025-08-25 18:02 [PATCH 1/2] dt-bindings: hwmon: tmp102: Add label property Flaviu Nistor
@ 2025-08-25 18:02 ` Flaviu Nistor
2025-08-31 22:30 ` Guenter Roeck
2025-08-29 16:06 ` [PATCH 1/2] dt-bindings: hwmon: tmp102: Add label property Rob Herring
2025-08-31 22:27 ` Guenter Roeck
2 siblings, 1 reply; 5+ messages in thread
From: Flaviu Nistor @ 2025-08-25 18:02 UTC (permalink / raw)
Cc: Jean Delvare, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-hwmon, devicetree, linux-kernel,
Flaviu Nistor
Add support for label sysfs attribute similar to other hwmon devices.
This is particularly useful for systems with multiple sensors on the
same board, where identifying individual sensors is much easier since
labels can be defined via device tree.
Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
---
drivers/hwmon/tmp102.c | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/drivers/hwmon/tmp102.c b/drivers/hwmon/tmp102.c
index a02daa496c9c..8dd295b0d87a 100644
--- a/drivers/hwmon/tmp102.c
+++ b/drivers/hwmon/tmp102.c
@@ -53,6 +53,7 @@
#define CONVERSION_TIME_MS 35 /* in milli-seconds */
struct tmp102 {
+ const char *label;
struct regmap *regmap;
u16 config_orig;
unsigned long ready_time;
@@ -70,6 +71,16 @@ static inline u16 tmp102_mC_to_reg(int val)
return (val * 128) / 1000;
}
+static int tmp102_read_string(struct device *dev, enum hwmon_sensor_types type,
+ u32 attr, int channel, const char **str)
+{
+ struct tmp102 *tmp102 = dev_get_drvdata(dev);
+
+ *str = tmp102->label;
+
+ return 0;
+}
+
static int tmp102_read(struct device *dev, enum hwmon_sensor_types type,
u32 attr, int channel, long *temp)
{
@@ -128,12 +139,18 @@ static int tmp102_write(struct device *dev, enum hwmon_sensor_types type,
static umode_t tmp102_is_visible(const void *data, enum hwmon_sensor_types type,
u32 attr, int channel)
{
+ const struct tmp102 *tmp102 = data;
+
if (type != hwmon_temp)
return 0;
switch (attr) {
case hwmon_temp_input:
return 0444;
+ case hwmon_temp_label:
+ if (tmp102->label)
+ return 0444;
+ return 0;
case hwmon_temp_max_hyst:
case hwmon_temp_max:
return 0644;
@@ -146,12 +163,13 @@ static const struct hwmon_channel_info * const tmp102_info[] = {
HWMON_CHANNEL_INFO(chip,
HWMON_C_REGISTER_TZ),
HWMON_CHANNEL_INFO(temp,
- HWMON_T_INPUT | HWMON_T_MAX | HWMON_T_MAX_HYST),
+ HWMON_T_INPUT | HWMON_T_LABEL | HWMON_T_MAX | HWMON_T_MAX_HYST),
NULL
};
static const struct hwmon_ops tmp102_hwmon_ops = {
.is_visible = tmp102_is_visible,
+ .read_string = tmp102_read_string,
.read = tmp102_read,
.write = tmp102_write,
};
@@ -213,6 +231,8 @@ static int tmp102_probe(struct i2c_client *client)
if (!tmp102)
return -ENOMEM;
+ of_property_read_string(dev->of_node, "label", &tmp102->label);
+
i2c_set_clientdata(client, tmp102);
tmp102->regmap = devm_regmap_init_i2c(client, &tmp102_regmap_config);
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] dt-bindings: hwmon: tmp102: Add label property
2025-08-25 18:02 [PATCH 1/2] dt-bindings: hwmon: tmp102: Add label property Flaviu Nistor
2025-08-25 18:02 ` [PATCH 2/2] hwmon: tmp102: Add support for label Flaviu Nistor
@ 2025-08-29 16:06 ` Rob Herring
2025-08-31 22:27 ` Guenter Roeck
2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2025-08-29 16:06 UTC (permalink / raw)
To: Flaviu Nistor
Cc: Jean Delvare, Guenter Roeck, Krzysztof Kozlowski, Conor Dooley,
linux-hwmon, devicetree, linux-kernel
On Mon, Aug 25, 2025 at 09:02:43PM +0300, Flaviu Nistor wrote:
> Add support for an optional label property similar to other hwmon devices.
> This allows, in case of boards with multiple TMP102 sensors, to assign
> distinct names to each instance.
>
> Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
> ---
> Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> index 4c89448eba0d..1d192100e8b5 100644
> --- a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> @@ -20,6 +20,10 @@ properties:
> reg:
> maxItems: 1
>
> + label:
> + description: |
Don't need '|'.
With that,
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> + A descriptive name for this channel, like "ambient" or "psu".
> +
> "#thermal-sensor-cells":
> const: 1
>
> @@ -45,6 +49,7 @@ examples:
> reg = <0x48>;
> interrupt-parent = <&gpio7>;
> interrupts = <16 IRQ_TYPE_LEVEL_LOW>;
> + label = "somelabel";
> vcc-supply = <&supply>;
> #thermal-sensor-cells = <1>;
> };
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: hwmon: tmp102: Add label property
2025-08-25 18:02 [PATCH 1/2] dt-bindings: hwmon: tmp102: Add label property Flaviu Nistor
2025-08-25 18:02 ` [PATCH 2/2] hwmon: tmp102: Add support for label Flaviu Nistor
2025-08-29 16:06 ` [PATCH 1/2] dt-bindings: hwmon: tmp102: Add label property Rob Herring
@ 2025-08-31 22:27 ` Guenter Roeck
2 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2025-08-31 22:27 UTC (permalink / raw)
To: Flaviu Nistor
Cc: Jean Delvare, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-hwmon, devicetree, linux-kernel
On Mon, Aug 25, 2025 at 09:02:43PM +0300, Flaviu Nistor wrote:
> Add support for an optional label property similar to other hwmon devices.
> This allows, in case of boards with multiple TMP102 sensors, to assign
> distinct names to each instance.
>
> Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Applied (after making change suggested by Rob).
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread