From: Jakub Kicinski <kuba@kernel.org>
To: Jack Ping CHNG <jchng@maxlinear.com>
Cc: <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<davem@davemloft.net>, <andrew+netdev@lunn.ch>,
<edumazet@google.com>, <pabeni@redhat.com>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>, <yzhu@maxlinear.com>,
<sureshnagaraj@maxlinear.com>
Subject: Re: [PATCH net-next v2 2/2] net: maxlinear: Add support for MxL LGM SoC
Date: Tue, 26 Aug 2025 06:09:18 -0700 [thread overview]
Message-ID: <20250826060918.1f6ffa3e@kernel.org> (raw)
In-Reply-To: <20250826031044.563778-3-jchng@maxlinear.com>
On Tue, 26 Aug 2025 11:10:44 +0800 Jack Ping CHNG wrote:
> + for_each_available_child_of_node(pdev->dev.of_node, np) {
> + if (!of_device_is_compatible(np, "mxl,eth-mac"))
> + continue;
> +
> + ret = mxl_eth_create_ndev(pdev, np, &ndev);
> + if (ret)
> + goto err_cleanup;
> +
> + drvdata->ndevs[i++] = ndev;
> + if (i >= MXL_NUM_PORT)
> + break;
> + }
You need a of_node_put(np) before the goto and the break;
--
pw-bot: cr
next prev parent reply other threads:[~2025-08-26 13:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 3:10 [PATCH net-next v2 0/2] Add MxL Ethernet driver & devicetree binding Jack Ping CHNG
2025-08-26 3:10 ` [PATCH net-next v2 1/2] dt-bindings: net: mxl: Add MxL LGM Network Processor SoC Jack Ping CHNG
2025-08-26 12:45 ` Andrew Lunn
2025-08-26 13:05 ` Rob Herring (Arm)
2025-08-27 12:33 ` Krzysztof Kozlowski
2025-08-26 3:10 ` [PATCH net-next v2 2/2] net: maxlinear: Add support for MxL LGM SoC Jack Ping CHNG
2025-08-26 13:03 ` Andrew Lunn
2025-08-27 10:41 ` Jack Ping Chng
2025-08-27 12:16 ` Andrew Lunn
2025-08-26 13:09 ` Jakub Kicinski [this message]
2025-08-27 12:33 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250826060918.1f6ffa3e@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jchng@maxlinear.com \
--cc=krzk+dt@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=sureshnagaraj@maxlinear.com \
--cc=yzhu@maxlinear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).