From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FD7235082A for ; Wed, 27 Aug 2025 12:42:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756298545; cv=none; b=Yyxk2m8qVQU7/9j5cu0JcXDTyqdNdwysTn8WCauLHT1HmeXmXoxpiN1cpUHHu0eYcCzOLtAN8WartNwM/a2iHlbQ1DUVgdhSxUCNI54vaYHQ8fQdgp2+mD4kwCHRuEcKpg0CFQuDwmG6jmZco1KQJcMgU/UXVNnMd6UuSmYpHVE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756298545; c=relaxed/simple; bh=GciBv6TscMWoUL5NOWHvgdZWg70tQo2b5jzt+et6cck=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=F+bKm1BME0kUoI3meb50gRylmGnJGunxxwVqTCBRkmGTBZMiJOLdZwxIUaZU+4YSbIAToRtZJ1Woxg5lVOEaqMvBfC/MOVoGkKT/x+9FsZp0UcWEwCDoVJDhUO/lxeWm1K2xlvipayI224yGXjchOIFvJTG/pKXmHujLGtZl3IQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=f7fV+XS1; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="f7fV+XS1" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3c79f0a5c5fso2974984f8f.1 for ; Wed, 27 Aug 2025 05:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756298539; x=1756903339; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5cfSXL73LYNoY9rCDtAr6B+DOeIwLOhBdUm0HxsWgPY=; b=f7fV+XS1qOMMYmKM/w3Zv33LRHaUetSxAEK/bMdgNpikDVKGmqoPv7ti8cmOQk6pYj QSXWlCAPy6LkS4MwmLXCUjyxWXCFgZbtSDGY4D+P0q5hXYUqzKkOJIFD/kCBoKMDudTc 6UP3zhh0HtKKBA2dWDGDnZcdY7/bl7YgyLNjcj5Vh4T0G0iIDHRR/8kaxJcPRMGqueu4 Fdv/0NhVMp2IvQXkL9pUhBZijMoS4T+IzbHLJ75oq491EfHkOU0bbf8F0PDFBbeVrXRr VE0o6ZXtCa/5rAnHqNmjI1Ia1IncDskBRCjAW+5IXgX3bBKmy/1Gj/NjXEpb3IhgS7Yn yMPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756298539; x=1756903339; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5cfSXL73LYNoY9rCDtAr6B+DOeIwLOhBdUm0HxsWgPY=; b=c9ShQsCIVL96pDjbgool9we7P7yVXsqRggm8+N9xggbwito9z/ksc4am6aM1PJ6Vd8 EvWsh/RtkKXCwoKLV0rrtgKj8qyRlZ/7X9ioKQhEiRpm00f1XkLevXo2uG7656Bu9hcc M9i2L36QE2TYDvtlVK6DDKFqGLmnp+AMZTuSbtXjfITOtr/dI4wjBcY49DMAcM87P6kk C3G+8vbJazdBEYkqRMa/fPnboSlIUImy5Zgqrw4NYABXTvuQa9hqEFSFIDyZbvjDgVKj P+hXaQhKb45NGeC2nfswnGgZaYEFpu5jRfVSiAVxrh18q6IN8qDTNpNZObxhxeGsfAwn w8ig== X-Forwarded-Encrypted: i=1; AJvYcCX9ZpEDrAX7up+lpYlnjo++JsD9Mu0wnt2govb0Dq5053YF4Ky4FJm7b5zt0/W7TpsSnv0ZiqnutQe1@vger.kernel.org X-Gm-Message-State: AOJu0YxM2IrTkav4zj1G7b0747itizvWU+VDTmn8AL3YzCaz2M/TAtjC GMvngZhOTSEaZAqM/ibgf9UJcX/HpVozkDy5up1LG23UOc/IDKxGSz2GAUxPk4N3sHo= X-Gm-Gg: ASbGnctAeZe2R5pJn8834Mq1QdOpyX9cMj3cSrewsYQcGomQXlwDzYoXBhlSLtqaVLe 31tk1MbGGv0j1TQB03llH8eGjM0O4vJ5FscnLLLRKOdB8c3bQGbkr8LyA23T55Zzmdh9bu1rl+W phbC4GOUk5m72YaHp/sJFHMv5GTOePNNKBxlnwIoIaA0PBo/OKjmqUVbiZMwd7e1EINmzPGrELE 0x7523OsrhLNmkWmBavsY0V7qvZ7nlzSDkBngININo8W/7l6aeIStfStXn5Pe4jmTAp4r0VyORS Wi3XMZ6n2aj2D6eLrZPqVJgQWb7JdgC+YSR1mx/K0jhK4fYqyWvmf3hKqVU7lORwxa+4YtVzuSQ j3BK2iHSyRd9SgxHIdFoDeLXE9PTQOzIGh0boL/Wh1oEZodPx0Lyo3Fh2ymwTNaMUuVJ6xbIo5e jU0Q== X-Google-Smtp-Source: AGHT+IFlHa5emvmCKQfoDDkPRlNGe/uXhHgcv977YZ2vSKl+w8mC+U+AGdr8d85CmNa+TjSLH+q9Nw== X-Received: by 2002:a05:6000:288a:b0:3a4:fea6:d49f with SMTP id ffacd0b85a97d-3c5dcc0dec3mr14394157f8f.49.1756298538987; Wed, 27 Aug 2025 05:42:18 -0700 (PDT) Received: from ta2.c.googlers.com (219.43.233.35.bc.googleusercontent.com. [35.233.43.219]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3cbab3ead0dsm6439420f8f.29.2025.08.27.05.42.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Aug 2025 05:42:18 -0700 (PDT) From: Tudor Ambarus Date: Wed, 27 Aug 2025 12:42:14 +0000 Subject: [PATCH v2 4/5] firmware: exynos-acpm: register ACPM clocks dev Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250827-acpm-clk-v2-4-de5c86b49b64@linaro.org> References: <20250827-acpm-clk-v2-0-de5c86b49b64@linaro.org> In-Reply-To: <20250827-acpm-clk-v2-0-de5c86b49b64@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Alim Akhtar , Sylwester Nawrocki , Chanwoo Choi , Catalin Marinas , Will Deacon Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, willmcvicker@google.com, kernel-team@android.com, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1756298535; l=5210; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=GciBv6TscMWoUL5NOWHvgdZWg70tQo2b5jzt+et6cck=; b=GS+9vzYJP6T4ggVpRCRv6J4WvF9fBE/H6F09fimItPewcc/1VJ9tRuthqg3yPNy+9zXnUVBvU ukecEb66+HWAfBZ7JoAEuzjmTBSm7Uw9ybIAmdsFdHdZYdNJKT/66XL X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= Register by hand a platform device for the ACPM clocks. The ACPM clocks are not modeled as a DT child of ACPM because: 1/ they don't have their own resources. 2/ they are not a block that can be reused. The clock identifying data is reduced (clock ID, clock name and mailbox channel ID) and may differ from a SoC to another. Signed-off-by: Tudor Ambarus --- drivers/firmware/samsung/exynos-acpm.c | 64 +++++++++++++++++++++++++++++++++- 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/samsung/exynos-acpm.c b/drivers/firmware/samsung/exynos-acpm.c index 9fa0335ccf5db32892fdf09e8d4b0a885a8f8fb5..86a220a845d2934aa28e9bb8996cf914f65cdae6 100644 --- a/drivers/firmware/samsung/exynos-acpm.c +++ b/drivers/firmware/samsung/exynos-acpm.c @@ -24,10 +24,13 @@ #include #include #include +#include #include #include #include +#include + #include "exynos-acpm.h" #include "exynos-acpm-dvfs.h" #include "exynos-acpm-pmic.h" @@ -160,6 +163,7 @@ struct acpm_chan { * struct acpm_info - driver's private data. * @shmem: pointer to the SRAM configuration data. * @sram_base: base address of SRAM. + * @clk_pdev: ACPM clocks platform device. * @chans: pointer to the ACPM channel parameters retrieved from SRAM. * @dev: pointer to the exynos-acpm device. * @handle: instance of acpm_handle to send to clients. @@ -168,6 +172,7 @@ struct acpm_chan { struct acpm_info { struct acpm_shmem __iomem *shmem; void __iomem *sram_base; + struct platform_device *clk_pdev; struct acpm_chan *chans; struct device *dev; struct acpm_handle handle; @@ -177,14 +182,39 @@ struct acpm_info { /** * struct acpm_match_data - of_device_id data. * @initdata_base: offset in SRAM where the channels configuration resides. + * @acpm_clk_pdata: ACPM clocks platform data. */ struct acpm_match_data { loff_t initdata_base; + const struct acpm_clk_platform_data *acpm_clk_pdata; }; #define client_to_acpm_chan(c) container_of(c, struct acpm_chan, cl) #define handle_to_acpm_info(h) container_of(h, struct acpm_info, handle) +#define ACPM_CLK(_id, cname) \ + { \ + .id = _id, \ + .name = cname, \ + } + +static const struct acpm_clk_variant gs101_acpm_clks[] = { + ACPM_CLK(CLK_ACPM_DVFS_MIF, "mif"), + ACPM_CLK(CLK_ACPM_DVFS_INT, "int"), + ACPM_CLK(CLK_ACPM_DVFS_CPUCL0, "cpucl0"), + ACPM_CLK(CLK_ACPM_DVFS_CPUCL1, "cpucl1"), + ACPM_CLK(CLK_ACPM_DVFS_CPUCL2, "cpucl2"), + ACPM_CLK(CLK_ACPM_DVFS_G3D, "g3d"), + ACPM_CLK(CLK_ACPM_DVFS_G3DL2, "g3dl2"), + ACPM_CLK(CLK_ACPM_DVFS_TPU, "tpu"), + ACPM_CLK(CLK_ACPM_DVFS_INTCAM, "intcam"), + ACPM_CLK(CLK_ACPM_DVFS_TNR, "tnr"), + ACPM_CLK(CLK_ACPM_DVFS_CAM, "cam"), + ACPM_CLK(CLK_ACPM_DVFS_MFC, "mfc"), + ACPM_CLK(CLK_ACPM_DVFS_DISP, "disp"), + ACPM_CLK(CLK_ACPM_DVFS_BO, "b0"), +}; + /** * acpm_get_saved_rx() - get the response if it was already saved. * @achan: ACPM channel info. @@ -606,6 +636,7 @@ static void acpm_setup_ops(struct acpm_info *acpm) static int acpm_probe(struct platform_device *pdev) { + const struct acpm_clk_platform_data *acpm_clk_pdata; const struct acpm_match_data *match_data; struct device *dev = &pdev->dev; struct device_node *shmem; @@ -647,7 +678,30 @@ static int acpm_probe(struct platform_device *pdev) platform_set_drvdata(pdev, acpm); - return devm_of_platform_populate(dev); + acpm_clk_pdata = match_data->acpm_clk_pdata; + acpm->clk_pdev = platform_device_register_data(dev, "acpm-clocks", + PLATFORM_DEVID_NONE, + acpm_clk_pdata, + sizeof(*acpm_clk_pdata)); + if (IS_ERR(acpm->clk_pdev)) + return dev_err_probe(dev, PTR_ERR(acpm->clk_pdev), + "Failed to register ACPM clocks device.\n"); + + ret = devm_of_platform_populate(dev); + if (ret) { + platform_device_unregister(acpm->clk_pdev); + return dev_err_probe(dev, ret, + "Failed to populate platform devices.\n"); + } + + return 0; +} + +static void acpm_remove(struct platform_device *pdev) +{ + struct acpm_info *acpm = platform_get_drvdata(pdev); + + platform_device_unregister(acpm->clk_pdev); } /** @@ -744,8 +798,15 @@ const struct acpm_handle *devm_acpm_get_by_node(struct device *dev, } EXPORT_SYMBOL_GPL(devm_acpm_get_by_node); +static const struct acpm_clk_platform_data acpm_clk_gs101 = { + .clks = gs101_acpm_clks, + .nr_clks = ARRAY_SIZE(gs101_acpm_clks), + .mbox_chan_id = 0, +}; + static const struct acpm_match_data acpm_gs101 = { .initdata_base = ACPM_GS101_INITDATA_BASE, + .acpm_clk_pdata = &acpm_clk_gs101, }; static const struct of_device_id acpm_match[] = { @@ -759,6 +820,7 @@ MODULE_DEVICE_TABLE(of, acpm_match); static struct platform_driver acpm_driver = { .probe = acpm_probe, + .remove = acpm_remove, .driver = { .name = "exynos-acpm-protocol", .of_match_table = acpm_match, -- 2.51.0.261.g7ce5a0a67e-goog