From: Chia-I Wu <olvaffe@gmail.com>
To: Boris Brezillon <boris.brezillon@collabora.com>,
Steven Price <steven.price@arm.com>,
Liviu Dudau <liviu.dudau@arm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] drm/panthor: add asn-hash support
Date: Thu, 28 Aug 2025 13:18:06 -0700 [thread overview]
Message-ID: <20250828201806.3541261-3-olvaffe@gmail.com> (raw)
In-Reply-To: <20250828201806.3541261-1-olvaffe@gmail.com>
Parse asn-hash and enable custom ASN hash when the property exists.
This is required on some socs such as mt8196.
Signed-off-by: Chia-I Wu <olvaffe@gmail.com>
---
drivers/gpu/drm/panthor/panthor_device.c | 28 ++++++++++++++++++++++++
drivers/gpu/drm/panthor/panthor_device.h | 6 +++++
drivers/gpu/drm/panthor/panthor_gpu.c | 17 ++++++++++++++
drivers/gpu/drm/panthor/panthor_regs.h | 4 ++++
4 files changed, 55 insertions(+)
diff --git a/drivers/gpu/drm/panthor/panthor_device.c b/drivers/gpu/drm/panthor/panthor_device.c
index 81df49880bd87..19423c495d8d7 100644
--- a/drivers/gpu/drm/panthor/panthor_device.c
+++ b/drivers/gpu/drm/panthor/panthor_device.c
@@ -41,6 +41,30 @@ static int panthor_gpu_coherency_init(struct panthor_device *ptdev)
return -ENOTSUPP;
}
+static int panthor_gpu_asn_hash_init(struct panthor_device *ptdev)
+{
+ int ret;
+
+ ret = of_property_read_u32_array(ptdev->base.dev->of_node, "asn-hash",
+ ptdev->asn_hash,
+ ARRAY_SIZE(ptdev->asn_hash));
+ if (ret) {
+ if (ret == -EINVAL)
+ ret = 0;
+ return ret;
+ }
+
+ if (GPU_ARCH_MAJOR(ptdev->gpu_info.gpu_id) < 11) {
+ drm_err(&ptdev->base,
+ "Custom ASN hash not supported by the device");
+ return -EOPNOTSUPP;
+ }
+
+ ptdev->has_asn_hash = true;
+
+ return 0;
+}
+
static int panthor_clk_init(struct panthor_device *ptdev)
{
ptdev->clks.core = devm_clk_get(ptdev->base.dev, NULL);
@@ -257,6 +281,10 @@ int panthor_device_init(struct panthor_device *ptdev)
if (ret)
goto err_unplug_gpu;
+ ret = panthor_gpu_asn_hash_init(ptdev);
+ if (ret)
+ goto err_unplug_gpu;
+
ret = panthor_mmu_init(ptdev);
if (ret)
goto err_unplug_gpu;
diff --git a/drivers/gpu/drm/panthor/panthor_device.h b/drivers/gpu/drm/panthor/panthor_device.h
index 4fc7cf2aeed57..6f8e2b3b037e5 100644
--- a/drivers/gpu/drm/panthor/panthor_device.h
+++ b/drivers/gpu/drm/panthor/panthor_device.h
@@ -114,6 +114,12 @@ struct panthor_device {
/** @coherent: True if the CPU/GPU are memory coherent. */
bool coherent;
+ /** @has_asn_hash: True if custom ASN hash is enabled. */
+ bool has_asn_hash;
+
+ /** @asn_hash: ASN_HASH values for custom ASN hash */
+ u32 asn_hash[3];
+
/** @gpu_info: GPU information. */
struct drm_panthor_gpu_info gpu_info;
diff --git a/drivers/gpu/drm/panthor/panthor_gpu.c b/drivers/gpu/drm/panthor/panthor_gpu.c
index db69449a5be09..f9222b67f314d 100644
--- a/drivers/gpu/drm/panthor/panthor_gpu.c
+++ b/drivers/gpu/drm/panthor/panthor_gpu.c
@@ -52,6 +52,22 @@ static void panthor_gpu_coherency_set(struct panthor_device *ptdev)
ptdev->coherent ? GPU_COHERENCY_PROT_BIT(ACE_LITE) : GPU_COHERENCY_NONE);
}
+static void panthor_gpu_asn_hash_set(struct panthor_device *ptdev)
+{
+ u32 l2_config;
+ u32 i;
+
+ if (!ptdev->has_asn_hash)
+ return;
+
+ for (i = 0; i < ARRAY_SIZE(ptdev->asn_hash); i++)
+ gpu_write(ptdev, ASN_HASH(i), ptdev->asn_hash[i]);
+
+ l2_config = gpu_read(ptdev, L2_CONFIG);
+ l2_config |= L2_CONFIG_ASN_HASH_ENABLE;
+ gpu_write(ptdev, L2_CONFIG, l2_config);
+}
+
static void panthor_gpu_irq_handler(struct panthor_device *ptdev, u32 status)
{
gpu_write(ptdev, GPU_INT_CLEAR, status);
@@ -243,6 +259,7 @@ int panthor_gpu_l2_power_on(struct panthor_device *ptdev)
/* Set the desired coherency mode before the power up of L2 */
panthor_gpu_coherency_set(ptdev);
+ panthor_gpu_asn_hash_set(ptdev);
return panthor_gpu_power_on(ptdev, L2, 1, 20000);
}
diff --git a/drivers/gpu/drm/panthor/panthor_regs.h b/drivers/gpu/drm/panthor/panthor_regs.h
index 8bee76d01bf83..c9f795624e79b 100644
--- a/drivers/gpu/drm/panthor/panthor_regs.h
+++ b/drivers/gpu/drm/panthor/panthor_regs.h
@@ -64,6 +64,8 @@
#define GPU_FAULT_STATUS 0x3C
#define GPU_FAULT_ADDR 0x40
+#define L2_CONFIG 0x48
+#define L2_CONFIG_ASN_HASH_ENABLE BIT(24)
#define GPU_PWR_KEY 0x50
#define GPU_PWR_KEY_UNLOCK 0x2968A819
@@ -110,6 +112,8 @@
#define GPU_REVID 0x280
+#define ASN_HASH(n) (0x2C0 + ((n) * 4))
+
#define GPU_COHERENCY_FEATURES 0x300
#define GPU_COHERENCY_PROT_BIT(name) BIT(GPU_COHERENCY_ ## name)
--
2.51.0.318.gd7df087d1a-goog
next prev parent reply other threads:[~2025-08-28 20:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 20:18 [PATCH 0/2] drm/panthor: add custom ASN hash support Chia-I Wu
2025-08-28 20:18 ` [PATCH 1/2] dt-bindings: gpu: mali-valhall-csf: add asn-hash Chia-I Wu
2025-08-29 8:32 ` Boris Brezillon
2025-08-29 13:42 ` Krzysztof Kozlowski
2025-08-28 20:18 ` Chia-I Wu [this message]
2025-08-29 13:41 ` [PATCH 2/2] drm/panthor: add asn-hash support Steven Price
2025-08-29 13:40 ` [PATCH 0/2] drm/panthor: add custom ASN hash support Steven Price
2025-08-29 21:50 ` Chia-I Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250828201806.3541261-3-olvaffe@gmail.com \
--to=olvaffe@gmail.com \
--cc=airlied@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).