From: Leo Yan <leo.yan@arm.com>
To: Yuanfang Zhang <yuanfang.zhang@oss.qualcomm.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
kernel@oss.qualcomm.com, coresight@lists.linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] coresight-tnoc: add platform driver to support Interconnect TNOC
Date: Fri, 29 Aug 2025 09:24:27 +0100 [thread overview]
Message-ID: <20250829082427.GF745921@e132581.arm.com> (raw)
In-Reply-To: <20250828-itnoc-v3-2-f1b55dea7a27@oss.qualcomm.com>
On Thu, Aug 28, 2025 at 02:27:23AM -0700, Yuanfang Zhang wrote:
[...]
> @@ -51,12 +53,17 @@ static void trace_noc_enable_hw(struct trace_noc_drvdata *drvdata)
> {
> u32 val;
>
> + /* No valid ATID, simply enable the unit */
> + if (drvdata->atid == -EOPNOTSUPP) {
> + writel(TRACE_NOC_CTRL_PORTEN, drvdata->base + TRACE_NOC_CTRL);
> + return;
> + }
> +
> /* Set ATID */
> writel_relaxed(drvdata->atid, drvdata->base + TRACE_NOC_XLD);
>
> /* Set the data word count between 'SYNC' packets */
> writel_relaxed(TRACE_NOC_SYNC_INTERVAL, drvdata->base + TRACE_NOC_SYNCR);
> -
Unintended change ?
> /* Set the Control register:
> * - Set the FLAG packets to 'FLAG' packets
> * - Set the FREQ packets to 'FREQ_TS' packets
> @@ -68,8 +75,8 @@ static void trace_noc_enable_hw(struct trace_noc_drvdata *drvdata)
> val &= ~TRACE_NOC_CTRL_FLAGTYPE;
> val |= TRACE_NOC_CTRL_FREQTYPE;
> val |= TRACE_NOC_CTRL_PORTEN;
> -
Ditto.
> writel(val, drvdata->base + TRACE_NOC_CTRL);
> +
Ditto.
Otherwise, LGTM:
Reviewed-by: Leo Yan <leo.yan@arm.com>
next prev parent reply other threads:[~2025-08-29 8:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 9:27 [PATCH v3 0/3] coresight-tnoc: Add support for Interconnect TNOC Yuanfang Zhang
2025-08-28 9:27 ` [PATCH v3 1/3] dt-bindings: arm: qcom: Add Coresight " Yuanfang Zhang
2025-08-29 17:50 ` Rob Herring (Arm)
2025-08-28 9:27 ` [PATCH v3 2/3] coresight-tnoc: add platform driver to support " Yuanfang Zhang
2025-08-29 8:24 ` Leo Yan [this message]
2025-08-28 9:27 ` [PATCH v3 3/3] coresight-tnoc: Add runtime PM support for " Yuanfang Zhang
2025-08-29 8:41 ` Leo Yan
2025-08-29 8:49 ` [PATCH v3 0/3] coresight-tnoc: Add " Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250829082427.GF745921@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@linaro.org \
--cc=kernel@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=yuanfang.zhang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).