* [PATCH 1/3] arm64: dts: qcom: msm8953: fix SPI clocks
2025-08-30 21:13 [PATCH 0/3] MSM8953 Fix SPI interfaces and add spi_7 Barnabás Czémán
@ 2025-08-30 21:13 ` Barnabás Czémán
2025-08-30 21:13 ` [PATCH 2/3] arm64: dts: qcom: msm8953: correct SPI pinctrls Barnabás Czémán
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Barnabás Czémán @ 2025-08-30 21:13 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Gianluca Boiano
Cc: linux-arm-msm, devicetree, linux-kernel,
Barnabás Czémán
Fix SPI clocks, accidentally I2C clocks was assigned for SPI interfaces.
Fixes: be69109e93c78 ("arm64: dts: qcom: msm8953: add SPI interfaces")
Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
---
arch/arm64/boot/dts/qcom/msm8953.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi b/arch/arm64/boot/dts/qcom/msm8953.dtsi
index c5205d09c442e45e4a0cc3e6d8ff7d9d7bda0034..14dd17278ae0850df1dafad19a569ffc5afb174b 100644
--- a/arch/arm64/boot/dts/qcom/msm8953.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi
@@ -1660,7 +1660,7 @@ spi_3: spi@78b7000 {
reg = <0x078b7000 0x600>;
interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
clock-names = "core", "iface";
- clocks = <&gcc GCC_BLSP1_QUP3_I2C_APPS_CLK>,
+ clocks = <&gcc GCC_BLSP1_QUP3_SPI_APPS_CLK>,
<&gcc GCC_BLSP1_AHB_CLK>;
dmas = <&blsp1_dma 8>, <&blsp1_dma 9>;
dma-names = "tx", "rx";
@@ -1751,7 +1751,7 @@ spi_5: spi@7af5000 {
reg = <0x07af5000 0x600>;
interrupts = <GIC_SPI 299 IRQ_TYPE_LEVEL_HIGH>;
clock-names = "core", "iface";
- clocks = <&gcc GCC_BLSP2_QUP1_I2C_APPS_CLK>,
+ clocks = <&gcc GCC_BLSP2_QUP1_SPI_APPS_CLK>,
<&gcc GCC_BLSP2_AHB_CLK>;
dmas = <&blsp2_dma 4>, <&blsp2_dma 5>;
dma-names = "tx", "rx";
@@ -1791,7 +1791,7 @@ spi_6: spi@7af6000 {
reg = <0x07af6000 0x600>;
interrupts = <GIC_SPI 300 IRQ_TYPE_LEVEL_HIGH>;
clock-names = "core", "iface";
- clocks = <&gcc GCC_BLSP2_QUP2_I2C_APPS_CLK>,
+ clocks = <&gcc GCC_BLSP2_QUP2_SPI_APPS_CLK>,
<&gcc GCC_BLSP2_AHB_CLK>;
dmas = <&blsp2_dma 6>, <&blsp2_dma 7>;
dma-names = "tx", "rx";
--
2.51.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/3] arm64: dts: qcom: msm8953: correct SPI pinctrls
2025-08-30 21:13 [PATCH 0/3] MSM8953 Fix SPI interfaces and add spi_7 Barnabás Czémán
2025-08-30 21:13 ` [PATCH 1/3] arm64: dts: qcom: msm8953: fix SPI clocks Barnabás Czémán
@ 2025-08-30 21:13 ` Barnabás Czémán
2025-08-30 21:13 ` [PATCH 3/3] arm64: dts: qcom: msm8953: add spi_7 Barnabás Czémán
2025-09-01 19:45 ` [PATCH 0/3] MSM8953 Fix SPI interfaces and " Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Barnabás Czémán @ 2025-08-30 21:13 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Gianluca Boiano
Cc: linux-arm-msm, devicetree, linux-kernel,
Barnabás Czémán
SPI pinctrls should handle 4 pins MOSI, MISO, CLK and CS.
This change adding the missing pins for pinctrls and correcting
CS pins according to downstream sources.
Fixes: be69109e93c78 ("arm64: dts: qcom: msm8953: add SPI interfaces")
Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
---
arch/arm64/boot/dts/qcom/msm8953.dtsi | 102 ++++++++++++++++++++++++++--------
1 file changed, 78 insertions(+), 24 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi b/arch/arm64/boot/dts/qcom/msm8953.dtsi
index 14dd17278ae0850df1dafad19a569ffc5afb174b..1b3e68aed9450f61d14fe6c16a4dd513c815c6da 100644
--- a/arch/arm64/boot/dts/qcom/msm8953.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi
@@ -775,45 +775,99 @@ i2c_8_sleep: i2c-8-sleep-state {
};
spi_3_default: spi-3-default-state {
- pins = "gpio10", "gpio11";
- function = "blsp_spi3";
- drive-strength = <2>;
- bias-disable;
+ cs-pins {
+ pins = "gpio10";
+ function = "blsp_spi3";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ spi-pins {
+ pins = "gpio8", "gpio9", "gpio11";
+ function = "blsp_spi3";
+ drive-strength = <12>;
+ bias-disable;
+ };
};
spi_3_sleep: spi-3-sleep-state {
- pins = "gpio10", "gpio11";
- function = "gpio";
- drive-strength = <2>;
- bias-disable;
+ cs-pins {
+ pins = "gpio10";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ spi-pins {
+ pins = "gpio8", "gpio9", "gpio11";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
};
spi_5_default: spi-5-default-state {
- pins = "gpio18", "gpio19";
- function = "blsp_spi5";
- drive-strength = <2>;
- bias-disable;
+ cs-pins {
+ pins = "gpio18";
+ function = "blsp_spi5";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ spi-pins {
+ pins = "gpio16", "gpio17", "gpio19";
+ function = "blsp_spi5";
+ drive-strength = <12>;
+ bias-disable;
+ };
};
spi_5_sleep: spi-5-sleep-state {
- pins = "gpio18", "gpio19";
- function = "gpio";
- drive-strength = <2>;
- bias-disable;
+ cs-pins {
+ pins = "gpio18";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ spi-pins {
+ pins = "gpio16", "gpio17", "gpio19";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
};
spi_6_default: spi-6-default-state {
- pins = "gpio22", "gpio23";
- function = "blsp_spi6";
- drive-strength = <2>;
- bias-disable;
+ cs-pins {
+ pins = "gpio22";
+ function = "blsp_spi6";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ spi-pins {
+ pins = "gpio20", "gpio21", "gpio23";
+ function = "blsp_spi6";
+ drive-strength = <12>;
+ bias-disable;
+ };
};
spi_6_sleep: spi-6-sleep-state {
- pins = "gpio22", "gpio23";
- function = "gpio";
- drive-strength = <2>;
- bias-disable;
+ cs-pins {
+ pins = "gpio22";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ spi-pins {
+ pins = "gpio20", "gpio21", "gpio23";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
};
uart_5_default: uart-5-default-state {
--
2.51.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 3/3] arm64: dts: qcom: msm8953: add spi_7
2025-08-30 21:13 [PATCH 0/3] MSM8953 Fix SPI interfaces and add spi_7 Barnabás Czémán
2025-08-30 21:13 ` [PATCH 1/3] arm64: dts: qcom: msm8953: fix SPI clocks Barnabás Czémán
2025-08-30 21:13 ` [PATCH 2/3] arm64: dts: qcom: msm8953: correct SPI pinctrls Barnabás Czémán
@ 2025-08-30 21:13 ` Barnabás Czémán
2025-09-01 19:45 ` [PATCH 0/3] MSM8953 Fix SPI interfaces and " Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Barnabás Czémán @ 2025-08-30 21:13 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Gianluca Boiano
Cc: linux-arm-msm, devicetree, linux-kernel,
Barnabás Czémán
Add spi_7 can be found in MSM8953 devices.
Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
---
arch/arm64/boot/dts/qcom/msm8953.dtsi | 52 +++++++++++++++++++++++++++++++++++
1 file changed, 52 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi b/arch/arm64/boot/dts/qcom/msm8953.dtsi
index 1b3e68aed9450f61d14fe6c16a4dd513c815c6da..76317c5783496675a549815bbed71fd214590dd1 100644
--- a/arch/arm64/boot/dts/qcom/msm8953.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi
@@ -870,6 +870,38 @@ spi-pins {
};
};
+ spi_7_default: spi-7-default-state {
+ cs-pins {
+ pins = "gpio136";
+ function = "blsp_spi7";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ spi-pins {
+ pins = "gpio135", "gpio137", "gpio138";
+ function = "blsp_spi7";
+ drive-strength = <12>;
+ bias-disable;
+ };
+ };
+
+ spi_7_sleep: spi-7-sleep-state {
+ cs-pins {
+ pins = "gpio136";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ spi-pins {
+ pins = "gpio135", "gpio137", "gpio138";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+ };
+
uart_5_default: uart-5-default-state {
pins = "gpio16", "gpio17", "gpio18", "gpio19";
function = "blsp_uart5";
@@ -1880,6 +1912,26 @@ i2c_7: i2c@7af7000 {
status = "disabled";
};
+ spi_7: spi@7af7000 {
+ compatible = "qcom,spi-qup-v2.2.1";
+ reg = <0x07af7000 0x600>;
+ interrupts = <GIC_SPI 301 IRQ_TYPE_LEVEL_HIGH>;
+ clock-names = "core", "iface";
+ clocks = <&gcc GCC_BLSP2_QUP3_SPI_APPS_CLK>,
+ <&gcc GCC_BLSP2_AHB_CLK>;
+ dmas = <&blsp2_dma 8>, <&blsp2_dma 9>;
+ dma-names = "tx", "rx";
+
+ pinctrl-names = "default", "sleep";
+ pinctrl-0 = <&spi_7_default>;
+ pinctrl-1 = <&spi_7_sleep>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ status = "disabled";
+ };
+
i2c_8: i2c@7af8000 {
compatible = "qcom,i2c-qup-v2.2.1";
reg = <0x07af8000 0x600>;
--
2.51.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 0/3] MSM8953 Fix SPI interfaces and add spi_7
2025-08-30 21:13 [PATCH 0/3] MSM8953 Fix SPI interfaces and add spi_7 Barnabás Czémán
` (2 preceding siblings ...)
2025-08-30 21:13 ` [PATCH 3/3] arm64: dts: qcom: msm8953: add spi_7 Barnabás Czémán
@ 2025-09-01 19:45 ` Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2025-09-01 19:45 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Gianluca Boiano, Barnabás Czémán
Cc: linux-arm-msm, devicetree, linux-kernel
On Sat, 30 Aug 2025 23:13:18 +0200, Barnabás Czémán wrote:
> This patch series fixing SPI clocks and pinctrls according to
> downstream sources and add support for spi_7 interface can be
> found in MSM8953 devices.
>
>
Applied, thanks!
[1/3] arm64: dts: qcom: msm8953: fix SPI clocks
commit: 4faee358fea854fddba95843c55d9eb9013a4f00
[2/3] arm64: dts: qcom: msm8953: correct SPI pinctrls
commit: 690bc19286407cf1c0fc189910a936261ae1344c
[3/3] arm64: dts: qcom: msm8953: add spi_7
commit: 73f7dc09f8e363736a3d3509820666e2006ab277
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread