From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Manikanta Guntupalli <manikanta.guntupalli@amd.com>
Cc: git@amd.com, michal.simek@amd.com, Frank.Li@nxp.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
kees@kernel.org, gustavoars@kernel.org,
jarkko.nikula@linux.intel.com, linux-i3c@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org, radhey.shyam.pandey@amd.com,
srinivas.goud@amd.com, shubhrajyoti.datta@amd.com,
manion05gk@gmail.com
Subject: Re: [PATCH V2 2/2] i3c: master: Add AMD I3C bus controller driver
Date: Mon, 1 Sep 2025 22:12:48 +0200 [thread overview]
Message-ID: <202509012012480348cc7a@mail.local> (raw)
In-Reply-To: <20250829171327.2590730-3-manikanta.guntupalli@amd.com>
On 29/08/2025 22:43:27+0530, Manikanta Guntupalli wrote:
> +static void xi3c_master_reset_fifos(struct xi3c_master *master)
> +{
> + u32 data;
> +
> + /* Reset fifos */
> + data = readl(master->membase + XI3C_RESET_OFFSET);
> + data |= XI3C_FIFOS_RST_MASK;
> + writel(data, master->membase + XI3C_RESET_OFFSET);
> + udelay(10);
As pointed out by checkpatch:
usleep_range is preferred over udelay, I guess it would be fine in this
function.
> + data &= ~XI3C_FIFOS_RST_MASK;
> + writel(data, master->membase + XI3C_RESET_OFFSET);
> + udelay(10);
> +}
> +
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2025-09-01 20:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 17:13 [PATCH V2 0/2] Add AMD I3C master controller driver and bindings Manikanta Guntupalli
2025-08-29 17:13 ` [PATCH V2 1/2] dt-bindings: i3c: Add AMD I3C master controller support Manikanta Guntupalli
2025-09-01 5:21 ` Krzysztof Kozlowski
2025-09-01 5:22 ` Krzysztof Kozlowski
2025-08-29 17:13 ` [PATCH V2 2/2] i3c: master: Add AMD I3C bus controller driver Manikanta Guntupalli
2025-09-01 20:12 ` Alexandre Belloni [this message]
2025-09-02 7:10 ` Guntupalli, Manikanta
2025-09-03 14:27 ` Frank Li
2025-09-04 10:09 ` Guntupalli, Manikanta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202509012012480348cc7a@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=gustavoars@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manikanta.guntupalli@amd.com \
--cc=manion05gk@gmail.com \
--cc=michal.simek@amd.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=robh@kernel.org \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.goud@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).