From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A8641865FA; Tue, 2 Sep 2025 19:31:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756841494; cv=none; b=EZeVEqsTZ4o2500gtb6lrIzj7Bj2LIZ6VSfXodvSwPoY/u1PG2kbnXupqFv0tOP3LHCC9Cfr/ym6DDishrXNIFqElua8BjPPsLMR5sL7OC6x0MRThNvGZ5Baip9afBb3rzh7pfLhMroF5TwwiO8bi+TGt1ZuVEqUJD5n1/SOd5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756841494; c=relaxed/simple; bh=F14nPORs8JdgFQl33HfGRKc+FkO94g/5nNmkQ7R1MBg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z3Zv4HJnURnuUe1m6jkGrGyxX3Jf5HQbnhzcJbsy/aPRNiIlQyamjDCW7K9Gg3TueUD8Y4B0/D1knqRsv8rqw4REK0Xs9iuHiVBqSXSAMbBKNGWiYolSrEP98uAO4c9CkDMcDRHETDJRoAeunnrId2ZMvi0O2HtzTh6ditOPi8c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iFs/A14m; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iFs/A14m" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FDCDC4CEED; Tue, 2 Sep 2025 19:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756841494; bh=F14nPORs8JdgFQl33HfGRKc+FkO94g/5nNmkQ7R1MBg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iFs/A14ma2YVWf6Xfo5kNA4paBdeW7hQYYdbujdC/+mCv7+Q5Se86rzNwGS6MwaiD UVG3Q0qBHF38bpOg7jcYZRztAC2ZopUFHOVbZGmU0KSC8UUGldGv+XC0rsyc1UmsQ9 p8/0tlsdKvL4rMgNass/Y3Sdo9/tIzN2+43azvH4Yl/1XqWOsrYbDRENCmAd5sl2ap 1ERo9tzWZJzYwNgOpMfrlVq4zxtSNL6g6HGu7qv0L4+9/Sq/IpQ2c/tDAnBEF2hbtt 9SsLq0fQZD/Yec0fwRiovHKo4WJhrIMhBVnwvLJ4ipIyndd7jV3lyFXDR2gRrCbdj2 VTUYFM+98bPRA== Date: Tue, 2 Sep 2025 20:31:28 +0100 From: Conor Dooley To: Peng Fan Cc: Marc Kleine-Budde , Vincent Mailhol , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Aswath Govindraju , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Bough Chen , "linux-can@vger.kernel.org" , "linux-phy@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "imx@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v4 1/6] dt-bindings: phy: ti,tcan104x-can: Document NXP TJA105X/1048 Message-ID: <20250902-dastardly-truth-fb2be9f68e4a@spud> References: <20250901-can-v4-0-e42b5fe2cf9e@nxp.com> <20250901-can-v4-1-e42b5fe2cf9e@nxp.com> <20250901-diligent-dreaded-59b9ad5c3976@spud> <20250901-uproar-shrill-07d51ea21a29@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="emYz2NOh8U/FtcyF" Content-Disposition: inline In-Reply-To: --emYz2NOh8U/FtcyF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 02, 2025 at 02:24:49AM +0000, Peng Fan wrote: > Hi Conor, >=20 > > Subject: Re: [PATCH v4 1/6] dt-bindings: phy: ti,tcan104x-can: > > Document NXP TJA105X/1048 > >=20 > > On Mon, Sep 01, 2025 at 07:54:01PM +0100, Conor Dooley wrote: > > > On Mon, Sep 01, 2025 at 11:18:11AM +0800, Peng Fan wrote: > > > > The TJA105[1,7] is a high-speed CAN transceiver which is a > > > > pin-compatible alternative for TI TCAN1043 with sleep mode > > > > supported, and has a compatible programming model, therefore > > use ti,tcan1043 as fallback compatible. > > > > > > > > The TJA1048 is a dual high-speed CAN transceiver with sleep mode > > supported. > > > > > > > > Reviewed-by: Frank Li > > > > Signed-off-by: Peng Fan > > > > --- > > > > .../devicetree/bindings/phy/ti,tcan104x-can.yaml | 30 > > ++++++++++++++++++++-- > > > > 1 file changed, 28 insertions(+), 2 deletions(-) > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml > > > > b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml > > > > index > > > > > > 4a8c3829d85d3c4a4963750d03567c1c345beb91..f8e0c24856a2ba83 > > b5c988b246 > > > > 464f47e11a032f 100644 > > > > --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml > > > > +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x- > > can.yaml > > > > @@ -19,18 +19,25 @@ properties: > > > > - enum: > > > > - microchip,ata6561 > > > > - const: ti,tcan1042 > > > > + - items: > > > > + - enum: > > > > + - nxp,tja1051 > > > > + - nxp,tja1057 > > > > + - const: ti,tcan1043 > > > > - enum: > > > > - ti,tcan1042 > > > > - ti,tcan1043 > > > > + - nxp,tja1048 > > > > - nxp,tjr1443 > > > > > > > > '#phy-cells': > > > > - const: 0 > > > > + enum: [0, 1] > > > > > > > > standby-gpios: > > > > description: > > > > gpio node to toggle standby signal on transceiver > > > > - maxItems: 1 > > > > + minItems: 1 > > > > + maxItems: 2 > > > > > > You're adding a second standby gpio, which one is which? > > > I assume you mean that item 1 is stbn1 and item 2 is stbn 2 for > > tja1048. >=20 > Yes. There are two standby pins. >=20 > > > Might be kinda obvious, but I think it should be mentioned. >=20 > I could update description as below. > " > description: > gpio node to toggle standby signal on transceiver. For two Items, > item 1 is for stbn1, item 2 is for stbn2. Sure. >=20 > > > > > > tja105{1,7} don't have a standby gpio, but they do have a silent > > mode. >=20 > Right. Tja105{1,7} has a pin S for silent mode. >=20 > > > silent mode seems fundamentally different to standby, since the > > > receiver still works. Seems like that should be handled differently, = no? > >=20 > > The docs for standby mode for the tcan1043 don't match with the > > tja1051, "Standby mode is a low power mode where the driver and > > receiver are disabled," so does the fallback compatible even make > > sense? Seems like a combination of enable and standby gpios are used > > to put the tcan device into silent mode but the tja1051 has a pin for > > that alone and seemingly does not support standby at all? >=20 > Thanks for looking into the details. I also read more into the datasheet. >=20 > Tcan1043: > EN nSTB > H H ---> normal mode > L H ---> slient mode > H L ---> standby mode > L X --->off mode >=20 > TJA1051 > EN S > H L --> normal mode > H H --> slient mode > L X --> off mode >=20 > Your analysis is correct. silent is different with standby, > but we only wanna to use normal and off mode In addition, it looks like there are some tja1051 devices that don't even have the enable pin? Of the 4 SKUs, there are 2 that use pin5 as Vio and 1 that has it n/c. Only the T/E device has an enable there. > If we need to handle differently, I need > to add a new optional property >=20 > silent-gpios: > description: > gpio node to toggle silent signal on transceiver > minItems: 1 Ye, I think so. And probably add some if/then to use it instead of standby on the relevant chips. --emYz2NOh8U/FtcyF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaLdGEAAKCRB4tDGHoIJi 0mVdAQDC4R/uDobfYX0MlIc7P3VN7g19AM8wzxvWSJ27EwGhBgEA12JCMoHxPor9 peA9L92m9adGEyaiB2fIMSJnYILwrQM= =7Ezu -----END PGP SIGNATURE----- --emYz2NOh8U/FtcyF--