From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 994A430E827 for ; Wed, 3 Sep 2025 13:56:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756907809; cv=none; b=gc3UBkJqbo8PdxU9/CoJZptqW7gJg4q4N5wZG+CaUZq1EuH8TjwQ4eRy7KaGdjfbmpLjZoposg3QOrmPHAnEkzFDuUB0pwGkElkdSmb69AlLQ7Om0ZqXnvw0jntfhhyWV7jKcdTbZPT4bgNeGu7ZC/wNu/zQvFG8I+kvPnv8Gyw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756907809; c=relaxed/simple; bh=xWuaKRf4eIWvRTxRFnWQ8EPPrxM66+MS5MywdI2ONhs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HJpKSVejWQ2QLI/+ZhiXoVMN/kNq5sKl+BQ2GxI8IcylQoTuFRrQ9vkHSrLWWIhFf/SJWNbpqsr52jeFXr2Q8buaf/PkUvMXdCsPxxyh4tvlgVN3+Mn0sNAHbSwJc5cm7J6wrZvkB219crJ9JTfksLUMUe/gTlRnkh0qkPzRjqg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PuCVR8gd; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PuCVR8gd" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-45b9853e630so17778555e9.0 for ; Wed, 03 Sep 2025 06:56:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756907805; x=1757512605; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TEKzxyIbxVr9Lt/9n3xWbOrvTFOX3szJ8lqpps0zRyg=; b=PuCVR8gdeFKcvGa2EiZem5I2NHCJXVc3fYvWRbrq7Y/4UyFhRB80WG/896Z21CnMX2 TrzpYxfX+kCp8QJW2Y6s04FL3uiPMPULz2cswIXyPSXx/FG+qleNc1WEV6vzFWWx6Htk fuBVb/5ym0i1E4y1DehmueMe9wkHmmkdV/m6Fbts8aEBDVtuFSEXIt/dlGBO1xxxZ5Hr 4z5Uv0n0OTw8zX2+zMJ8WQaF5FQ2E6f5urs9ptZ/R0XcgsvIF4Ess3IEUtj89rZzjfjR 4cA1kvqkC+1PXPxPARxaVbB/WwQv2tTnGYoi7VPXua/H+0z4BYrm7RVDJxSJscmjZLjR L1AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756907805; x=1757512605; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TEKzxyIbxVr9Lt/9n3xWbOrvTFOX3szJ8lqpps0zRyg=; b=sCykDw5hI4y4WIH7tc6FAxuwHhmFUhfD8QY4D01fYEbezExE3tuaA6IBCjFQMQKYHc BNXtQ9slhuDbSaOqsMQiJ1WyvQFZK2Jhn/8lnMf/p6OgC2MYuQaf7vKVYQ2jf29lNaqb dkCaTIMy8IeTPs/Oid9EAUKPcjfZmtwgyJ+6L05Q3C7HeR1FAFKYEjW+fi6OJ08HTxMT daXU7/F4Mj+3VTlaMrR8vHTAyyY/Z1NhocIDeicGCh/GcW5eB/XPwajtn/uw4xVoedPf RFUwe3eBFj4fDWtAubZBh3atF1K7bUtJslBZwRYwJwsYcRwhyaTG6+vGCkY82xxRKsIk XUKw== X-Forwarded-Encrypted: i=1; AJvYcCUbC5OqWCX/8/8+wm6gi84FpVD3zK47yU+j9K2zBNA7i7gV0WAFxEiqv1TaudNdrMObdftMyh9xtq1H@vger.kernel.org X-Gm-Message-State: AOJu0Yw56JNAIhvxeym2gsxkKeg3uNCVqNzU/DvibxPmHi4mjVPfg7nE N5hMmlsfiV1Awi/syCuZu5UkF1ko5F7QpDHAQa4mRaNpCv3Lh9SJ3J9jvXcV+zlXmAE= X-Gm-Gg: ASbGnctMetYWxrTmUCE9IZTsCb6KIPO/H3SYG4uYMVFwEAK2szE8OwbGWkalQruLPVM aiZuiFXDC914tKBa/dF8nKfFzcXG4l7tQ4bT2002WTxCLQIFi3N70nnO9Fkb5WfIJ5rWbNVyyq7 TZFSHWWM4t3qo/aDy0f12QPvOCwJU4MCjzI+iAuDA5+kkOtI+br874vqJIPgGVvgISJAjh2bOs5 NpuCATxoZi7gQnXe68U4i6FQpcjg6kkOOu/zExJFcYDDjJPYKndSTo/7bu4FwrO7h/GGQPwu5gO ENhukJa6E0wj75W9FFzPGyi8gH0JmpxaJ9dSv4SKZRP3FnZoM+X0epe/TgDoiC8Aqc7wU7DE8A0 QeOSRp36G6/7LpAMohC4syBJQrY0OHub85B7n5WTiNZ/T1LgvprYbDIkluvnVhUKcWDP8EZ4Qh5 IGtw== X-Google-Smtp-Source: AGHT+IFO9nSz52fxYxdGQzsxxZrKol2dhW6Nm0GN+wyaiDcf/gy+3eG/jsgUY3sa/n/UJDN2fGk2Yg== X-Received: by 2002:a05:600c:314d:b0:45b:8a92:6b14 with SMTP id 5b1f17b1804b1-45b8a926f9amr119385275e9.37.1756907804887; Wed, 03 Sep 2025 06:56:44 -0700 (PDT) Received: from ta2.c.googlers.com (219.43.233.35.bc.googleusercontent.com. [35.233.43.219]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b87632365sm197257135e9.16.2025.09.03.06.56.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Sep 2025 06:56:44 -0700 (PDT) From: Tudor Ambarus Date: Wed, 03 Sep 2025 13:56:39 +0000 Subject: [PATCH v3 2/5] firmware: exynos-acpm: add DVFS protocol Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250903-acpm-clk-v3-2-65ecd42d88c7@linaro.org> References: <20250903-acpm-clk-v3-0-65ecd42d88c7@linaro.org> In-Reply-To: <20250903-acpm-clk-v3-0-65ecd42d88c7@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Alim Akhtar , Sylwester Nawrocki , Chanwoo Choi , Catalin Marinas , Will Deacon Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, willmcvicker@google.com, kernel-team@android.com, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1756907802; l=6599; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=xWuaKRf4eIWvRTxRFnWQ8EPPrxM66+MS5MywdI2ONhs=; b=zZvkeZso8tYtXpk7gaP3vDCYLhLaul5NmQqMEO16vYvJoyZ8W6fwGy2vldN1Gw4xAEkO2psgp XUgD8F3Pm0BAhQKfgwliJv1BF+CyfbFX/P5Es0/fUxOb+Dk9urK388V X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= Add ACPM DVFS protocol handler. It constructs DVFS messages that the APM firmware can understand. Signed-off-by: Tudor Ambarus --- drivers/firmware/samsung/Makefile | 4 +- drivers/firmware/samsung/exynos-acpm-dvfs.c | 83 ++++++++++++++++++++++ drivers/firmware/samsung/exynos-acpm-dvfs.h | 21 ++++++ drivers/firmware/samsung/exynos-acpm.c | 5 ++ .../linux/firmware/samsung/exynos-acpm-protocol.h | 10 +++ 5 files changed, 122 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/samsung/Makefile b/drivers/firmware/samsung/Makefile index 7b4c9f6f34f54fd731886d97a615fe1aa97ba9a0..80d4f89b33a9558b68c9083da675c70ec3d05f19 100644 --- a/drivers/firmware/samsung/Makefile +++ b/drivers/firmware/samsung/Makefile @@ -1,4 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only -acpm-protocol-objs := exynos-acpm.o exynos-acpm-pmic.o +acpm-protocol-objs := exynos-acpm.o +acpm-protocol-objs += exynos-acpm-pmic.o +acpm-protocol-objs += exynos-acpm-dvfs.o obj-$(CONFIG_EXYNOS_ACPM_PROTOCOL) += acpm-protocol.o diff --git a/drivers/firmware/samsung/exynos-acpm-dvfs.c b/drivers/firmware/samsung/exynos-acpm-dvfs.c new file mode 100644 index 0000000000000000000000000000000000000000..a8763bf9374d41952a8d26124cc77baae0f1c723 --- /dev/null +++ b/drivers/firmware/samsung/exynos-acpm-dvfs.c @@ -0,0 +1,83 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright 2020 Samsung Electronics Co., Ltd. + * Copyright 2020 Google LLC. + * Copyright 2025 Linaro Ltd. + */ + +#include +#include +#include +#include +#include + +#include "exynos-acpm.h" +#include "exynos-acpm-dvfs.h" + +#define ACPM_DVFS_ID GENMASK(11, 0) +#define ACPM_DVFS_REQ_TYPE GENMASK(15, 0) + +#define ACPM_DVFS_FREQ_REQ 0 +#define ACPM_DVFS_FREQ_GET 1 + +static void acpm_dvfs_set_xfer(struct acpm_xfer *xfer, u32 *cmd, size_t cmdlen, + unsigned int acpm_chan_id, bool response) +{ + xfer->acpm_chan_id = acpm_chan_id; + xfer->txd = cmd; + xfer->txlen = cmdlen; + + if (response) { + xfer->rxd = cmd; + xfer->rxlen = cmdlen; + } +} + +static void acpm_dvfs_init_set_rate_cmd(u32 cmd[4], unsigned int clk_id, + unsigned long rate) +{ + cmd[0] = FIELD_PREP(ACPM_DVFS_ID, clk_id); + cmd[1] = rate / HZ_PER_KHZ; + cmd[2] = FIELD_PREP(ACPM_DVFS_REQ_TYPE, ACPM_DVFS_FREQ_REQ); + cmd[3] = ktime_to_ms(ktime_get()); +} + +int acpm_dvfs_set_rate(const struct acpm_handle *handle, + unsigned int acpm_chan_id, unsigned int clk_id, + unsigned long rate) +{ + struct acpm_xfer xfer = {0}; + u32 cmd[4]; + + acpm_dvfs_init_set_rate_cmd(cmd, clk_id, rate); + acpm_dvfs_set_xfer(&xfer, cmd, sizeof(cmd), acpm_chan_id, false); + + return acpm_do_xfer(handle, &xfer); +} + +static void acpm_dvfs_init_get_rate_cmd(u32 cmd[4], unsigned int clk_id, + u32 dbg_val) +{ + cmd[0] = FIELD_PREP(ACPM_DVFS_ID, clk_id); + cmd[1] = dbg_val; + cmd[2] = FIELD_PREP(ACPM_DVFS_REQ_TYPE, ACPM_DVFS_FREQ_GET); + cmd[3] = ktime_to_ms(ktime_get()); +} + +unsigned long acpm_dvfs_get_rate(const struct acpm_handle *handle, + unsigned int acpm_chan_id, unsigned int clk_id, + u32 dbg_val) +{ + struct acpm_xfer xfer; + unsigned int cmd[4]; + int ret; + + acpm_dvfs_init_get_rate_cmd(cmd, clk_id, dbg_val); + acpm_dvfs_set_xfer(&xfer, cmd, sizeof(cmd), acpm_chan_id, true); + + ret = acpm_do_xfer(handle, &xfer); + if (ret) + return 0; + + return xfer.rxd[1] * HZ_PER_KHZ; +} diff --git a/drivers/firmware/samsung/exynos-acpm-dvfs.h b/drivers/firmware/samsung/exynos-acpm-dvfs.h new file mode 100644 index 0000000000000000000000000000000000000000..85a10bd535d118f2f36e9888e41b9b705b08ea59 --- /dev/null +++ b/drivers/firmware/samsung/exynos-acpm-dvfs.h @@ -0,0 +1,21 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright 2020 Samsung Electronics Co., Ltd. + * Copyright 2020 Google LLC. + * Copyright 2025 Linaro Ltd. + */ +#ifndef __EXYNOS_ACPM_DVFS_H__ +#define __EXYNOS_ACPM_DVFS_H__ + +#include + +struct acpm_handle; + +int acpm_dvfs_set_rate(const struct acpm_handle *handle, + unsigned int acpm_chan_id, unsigned int id, + unsigned long rate); +unsigned long acpm_dvfs_get_rate(const struct acpm_handle *handle, + unsigned int acpm_chan_id, unsigned int clk_id, + u32 dbg_val); + +#endif /* __EXYNOS_ACPM_DVFS_H__ */ diff --git a/drivers/firmware/samsung/exynos-acpm.c b/drivers/firmware/samsung/exynos-acpm.c index 3a69fe3234c75e0b5a93cbea6bb210dc6f69d2a6..9fa0335ccf5db32892fdf09e8d4b0a885a8f8fb5 100644 --- a/drivers/firmware/samsung/exynos-acpm.c +++ b/drivers/firmware/samsung/exynos-acpm.c @@ -29,6 +29,7 @@ #include #include "exynos-acpm.h" +#include "exynos-acpm-dvfs.h" #include "exynos-acpm-pmic.h" #define ACPM_PROTOCOL_SEQNUM GENMASK(21, 16) @@ -590,8 +591,12 @@ static int acpm_channels_init(struct acpm_info *acpm) */ static void acpm_setup_ops(struct acpm_info *acpm) { + struct acpm_dvfs_ops *dvfs_ops = &acpm->handle.ops.dvfs_ops; struct acpm_pmic_ops *pmic_ops = &acpm->handle.ops.pmic_ops; + dvfs_ops->set_rate = acpm_dvfs_set_rate; + dvfs_ops->get_rate = acpm_dvfs_get_rate; + pmic_ops->read_reg = acpm_pmic_read_reg; pmic_ops->bulk_read = acpm_pmic_bulk_read; pmic_ops->write_reg = acpm_pmic_write_reg; diff --git a/include/linux/firmware/samsung/exynos-acpm-protocol.h b/include/linux/firmware/samsung/exynos-acpm-protocol.h index f628bf1862c25fa018a2fe5e7e123bf05c5254b9..e41055316bb578bb8250a1b1177f1059eeeb2611 100644 --- a/include/linux/firmware/samsung/exynos-acpm-protocol.h +++ b/include/linux/firmware/samsung/exynos-acpm-protocol.h @@ -13,6 +13,15 @@ struct acpm_handle; struct device_node; +struct acpm_dvfs_ops { + int (*set_rate)(const struct acpm_handle *handle, + unsigned int acpm_chan_id, unsigned int clk_id, + unsigned long rate); + unsigned long (*get_rate)(const struct acpm_handle *handle, + unsigned int acpm_chan_id, + unsigned int clk_id, u32 dbg_val); +}; + struct acpm_pmic_ops { int (*read_reg)(const struct acpm_handle *handle, unsigned int acpm_chan_id, u8 type, u8 reg, u8 chan, @@ -32,6 +41,7 @@ struct acpm_pmic_ops { }; struct acpm_ops { + struct acpm_dvfs_ops dvfs_ops; struct acpm_pmic_ops pmic_ops; }; -- 2.51.0.338.gd7d06c2dae-goog