From: Peng Fan <peng.fan@nxp.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Aswath Govindraju <a-govindraju@ti.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Frank Li <frank.li@nxp.com>,
Haibo Chen <haibo.chen@nxp.com>
Cc: linux-can@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Peng Fan <peng.fan@nxp.com>
Subject: [PATCH v5 5/9] phy: phy-can-transceiver: Propagate return value of gpiod_set_value_cansleep
Date: Thu, 04 Sep 2025 16:36:48 +0800 [thread overview]
Message-ID: <20250904-can-v5-5-23d8129b5e5d@nxp.com> (raw)
In-Reply-To: <20250904-can-v5-0-23d8129b5e5d@nxp.com>
gpiod_set_value_cansleep might return failure, propagate the return value
of gpiod_set_value_cansleep to parent.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/phy/phy-can-transceiver.c | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/drivers/phy/phy-can-transceiver.c b/drivers/phy/phy-can-transceiver.c
index b7d75a78d9242e2003660a87d2d4c9f784aea523..ccb29e1dfe0d07005b4bcd8fefa2787292d921a0 100644
--- a/drivers/phy/phy-can-transceiver.c
+++ b/drivers/phy/phy-can-transceiver.c
@@ -46,23 +46,32 @@ static int can_transceiver_phy_power_on(struct phy *phy)
return ret;
}
}
- gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 0);
- gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 1);
- return 0;
+ ret = gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 0);
+ if (ret)
+ return ret;
+
+ return gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 1);
}
/* Power off function */
static int can_transceiver_phy_power_off(struct phy *phy)
{
struct can_transceiver_phy *can_transceiver_phy = phy_get_drvdata(phy);
+ int ret;
+
+ ret = gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 1);
+ if (ret)
+ return ret;
+
+ ret = gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 0);
+ if (ret)
+ return ret;
- gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 1);
- gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 0);
if (can_transceiver_phy->priv->mux_state)
- mux_state_deselect(can_transceiver_phy->priv->mux_state);
+ ret = mux_state_deselect(can_transceiver_phy->priv->mux_state);
- return 0;
+ return ret;
}
static const struct phy_ops can_transceiver_phy_ops = {
--
2.37.1
next prev parent reply other threads:[~2025-09-04 8:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 8:36 [PATCH v5 0/9] phy: phy-can-transceiver: Support TJA1048/TJA1051 Peng Fan
2025-09-04 8:36 ` [PATCH v5 1/9] dt-bindings: phy: ti,tcan104x-can: Document NXP TJA105X/1048 Peng Fan
2025-09-04 14:17 ` Frank Li
2025-09-05 7:52 ` Krzysztof Kozlowski
2025-09-05 13:11 ` Peng Fan
2025-09-04 8:36 ` [PATCH v5 2/9] phy: phy-can-transceiver: Introduce can_transceiver_priv Peng Fan
2025-09-04 8:36 ` [PATCH v5 3/9] phy: phy-can-transceiver: Add dual channel support for TJA1048 Peng Fan
2025-09-04 8:36 ` [PATCH v5 4/9] phy: phy-can-transceiver: Drop the gpio desc check Peng Fan
2025-09-04 14:18 ` Frank Li
2025-09-04 8:36 ` Peng Fan [this message]
2025-09-04 14:20 ` [PATCH v5 5/9] phy: phy-can-transceiver: Propagate return value of gpiod_set_value_cansleep Frank Li
2025-09-04 8:36 ` [PATCH v5 6/9] phy: phy-can-transceiver: Add support for TJA105{1,7} Peng Fan
2025-09-04 14:22 ` Frank Li
2025-09-04 8:36 ` [PATCH v5 7/9] arm64: dts: imx95-15x15-evk: Use phys to replace xceiver-supply Peng Fan
2025-09-04 8:36 ` [PATCH v5 8/9] arm64: dts: imx8mp-evk: " Peng Fan
2025-09-04 8:36 ` [PATCH v5 9/9] arm64: dts: imx93-11x11-evk: " Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250904-can-v5-5-23d8129b5e5d@nxp.com \
--to=peng.fan@nxp.com \
--cc=a-govindraju@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=haibo.chen@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).