From: Konrad Dybcio <konradybcio@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Robert Foss <rfoss@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: [PATCH 3/5] i2c: qcom-cci: Drop single-line wrappers
Date: Thu, 04 Sep 2025 16:31:22 +0200 [thread overview]
Message-ID: <20250904-topic-cci_updates-v1-3-d38559692703@oss.qualcomm.com> (raw)
In-Reply-To: <20250904-topic-cci_updates-v1-0-d38559692703@oss.qualcomm.com>
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
The CCI clock en/disable functions simply call bulk_ops, remove them.
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
drivers/i2c/busses/i2c-qcom-cci.c | 20 ++++++--------------
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c
index a3afa11a71a10dbb720ee9acb566991fe55b98a0..74fedfdec3ae4e034ec4d946179e963c783b5923 100644
--- a/drivers/i2c/busses/i2c-qcom-cci.c
+++ b/drivers/i2c/busses/i2c-qcom-cci.c
@@ -466,21 +466,12 @@ static const struct i2c_algorithm cci_algo = {
.functionality = cci_func,
};
-static int cci_enable_clocks(struct cci *cci)
-{
- return clk_bulk_prepare_enable(cci->nclocks, cci->clocks);
-}
-
-static void cci_disable_clocks(struct cci *cci)
-{
- clk_bulk_disable_unprepare(cci->nclocks, cci->clocks);
-}
-
static int __maybe_unused cci_suspend_runtime(struct device *dev)
{
struct cci *cci = dev_get_drvdata(dev);
- cci_disable_clocks(cci);
+ clk_bulk_disable_unprepare(cci->nclocks, cci->clocks);
+
return 0;
}
@@ -489,11 +480,12 @@ static int __maybe_unused cci_resume_runtime(struct device *dev)
struct cci *cci = dev_get_drvdata(dev);
int ret;
- ret = cci_enable_clocks(cci);
+ ret = clk_bulk_prepare_enable(cci->nclocks, cci->clocks);
if (ret)
return ret;
cci_init(cci);
+
return 0;
}
@@ -592,7 +584,7 @@ static int cci_probe(struct platform_device *pdev)
return dev_err_probe(dev, -EINVAL, "not enough clocks in DT\n");
cci->nclocks = ret;
- ret = cci_enable_clocks(cci);
+ ret = clk_bulk_prepare_enable(cci->nclocks, cci->clocks);
if (ret < 0)
return ret;
@@ -651,7 +643,7 @@ static int cci_probe(struct platform_device *pdev)
error:
disable_irq(cci->irq);
disable_clocks:
- cci_disable_clocks(cci);
+ clk_bulk_disable_unprepare(cci->nclocks, cci->clocks);
return ret;
}
--
2.51.0
next prev parent reply other threads:[~2025-09-04 14:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 14:31 [PATCH 0/5] Qualcomm CCI I2C clock requirements enforcement Konrad Dybcio
2025-09-04 14:31 ` [PATCH 1/5] arm64: dts: qcom: sc8280xp: Fix CCI3 interrupt Konrad Dybcio
2025-09-04 14:35 ` Bryan O'Donoghue
2025-09-04 14:31 ` [PATCH 2/5] dt-bindings: i2c: qcom-cci: Allow operating-points-v2 Konrad Dybcio
2025-09-04 14:50 ` Bryan O'Donoghue
2025-09-05 18:03 ` Rob Herring (Arm)
2025-09-04 14:31 ` Konrad Dybcio [this message]
2025-09-04 14:52 ` [PATCH 3/5] i2c: qcom-cci: Drop single-line wrappers Bryan O'Donoghue
2025-09-05 7:40 ` Loic Poulain
2025-09-04 14:31 ` [PATCH 4/5] i2c: qcom-cci: Add OPP table support and enforce FAST_PLUS requirements Konrad Dybcio
2025-09-04 14:50 ` Konrad Dybcio
2025-09-04 14:55 ` Bryan O'Donoghue
2025-09-08 8:36 ` Stephan Gerhold
2025-09-08 8:43 ` Konrad Dybcio
2025-09-08 8:46 ` Stephan Gerhold
2025-09-08 9:49 ` Konrad Dybcio
2025-09-08 9:57 ` Stephan Gerhold
2025-09-08 10:00 ` Konrad Dybcio
2025-09-08 10:09 ` Stephan Gerhold
2025-09-09 8:39 ` Konrad Dybcio
2025-09-10 10:57 ` Mukesh Savaliya
2025-09-04 14:31 ` [PATCH 5/5] arm64: dts: qcom: sc8280xp: Add OPP table for CCI hosts Konrad Dybcio
2025-09-04 14:56 ` Bryan O'Donoghue
2025-09-10 10:57 ` [PATCH 0/5] Qualcomm CCI I2C clock requirements enforcement Mukesh Savaliya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250904-topic-cci_updates-v1-3-d38559692703@oss.qualcomm.com \
--to=konradybcio@kernel.org \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=marijn.suijten@somainline.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).