From: Conor Dooley <conor@kernel.org>
To: Marek Vasut <marek.vasut@mailbox.org>
Cc: linux-arm-kernel@lists.infradead.org,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Conor Dooley <conor+dt@kernel.org>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] regulator: dt-bindings: rpi-panel: Split 7" Raspberry Pi 720x1280 v2 binding
Date: Fri, 5 Sep 2025 20:03:47 +0100 [thread overview]
Message-ID: <20250905-imaginary-crazy-a5734cb794fc@spud> (raw)
In-Reply-To: <3ba2de63-4282-4b1e-a576-0b4501e56a7b@mailbox.org>
[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]
On Fri, Sep 05, 2025 at 08:55:16PM +0200, Marek Vasut wrote:
> On 9/5/25 8:46 PM, Conor Dooley wrote:
>
> Hi,
>
> > > +examples:
> > > + - |
> > > + i2c {
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > + gpio@45 {
> >
> > ngl, seems strange to classify the device as a regulator in directory
> > and name, but use gpio as the node name in the example.
> >
> > Otherwise, this seems fine - if you feel that the hardware is
> > substantively differentially to what's in the "v1" regulator then
> > keeping them apart is valid.
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> I can rename it to "mcu@" or "mfd@" some such ?
Sure.
>
> I originally thought it could be compatible with the V1, which is why I
> tried to conflate them into single binding in 6d09c6e474bd ("regulator:
> dt-bindings: rpi-panel: Add regulator for 7" Raspberry Pi 720x1280") , but
> they are too different, so this undoes the change and creates separate
> binding.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-09-05 19:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 19:58 [PATCH] regulator: dt-bindings: rpi-panel: Split 7" Raspberry Pi 720x1280 v2 binding Marek Vasut
2025-09-05 18:46 ` Conor Dooley
2025-09-05 18:55 ` Marek Vasut
2025-09-05 19:03 ` Conor Dooley [this message]
2025-09-05 19:17 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250905-imaginary-crazy-a5734cb794fc@spud \
--to=conor@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=marek.vasut@mailbox.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).