From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C7BB1C84AE; Fri, 5 Sep 2025 15:17:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757085461; cv=none; b=a6a1vGi5JaiuqANtVU5M1faJyZleISY72gyg5LlkVfmelNc303beBEditgMhMNgD+gwdbklEo8FyQuCajlQA3IQGVwazmTJXNMrcf+Ta1plls1qDzSbuqHb/yzUIQpcUcvxpdzmLl2yESYr4BZPY8CMw8uLG5lJftkiOoZuAAv8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757085461; c=relaxed/simple; bh=ZDMZmwFVprdwP6uIwZJxxoRillFdVRRDd7v74bXNSqs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z8HAE6tVSCHTuigxiET67pyl6Ln8yhvGZ5H0wBQAKnjoZrtZw7Ro1uAQYj3F8yCz0zC9910Zh7rSrtsTExR6zVqoBBXRhijvYnV9YQV4SRo5kFx7ioCXarKMh2XyWFLi2o66/0bJ7oK5H1N6T++3/7NXvWUdiD9+t7kssnrPIYk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=l4j9yTlN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l4j9yTlN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D300FC4CEF1; Fri, 5 Sep 2025 15:17:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757085460; bh=ZDMZmwFVprdwP6uIwZJxxoRillFdVRRDd7v74bXNSqs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l4j9yTlNkRclcDOMxYQ51YiZTtuXyRpFfmApayK9UpqbnK7mKINjELxwpt025Rwgc hIiEycQUINH8zlkSysf2YUWw1QfNsz8TyB48qeJH3KBbRaSmVCUBc66E1bS24mrlBp Z/2A33HLUhSvsPeU82bXzMCuoKgYmT25+F8qIcE8WOw3R5txSIzMx12TLzhHe3q0QK dKsRqd0pe1S64LygZFQQf8ktvgyTtLyTwzEegqdrKr9dEqKmoW9gNxfPc0DTmSuHMw myoGcE6Pcv5U8cz7M3FI5jOWoKzjjRuNkhISiau3dMlnEzPEBZQekkMM7naAoAJr3P AdGhzjrkEh+TA== Date: Fri, 5 Sep 2025 10:17:39 -0500 From: Rob Herring To: Aleksandrs Vinarskis Cc: Hans de Goede , Lee Jones , Pavel Machek , Krzysztof Kozlowski , Conor Dooley , Bryan O'Donoghue , Daniel Thompson , Jingoo Han , Mauro Carvalho Chehab , Jean-Jacques Hiblot , Jacopo Mondi , Sakari Ailus , Bjorn Andersson , Konrad Dybcio , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Thompson , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 1/4] dt-bindings: leds: add generic LED consumer documentation Message-ID: <20250905151739.GA953718-robh@kernel.org> References: <20250905-leds-v2-0-ed8f66f56da8@vinarskis.com> <20250905-leds-v2-1-ed8f66f56da8@vinarskis.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250905-leds-v2-1-ed8f66f56da8@vinarskis.com> On Fri, Sep 05, 2025 at 09:59:29AM +0200, Aleksandrs Vinarskis wrote: > Introduce common generic led consumer binding, where consumer defines > led(s) by phandle, as opposed to trigger-source binding where the > trigger source is defined in led itself. > > Add already used in some schemas 'leds' parameter which expects > phandle-array. Additionally, introduce 'led-names' which could be used > by consumers to map LED devices to their respective functions. Please update the existing user dropping the type $ref and indicate how many entries (i.e. "maxItems: 1"). > > Signed-off-by: Aleksandrs Vinarskis > --- > .../devicetree/bindings/leds/leds-consumer.yaml | 85 ++++++++++++++++++++++ > 1 file changed, 85 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/leds-consumer.yaml b/Documentation/devicetree/bindings/leds/leds-consumer.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..077dbe3ad9ff3fa15236b8dd1f448c00271e4810 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-consumer.yaml > @@ -0,0 +1,85 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/leds-consumer.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Common leds consumer > + > +maintainers: > + - Aleksandrs Vinarskis > + > +description: > + Some LED defined in DT are required by other DT consumers, for example > + v4l2 subnode may require privacy or flash LED. Unlike trigger-source > + approach which is typically used as 'soft' binding, referencing LED > + devices by phandle makes things simpler when 'hard' binding is desired. > + > + Document LED properties that its consumers may define. > + select: true > +properties: > + leds: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: > + A list of LED device(s) required by a particular consumer. > + items: > + maxItems: 1 > + > + led-names: > + description: > + A list of device name(s). Used to map LED devices to their respective > + functions, when consumer requires more than one LED. > + > +additionalProperties: true > + > +examples: > + - | > + #include > + #include > + > + leds { > + compatible = "gpio-leds"; > + > + privacy_led: privacy-led { > + color = ; > + default-state = "off"; > + function = LED_FUNCTION_INDICATOR; > + gpios = <&tlmm 110 GPIO_ACTIVE_HIGH>; > + }; > + }; > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + camera@36 { > + compatible = "ovti,ov02c10"; > + reg = <0x36>; > + > + reset-gpios = <&tlmm 237 GPIO_ACTIVE_LOW>; > + pinctrl-names = "default"; > + pinctrl-0 = <&cam_rgb_default>; > + > + led-names = "privacy-led"; > + leds = <&privacy_led>; > + > + clocks = <&ov02e10_clk>; > + > + assigned-clocks = <&ov02e10_clk>; > + assigned-clock-rates = <19200000>; > + > + avdd-supply = <&vreg_l7b_2p8>; > + dvdd-supply = <&vreg_l7b_2p8>; > + dovdd-supply = <&vreg_cam_1p8>; > + > + port { > + ov02e10_ep: endpoint { > + data-lanes = <1 2>; > + link-frequencies = /bits/ 64 <400000000>; > + remote-endpoint = <&csiphy4_ep>; > + }; > + }; > + }; > + }; > + > +... > > -- > 2.48.1 >