Re: [PATCH v3 2/3] iio: adc: Support ROHM BD79112 ADC/GPIO

[Jonathan Cameron <jic23@kernel.org>]

On Fri, 5 Sep 2025 10:10:55 +0300
Matti Vaittinen <mazziesaccount@gmail.com> wrote:

> On 05/09/2025 09:54, Andy Shevchenko wrote:
> > On Fri, Sep 5, 2025 at 9:42 AM Matti Vaittinen <mazziesaccount@gmail.com> wrote:  
> >>
> >> The ROHM BD79112 is an ADC/GPIO with 32 channels. The channel inputs can
> >> be used as ADC or GPIO. Using the GPIOs as IRQ sources isn't supported.
> >>
> >> The ADC is 12-bit, supporting input voltages up to 5.7V, and separate I/O
> >> voltage supply. Maximum SPI clock rate is 20 MHz (10 MHz with
> >> daisy-chain configuration) and maximum sampling rate is 1MSPS.
> >>
> >> The IC does also support CRC but it is not implemented in the driver.  
> > 
> > ...
> >   
> >> +config ROHM_BD79112
> >> +       tristate "Rohm BD79112 ADC driver"
> >> +       depends on I2C && GPIOLIB  
> > 
> > Still I2C?  
> 
> Thanks :) I didn't spot this @_@. I just switched the REGMAP_I2C to 
> REGMAP_SPI. Will fix.
> 
> >   
> >> +       select REGMAP_SPI
> >> +       select IIO_ADC_HELPER
> >> +       help
> >> +         Say yes here to build support for the ROHM BD79112 ADC. The
> >> +         ROHM BD79112 is a 12-bit, 32-channel, SAR ADC, which analog  
> > 
> > which --> where  
> 
> I thought which (as a genetive case) would work here just fine?

If you had 'on which' I think it would be fine.
With just 'which' it doesn't work.  I'm too lazy to figure out exactly
why though :(

I'd probably make it a separate sentence though.  Analog inputs can also
be used for GPIO.