devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/2] dt-bindings: iio: afe: current-sense-amplifier: Add io-channel-cells
@ 2025-09-05  6:55 Primoz Fiser
  2025-09-05  6:55 ` [PATCH v2 2/2] arm64: dts: freescale: imx93-phyboard-nash: Current sense via iio-hwmon Primoz Fiser
  2025-09-05  8:20 ` [PATCH v2 1/2] dt-bindings: iio: afe: current-sense-amplifier: Add io-channel-cells Krzysztof Kozlowski
  0 siblings, 2 replies; 5+ messages in thread
From: Primoz Fiser @ 2025-09-05  6:55 UTC (permalink / raw)
  To: Peter Rosin, Jonathan Cameron, David Lechner, Nuno Sa,
	Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
  Cc: linux-iio, devicetree, linux-kernel, imx, linux-arm-kernel,
	upstream

The current-sense-amplifier is an IIO provider thus can be referenced by
IIO consumers (via "io-channels" property in consumer device node). Such
provider is required to describe number of cells used in phandle lookup
with "io-channel-cells" property.

Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
---
Changes in v2:
- refactor commit msg drop warnings introduced by commit #2
- drop Fixes: tag

Link to v1: https://lore.kernel.org/all/20250903113700.3079626-1-primoz.fiser@norik.com/

 .../devicetree/bindings/iio/afe/current-sense-amplifier.yaml  | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/afe/current-sense-amplifier.yaml b/Documentation/devicetree/bindings/iio/afe/current-sense-amplifier.yaml
index 527501c1d695..bcf4ddcfd13b 100644
--- a/Documentation/devicetree/bindings/iio/afe/current-sense-amplifier.yaml
+++ b/Documentation/devicetree/bindings/iio/afe/current-sense-amplifier.yaml
@@ -24,6 +24,9 @@ properties:
     description: |
       Channel node of a voltage io-channel.
 
+  "#io-channel-cells":
+    const: 0
+
   sense-resistor-micro-ohms:
     description: The sense resistance.
 
@@ -46,6 +49,7 @@ examples:
   - |
     sysi {
         compatible = "current-sense-amplifier";
+        #io-channel-cells = <0>;
         io-channels = <&tiadc 0>;
 
         sense-resistor-micro-ohms = <20000>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2 2/2] arm64: dts: freescale: imx93-phyboard-nash: Current sense via iio-hwmon
  2025-09-05  6:55 [PATCH v2 1/2] dt-bindings: iio: afe: current-sense-amplifier: Add io-channel-cells Primoz Fiser
@ 2025-09-05  6:55 ` Primoz Fiser
  2025-09-11  3:27   ` Shawn Guo
  2025-09-05  8:20 ` [PATCH v2 1/2] dt-bindings: iio: afe: current-sense-amplifier: Add io-channel-cells Krzysztof Kozlowski
  1 sibling, 1 reply; 5+ messages in thread
From: Primoz Fiser @ 2025-09-05  6:55 UTC (permalink / raw)
  To: Peter Rosin, Jonathan Cameron, David Lechner, Nuno Sa,
	Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
  Cc: linux-iio, devicetree, linux-kernel, imx, linux-arm-kernel,
	upstream

Commit 21179eae56de ("arm64: dts: freescale: imx93-phyboard-nash: Add
current sense amplifier") added information about the current sensing
circuitry found on the board. Now, lets provide current sense reading
also via IIO-hwmon subsystem. This way, SoM current can be read directly
via sysfs property more conveniently for the customers. No need for them
to manually apply scaling factor calculations anymore.

Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
---
Changes in v2:                                                                  
- no changes
            
Link to v1: https://lore.kernel.org/all/20250903113700.3079626-2-primoz.fiser@norik.com/

 arch/arm64/boot/dts/freescale/imx93-phyboard-nash.dts | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx93-phyboard-nash.dts b/arch/arm64/boot/dts/freescale/imx93-phyboard-nash.dts
index 71a0e9f270af..d05645f25bba 100644
--- a/arch/arm64/boot/dts/freescale/imx93-phyboard-nash.dts
+++ b/arch/arm64/boot/dts/freescale/imx93-phyboard-nash.dts
@@ -27,8 +27,9 @@ chosen {
 		stdout-path = &lpuart1;
 	};
 
-	current-sense {
+	curr_sens: current-sense {
 		compatible = "current-sense-amplifier";
+		#io-channel-cells = <0>;
 		io-channels = <&adc1 1>;
 		sense-gain-div = <2>;
 		sense-gain-mult = <50>;
@@ -44,6 +45,11 @@ flexcan1_tc: can-phy0 {
 		standby-gpios = <&gpio4 16 GPIO_ACTIVE_HIGH>;
 	};
 
+	iio-hwmon {
+		compatible = "iio-hwmon";
+		io-channels = <&curr_sens 0>;
+	};
+
 	reg_usdhc2_vmmc: regulator-usdhc2 {
 		compatible = "regulator-fixed";
 		gpio = <&gpio3 7 GPIO_ACTIVE_HIGH>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: iio: afe: current-sense-amplifier: Add io-channel-cells
  2025-09-05  6:55 [PATCH v2 1/2] dt-bindings: iio: afe: current-sense-amplifier: Add io-channel-cells Primoz Fiser
  2025-09-05  6:55 ` [PATCH v2 2/2] arm64: dts: freescale: imx93-phyboard-nash: Current sense via iio-hwmon Primoz Fiser
@ 2025-09-05  8:20 ` Krzysztof Kozlowski
  2025-09-07 11:44   ` Jonathan Cameron
  1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2025-09-05  8:20 UTC (permalink / raw)
  To: Primoz Fiser
  Cc: Peter Rosin, Jonathan Cameron, David Lechner, Nuno Sa,
	Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	linux-iio, devicetree, linux-kernel, imx, linux-arm-kernel,
	upstream

On Fri, Sep 05, 2025 at 08:55:02AM +0200, Primoz Fiser wrote:
> The current-sense-amplifier is an IIO provider thus can be referenced by
> IIO consumers (via "io-channels" property in consumer device node). Such
> provider is required to describe number of cells used in phandle lookup
> with "io-channel-cells" property.
> 
> Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
> ---
> Changes in v2:
> - refactor commit msg drop warnings introduced by commit #2
> - drop Fixes: tag

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: iio: afe: current-sense-amplifier: Add io-channel-cells
  2025-09-05  8:20 ` [PATCH v2 1/2] dt-bindings: iio: afe: current-sense-amplifier: Add io-channel-cells Krzysztof Kozlowski
@ 2025-09-07 11:44   ` Jonathan Cameron
  0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2025-09-07 11:44 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Primoz Fiser, Peter Rosin, David Lechner, Nuno Sa,
	Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	linux-iio, devicetree, linux-kernel, imx, linux-arm-kernel,
	upstream

On Fri, 5 Sep 2025 10:20:37 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On Fri, Sep 05, 2025 at 08:55:02AM +0200, Primoz Fiser wrote:
> > The current-sense-amplifier is an IIO provider thus can be referenced by
> > IIO consumers (via "io-channels" property in consumer device node). Such
> > provider is required to describe number of cells used in phandle lookup
> > with "io-channel-cells" property.
> > 
> > Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
> > ---
> > Changes in v2:
> > - refactor commit msg drop warnings introduced by commit #2
> > - drop Fixes: tag  
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied this patch to the togreg branch of iio.git.
I'll push that out as testing now because some other stuff on there
will benefit from 0-day taking a first look at it.

Thanks,

Jonathan

> 
> Best regards,
> Krzysztof
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 2/2] arm64: dts: freescale: imx93-phyboard-nash: Current sense via iio-hwmon
  2025-09-05  6:55 ` [PATCH v2 2/2] arm64: dts: freescale: imx93-phyboard-nash: Current sense via iio-hwmon Primoz Fiser
@ 2025-09-11  3:27   ` Shawn Guo
  0 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2025-09-11  3:27 UTC (permalink / raw)
  To: Primoz Fiser
  Cc: Peter Rosin, Jonathan Cameron, David Lechner, Nuno Sa,
	Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	linux-iio, devicetree, linux-kernel, imx, linux-arm-kernel,
	upstream

On Fri, Sep 05, 2025 at 08:55:03AM +0200, Primoz Fiser wrote:
> Commit 21179eae56de ("arm64: dts: freescale: imx93-phyboard-nash: Add
> current sense amplifier") added information about the current sensing
> circuitry found on the board. Now, lets provide current sense reading
> also via IIO-hwmon subsystem. This way, SoM current can be read directly
> via sysfs property more conveniently for the customers. No need for them
> to manually apply scaling factor calculations anymore.
> 
> Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>

Applied, thanks!


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-09-11  3:29 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-05  6:55 [PATCH v2 1/2] dt-bindings: iio: afe: current-sense-amplifier: Add io-channel-cells Primoz Fiser
2025-09-05  6:55 ` [PATCH v2 2/2] arm64: dts: freescale: imx93-phyboard-nash: Current sense via iio-hwmon Primoz Fiser
2025-09-11  3:27   ` Shawn Guo
2025-09-05  8:20 ` [PATCH v2 1/2] dt-bindings: iio: afe: current-sense-amplifier: Add io-channel-cells Krzysztof Kozlowski
2025-09-07 11:44   ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).