Devicetree
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Dixit Parmar <dixitparmar19@gmail.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: iio: magnetometer: Infineon TLV493D 3D Magnetic sensor
Date: Sun, 7 Sep 2025 12:49:52 +0100	[thread overview]
Message-ID: <20250907124952.31809adc@jic23-huawei> (raw)
In-Reply-To: <CAFmh=S0AP4_9H8CiSp3oAciNF=FGMGp4bFz6QEJNFGqwdvj65w@mail.gmail.com>

On Sun, 7 Sep 2025 16:43:34 +0530
Dixit Parmar <dixitparmar19@gmail.com> wrote:

> > Krzysztof gave an RB on version 3.  Please make sure to pick up such tags.
> >  
> Indeed, RB was given by Krzystof on the V3 patch but this patch got
> modified for MAINTAINERS file changes which were not part of V3.
> Considering that I thought it should be removed. I have added this in
> the cover letter change logs as well. Is this correct understanding?

When making small changes like that, it's a judgement call you need to make
on whether they are likely to affect the intent of the tag.

To me that one wasn't something that Krzystof was going care about.

Anyhow it's fine that you looked on it differently.  In cases like
this I'd expect to see a comment under the --- in the patch that a tag
was given but dropped because of xyz reasons.

Keep that in future versions until the tag is given again or other
comment invalidates it.

Jonathan

> > This time I'll apply it by hand if nothing else comes up.  
> Thanks,
> Dixit


  reply	other threads:[~2025-09-07 11:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-06  8:37 [PATCH v6 0/2] iio: magnetometer: add support for Infineon TLV493D 3D Magnetic Sensor Dixit Parmar
2025-09-06  8:37 ` [PATCH v6 1/2] dt-bindings: iio: magnetometer: Infineon TLV493D 3D Magnetic sensor Dixit Parmar
2025-09-07  9:36   ` Jonathan Cameron
2025-09-07 11:13     ` Dixit Parmar
2025-09-07 11:49       ` Jonathan Cameron [this message]
2025-09-08  7:25   ` Krzysztof Kozlowski
2025-09-06  8:37 ` [PATCH v6 2/2] iio: magnetometer: add support for Infineon TLV493D 3D Magentic sensor Dixit Parmar
2025-09-06  9:07   ` Andy Shevchenko
2025-09-07  9:49   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250907124952.31809adc@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dixitparmar19@gmail.com \
    --cc=dlechner@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox