From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EC3530AD0F for ; Mon, 8 Sep 2025 13:13:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757337192; cv=none; b=lxiJDCN9PCsLOAd1I0MwepuzAqILGNvzpWSBB1dRhf9mU/qY2bhXSh9UR3J1mJIxbIXjZFZ20ufXHKaBiXwBhUnneHug56N/xPU6nctB502HspL2HhoX8tdOgtAg0m7tyy0yNiNNbfi4cxUGaSHe2qtRQPQBz5lGvQykqkpwj6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757337192; c=relaxed/simple; bh=pOrwHMUpTRHTOWnb5cnnDdzeM4ESkRCjGNVfFG9Nc7M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=a3nnzlUv0TzxsG3LPv1SdEE8eNtyQSl53Cjfqe6MVvyd8cc3yoUA6Cq2983/fRRh+uuPotmyVf8S01IAaDED5Uo/jaS87Ne5OPpi8y+YxhoA/F2qgOxVxP7matHYzjrVxwY3t9sNzD4w9MdwMRraVTIGKkSOdlLmkCX+L+VU8p8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rROtODMr; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rROtODMr" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-45de6ab6ce7so5841845e9.1 for ; Mon, 08 Sep 2025 06:13:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757337189; x=1757941989; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6VURWIkfuPan7bcStL9p1ueaB35kinp1F/svGb9kGJc=; b=rROtODMrOUFVbXsu2ImHlo2eRQ2hVYDn3WNQaFI5q7xuUi+jxeSNFOZmLk+Or9Khbs YMy5wnwdoyYrwms2pXDXd4XwcAt1jopVRu2IXwifcwxNaDFjxwMK24D8NchRO4hcrSWp B8dBuqOdAlYcz85Wrnr3qeEwbqQK6cEim6qI9ojVDDAuaDr3hFqs1dtL8V1uWJI2PRaS RnHmMiMDVjCABp0yXGEKaJIj0Uu/szTPcvSqrRuwZdku0U+q2JpN4/05CcBhzSbHi5qz zwoyite3N1zu5XjYOttx/BnLizKRPftVTjUIH6+JtZJi9hBKU1UK8LlqRc5/+eCnaRN+ ZRcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757337189; x=1757941989; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6VURWIkfuPan7bcStL9p1ueaB35kinp1F/svGb9kGJc=; b=guGoazCCWVX6f7exLuHnKw7/ix9NNRvaGRlzkGOM0KEKt26EgPAfe36BPqljLK0Vnw nFDybVPKIA51u4XaOUFqg41aJBVEfxhDgHEPQtSQoqiIZsS+C8z7yTNekjLrAvGTxTY8 PUwgnw7hxXbz8rgFZd368ivNOIPHzx4a33MvjLmGcySbJBk/HUwuJtaMsamGlChVkXie pA4Z4N0kb8Zf2VNwoCKklTdvMBf6wmDMUNSWHc+2x483KQZ0Da7UwoSV0YEgYR+coUGv SrQnTUpUhVD5nMXWqRdDP1uO+xWhuZYEN1NFQzfcGjJi/lbGqQYReCr+tZLxaNhjk2pG QYuA== X-Forwarded-Encrypted: i=1; AJvYcCWWIG4b/BQJdaAf+VER2FeUb2FA7HpzjAZElIDjV4LYN/5S7gsJfWydWYOjcTzijDTntTshTC8q2Cox@vger.kernel.org X-Gm-Message-State: AOJu0YwkvSfJRzpqCLXcuyCcIJGgEjV3WcSWhv19LjHUYi+qnbHU4VC4 broX4dcMhAgO51lIyzQtXPE5yA20XBDrQZsX0g1i20HdH1SxVJpOwU6W/VF9eM+PB+0= X-Gm-Gg: ASbGncs6jkogMerWTT7pTDjHdu4SdYpw1oKjUPpJQ/TWu6lIsXMI6HgdyDbZk0r+4Yi MWvD/XjBA2SqHGodPsOphmyn/PGlXnpf9H4MUTqxyCiwu1kTa4iw0GrLN3m6vhSU75Botcga74o HqIwOrdlVWngilRSJ6ArkXbmXkaGnfLt05JbzNQECF8t1+2BUa9WlXAcWcZuhWS7AbNKeDLdEjR pMoUJXtwhgWIheG5ldMV4IW39dCFDnP2ACBAy/rnNIfntmJwvkpF9VRdUmJNGmczymhGYvh34xI qDPaPxaAIVybd7iu6nWUmvpDZXjXSsd6Iay83vHPpZNC0glQitM+Kj/5J6WHoEur4NGTf2Bha2k 3mYy14i6wd3a45COqK090VAzXn4ZZm0kGn+3HvyxpPeILAOd7EVNuuOXXR991LRX6uPRahfmi+q gh2Q== X-Google-Smtp-Source: AGHT+IF7+1AW9gZi8VQR2eAfB1khonQITj9xmbUIJb5Ssirri3fDS6+tN+4m3PJu5jGzW1eTe1Ha4w== X-Received: by 2002:a05:6000:2681:b0:3e4:74dc:a3bb with SMTP id ffacd0b85a97d-3e64bde9298mr7276281f8f.40.1757337181458; Mon, 08 Sep 2025 06:13:01 -0700 (PDT) Received: from ta2.c.googlers.com (219.43.233.35.bc.googleusercontent.com. [35.233.43.219]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3cf33fb9dbfsm41650181f8f.43.2025.09.08.06.13.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Sep 2025 06:13:01 -0700 (PDT) From: Tudor Ambarus Date: Mon, 08 Sep 2025 13:12:44 +0000 Subject: [PATCH v4 3/5] firmware: exynos-acpm: register ACPM clocks pdev Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250908-acpm-clk-v4-3-633350c0c0b1@linaro.org> References: <20250908-acpm-clk-v4-0-633350c0c0b1@linaro.org> In-Reply-To: <20250908-acpm-clk-v4-0-633350c0c0b1@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Alim Akhtar , Sylwester Nawrocki , Chanwoo Choi , Catalin Marinas , Will Deacon Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, willmcvicker@google.com, kernel-team@android.com, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1757337178; l=2606; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=pOrwHMUpTRHTOWnb5cnnDdzeM4ESkRCjGNVfFG9Nc7M=; b=UTpAb+oSnFVBaTobsje5fgi9yvKDrERYAhJexCt3pEL95FZ5z5dw1g464Yv1noAWgt1hsVIOP AMaQN6NW/q8D2uKwG/IM/JHV9cOncEqoKaD8YigxQkmL3ikjGunTHUd X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= Register by hand a platform device for the ACPM clocks. The ACPM clocks are not modeled as a DT child of ACPM because: 1/ they don't have their own resources. 2/ they are not a block that can be reused. The clock identifying data is reduced (clock ID, clock name and mailbox channel ID) and may differ from a SoC to another. Signed-off-by: Tudor Ambarus --- drivers/firmware/samsung/exynos-acpm.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/firmware/samsung/exynos-acpm.c b/drivers/firmware/samsung/exynos-acpm.c index 9fa0335ccf5db32892fdf09e8d4b0a885a8f8fb5..0cb269c7046015d4c5fe5731ba0d61d48dcaeee1 100644 --- a/drivers/firmware/samsung/exynos-acpm.c +++ b/drivers/firmware/samsung/exynos-acpm.c @@ -177,9 +177,11 @@ struct acpm_info { /** * struct acpm_match_data - of_device_id data. * @initdata_base: offset in SRAM where the channels configuration resides. + * @acpm_clk_dev_name: base name for the ACPM clocks device that we're registering. */ struct acpm_match_data { loff_t initdata_base; + const char *acpm_clk_dev_name; }; #define client_to_acpm_chan(c) container_of(c, struct acpm_chan, cl) @@ -604,9 +606,15 @@ static void acpm_setup_ops(struct acpm_info *acpm) pmic_ops->update_reg = acpm_pmic_update_reg; } +static void acpm_clk_pdev_unregister(void *data) +{ + platform_device_unregister(data); +} + static int acpm_probe(struct platform_device *pdev) { const struct acpm_match_data *match_data; + struct platform_device *acpm_clk_pdev; struct device *dev = &pdev->dev; struct device_node *shmem; struct acpm_info *acpm; @@ -647,6 +655,18 @@ static int acpm_probe(struct platform_device *pdev) platform_set_drvdata(pdev, acpm); + acpm_clk_pdev = platform_device_register_data(dev, + match_data->acpm_clk_dev_name, + PLATFORM_DEVID_NONE, NULL, 0); + if (IS_ERR(acpm_clk_pdev)) + return dev_err_probe(dev, PTR_ERR(acpm_clk_pdev), + "Failed to register ACPM clocks device.\n"); + + ret = devm_add_action_or_reset(dev, acpm_clk_pdev_unregister, + acpm_clk_pdev); + if (ret) + return dev_err_probe(dev, ret, "Failed to add devm action.\n"); + return devm_of_platform_populate(dev); } @@ -746,6 +766,7 @@ EXPORT_SYMBOL_GPL(devm_acpm_get_by_node); static const struct acpm_match_data acpm_gs101 = { .initdata_base = ACPM_GS101_INITDATA_BASE, + .acpm_clk_dev_name = "gs101-acpm-clk", }; static const struct of_device_id acpm_match[] = { -- 2.51.0.355.g5224444f11-goog