From: Jie Gan <jie.gan@oss.qualcomm.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Tingwei Zhang <tingwei.zhang@oss.qualcomm.com>,
Jinlong Mao <jinlong.mao@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, Jie Gan <jie.gan@oss.qualcomm.com>
Subject: [PATCH v6 8/9] coresight: tmc: integrate byte-cntr's read_ops with sysfs file_ops
Date: Mon, 08 Sep 2025 10:02:00 +0800 [thread overview]
Message-ID: <20250908-enable-byte-cntr-for-tmc-v6-8-1db9e621441a@oss.qualcomm.com> (raw)
In-Reply-To: <20250908-enable-byte-cntr-for-tmc-v6-0-1db9e621441a@oss.qualcomm.com>
Add code logic to invoke byte-cntr's sysfs_read_ops if the byte-cntr
is enabled.
Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
---
drivers/hwtracing/coresight/coresight-tmc-core.c | 53 +++++++++++++++++++++++-
1 file changed, 52 insertions(+), 1 deletion(-)
diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwtracing/coresight/coresight-tmc-core.c
index ccb177d953b9..2895a9b431c3 100644
--- a/drivers/hwtracing/coresight/coresight-tmc-core.c
+++ b/drivers/hwtracing/coresight/coresight-tmc-core.c
@@ -31,6 +31,7 @@
#include "coresight-priv.h"
#include "coresight-tmc.h"
+#include "coresight-ctcu.h"
DEFINE_CORESIGHT_DEVLIST(etb_devs, "tmc_etb");
DEFINE_CORESIGHT_DEVLIST(etf_devs, "tmc_etf");
@@ -228,15 +229,47 @@ static int tmc_prepare_crashdata(struct tmc_drvdata *drvdata)
return 0;
}
+/* Return the byte-cntr's sysfs_read_ops if in use */
+static const struct sysfs_read_ops *tmc_get_byte_cntr_sysfs_ops(struct tmc_drvdata *drvdata)
+{
+ struct ctcu_byte_cntr *byte_cntr_data;
+ struct ctcu_drvdata *ctcu_drvdata;
+ struct coresight_device *helper;
+ int port;
+
+ helper = coresight_get_helper(drvdata->csdev, CORESIGHT_DEV_SUBTYPE_HELPER_CTCU);
+ if (!helper)
+ return NULL;
+
+ port = coresight_get_in_port_dest(drvdata->csdev, helper);
+ if (port < 0)
+ return NULL;
+
+ ctcu_drvdata = dev_get_drvdata(helper->dev.parent);
+ byte_cntr_data = &ctcu_drvdata->byte_cntr_data[port];
+ if (byte_cntr_data && byte_cntr_data->thresh_val)
+ return ctcu_drvdata->byte_cntr_sysfs_read_ops;
+
+ return NULL;
+}
+
static int tmc_read_prepare(struct tmc_drvdata *drvdata)
{
+ const struct sysfs_read_ops *byte_cntr_sysfs_read_ops;
int ret = 0;
+ byte_cntr_sysfs_read_ops = tmc_get_byte_cntr_sysfs_ops(drvdata);
+ if (byte_cntr_sysfs_read_ops) {
+ ret = byte_cntr_sysfs_read_ops->read_prepare(drvdata);
+ goto out;
+ }
+
if (drvdata->sysfs_ops)
ret = drvdata->sysfs_ops->read_prepare(drvdata);
else
ret = -EINVAL;
+out:
if (!ret)
dev_dbg(&drvdata->csdev->dev, "TMC read start\n");
@@ -245,13 +278,21 @@ static int tmc_read_prepare(struct tmc_drvdata *drvdata)
static int tmc_read_unprepare(struct tmc_drvdata *drvdata)
{
+ const struct sysfs_read_ops *byte_cntr_sysfs_read_ops;
int ret = 0;
+ byte_cntr_sysfs_read_ops = tmc_get_byte_cntr_sysfs_ops(drvdata);
+ if (byte_cntr_sysfs_read_ops) {
+ ret = byte_cntr_sysfs_read_ops->read_unprepare(drvdata);
+ goto out;
+ }
+
if (drvdata->sysfs_ops)
ret = drvdata->sysfs_ops->read_unprepare(drvdata);
else
ret = -EINVAL;
+out:
if (!ret)
dev_dbg(&drvdata->csdev->dev, "TMC read end\n");
@@ -277,6 +318,12 @@ static int tmc_open(struct inode *inode, struct file *file)
static ssize_t tmc_get_sysfs_trace(struct tmc_drvdata *drvdata, loff_t pos, size_t len,
char **bufpp)
{
+ const struct sysfs_read_ops *byte_cntr_sysfs_read_ops;
+
+ byte_cntr_sysfs_read_ops = tmc_get_byte_cntr_sysfs_ops(drvdata);
+ if (byte_cntr_sysfs_read_ops)
+ return byte_cntr_sysfs_read_ops->get_trace_data(drvdata, pos, len, bufpp);
+
if (drvdata->sysfs_ops)
return drvdata->sysfs_ops->get_trace_data(drvdata, pos, len, bufpp);
@@ -300,7 +347,11 @@ static ssize_t tmc_read(struct file *file, char __user *data, size_t len,
return -EFAULT;
}
- *ppos += actual;
+ if (drvdata->reading_node)
+ drvdata->reading_node->pos += actual;
+ else
+ *ppos += actual;
+
dev_dbg(&drvdata->csdev->dev, "%zu bytes copied\n", actual);
return actual;
--
2.34.1
next prev parent reply other threads:[~2025-09-08 2:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 2:01 [PATCH v6 0/9] coresight: ctcu: Enable byte-cntr function for TMC ETR Jie Gan
2025-09-08 2:01 ` [PATCH v6 1/9] coresight: core: Refactoring ctcu_get_active_port and make it generic Jie Gan
2025-12-03 16:18 ` Suzuki K Poulose
2025-12-04 2:45 ` Jie Gan
2025-09-08 2:01 ` [PATCH v6 2/9] coresight: core: add a new API to retrieve the helper device Jie Gan
2025-12-03 16:15 ` Suzuki K Poulose
2025-12-04 2:47 ` Jie Gan
2025-09-08 2:01 ` [PATCH v6 3/9] coresight: tmc: add etr_buf_list to store allocated etr_buf Jie Gan
2025-12-03 14:24 ` Mike Leach
2025-12-03 16:20 ` Suzuki K Poulose
2025-09-08 2:01 ` [PATCH v6 4/9] coresight: tmc: add create/clean functions for etr_buf_list Jie Gan
2025-12-03 14:26 ` Mike Leach
2025-09-08 2:01 ` [PATCH v6 5/9] coresight: tmc: Introduce sysfs_read_ops to wrap sysfs read operations Jie Gan
2025-09-08 2:01 ` [PATCH v6 6/9] dt-bindings: arm: add an interrupt property for Coresight CTCU Jie Gan
2025-12-03 14:30 ` Mike Leach
2025-12-04 2:49 ` Jie Gan
2025-12-03 18:14 ` Suzuki K Poulose
2025-12-04 2:53 ` Jie Gan
2025-12-04 9:22 ` Suzuki K Poulose
2025-12-05 1:01 ` Jie Gan
2025-09-08 2:01 ` [PATCH v6 7/9] coresight: ctcu: enable byte-cntr for TMC ETR devices Jie Gan
2025-09-08 2:02 ` Jie Gan [this message]
2025-09-08 2:02 ` [PATCH v6 9/9] arm64: dts: qcom: lemans: Add interrupts to CTCU device Jie Gan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250908-enable-byte-cntr-for-tmc-v6-8-1db9e621441a@oss.qualcomm.com \
--to=jie.gan@oss.qualcomm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@linaro.org \
--cc=jinlong.mao@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=tingwei.zhang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).