Re: [PATCH phy 13/14] dt-bindings: phy: lynx-28g: add compatible strings per SerDes and instantiation

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]

On Tue, Sep 09, 2025 at 02:35:43PM +0300, Vladimir Oltean wrote:
> On Mon, Sep 08, 2025 at 04:04:45PM +0000, Josua Mayer wrote:
> > Am 08.09.25 um 17:37 schrieb Vladimir Oltean:
> > > On Mon, Sep 08, 2025 at 02:02:35PM +0000, Josua Mayer wrote:
> > >>> My updated plan is to describe the schema rules for the compatible as
> > >>> follows. Is that ok with everyone?
> > >>>
> > >>> properties:
> > >>>   compatible:
> > >>>     oneOf:
> > >>>       - const: fsl,lynx-28g
> > >>>         deprecated: true
> > >>>       - items:
> > >>>           - const: fsl,lx2160a-serdes1
> > >>>           - const: fsl,lynx-28g
> > >>>       - enum:
> > missed fsl,lx2160a-serdes1
> 
> I didn't miss anything. "fsl,lx2160a-serdes1" is deliberately not in
> "enum" because there's no point specifying this compatible as
> standalone, if for backwards compatibility reasons it will always have
> to be "fsl,lx2160a-serdes1", "fsl,lynx-28g" (it was described as
> "fsl,lynx-28g" before), which is already covered by "items".

I think Josua was pointing out their own omission here.

> > >>>           - fsl,lx2160a-serdes2
> > >>>           - fsl,lx2160a-serdes3
> > >>>           - fsl,lx2162a-serdes1
> > >>>           - fsl,lx2162a-serdes2

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]