From: Andreas Kemnade <andreas@kemnade.info>
To: Rob Herring <robh@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Andreas Kemnade <akemnade@kernel.org>, Lee Jones <lee@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alistair Francis <alistair@alistair23.me>,
Liam Girdwood <lgirdwood@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] dt-bindings: mfd: sy7636a: Add missing gpio pins and supply
Date: Tue, 9 Sep 2025 09:13:50 +0200 [thread overview]
Message-ID: <20250909091350.7732243e@akair> (raw)
In-Reply-To: <20250909004458.GA2311693-robh@kernel.org>
Am Mon, 8 Sep 2025 19:44:58 -0500
schrieb Rob Herring <robh@kernel.org>:
> On Mon, Sep 08, 2025 at 03:34:00PM +0100, Mark Brown wrote:
> > On Sat, Sep 06, 2025 at 02:01:25PM +0200, Krzysztof Kozlowski wrote:
> > > On 06/09/2025 11:09, Andreas Kemnade wrote:
> >
> > > > + en-gpios:
> >
> > > enable-gpios, unless it is something else, but then please explain in
> > > the description.
> >
> > > > + description:
> > > > + If EN pin is not hardwired, specify it here to have it set up.
> > > > + maxItems: 1
> >
> > It seems reasonable to name the property after the pin on the device?
>
> Yes, but in general we've standardized on reset, enable, powerdown, etc.
> rather than all the possible variations of those names. At least with
> 'reset', standardizing it has bought us the ability to handle it with
> the reset framework rather than every driver implementing its own GPIO
> twiddling.
>
ok, then I will do
EN -> enable-gpios
VCOM_EN -> vcom-en-gpios (as is)
Regards,
Andreas
next prev parent reply other threads:[~2025-09-09 7:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-06 9:09 [PATCH 0/4] regulator: sy7636a: define and init all resources needed Andreas Kemnade
2025-09-06 9:09 ` [PATCH 1/4] dt-bindings: mfd: sy7636a: Add missing gpio pins and supply Andreas Kemnade
2025-09-06 12:01 ` Krzysztof Kozlowski
2025-09-08 10:54 ` Andreas Kemnade
2025-09-08 14:34 ` Mark Brown
2025-09-09 0:44 ` Rob Herring
2025-09-09 7:13 ` Andreas Kemnade [this message]
2025-09-06 9:09 ` [PATCH 2/4] regulator: sy7636a: fix lifecycle of power good gpio Andreas Kemnade
2025-09-06 14:35 ` Peng Fan
2025-09-08 8:00 ` Alistair
2025-09-06 9:09 ` [PATCH 3/4] regulator: sy7636a: add gpios and input regulator Andreas Kemnade
2025-09-06 14:32 ` Peng Fan
2025-09-07 11:26 ` Dan Carpenter
2025-09-06 9:09 ` [PATCH 4/4] ARM: dts: imx: e70k02: add sy7636 Andreas Kemnade
2025-09-08 8:07 ` Alistair
2025-09-09 13:34 ` (subset) [PATCH 0/4] regulator: sy7636a: define and init all resources needed Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250909091350.7732243e@akair \
--to=andreas@kemnade.info \
--cc=akemnade@kernel.org \
--cc=alistair@alistair23.me \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).