* [PATCH RESEND v4 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback
@ 2025-09-10 2:05 Fabio Estevam
2025-09-10 2:05 ` [PATCH RESEND v4 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks Fabio Estevam
2025-09-10 2:05 ` [PATCH RESEND v4 3/3] ARM: dts: imx6sl: Provide a more specific lcdif compatible Fabio Estevam
0 siblings, 2 replies; 8+ messages in thread
From: Fabio Estevam @ 2025-09-10 2:05 UTC (permalink / raw)
To: shawnguo
Cc: robh, krzk+dt, conor+dt, dri-devel, devicetree, linux-arm-kernel,
imx, kernel, Fabio Estevam, Ahmad Fatoum
imx6sx.dtsi has the following lcdif entries:
compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif";
This causes the following dt-schema warning:
['fsl,imx6sx-lcdif', 'fsl,imx28-lcdif'] is too long
To keep DT compatibility, document 'fsl,imx28-lcdif' as a possible
'fsl,imx6sx-lcdif' fallback.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
index 2dd0411ec651..ce31b873fb95 100644
--- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
+++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
@@ -19,7 +19,6 @@ properties:
- enum:
- fsl,imx23-lcdif
- fsl,imx28-lcdif
- - fsl,imx6sx-lcdif
- fsl,imx8mp-lcdif
- fsl,imx93-lcdif
- items:
@@ -32,6 +31,10 @@ properties:
- fsl,imx8mn-lcdif
- fsl,imx8mq-lcdif
- const: fsl,imx6sx-lcdif
+ - items:
+ - enum:
+ - fsl,imx6sx-lcdif
+ - const: fsl,imx28-lcdif
reg:
maxItems: 1
@@ -199,7 +202,7 @@ examples:
#include <dt-bindings/interrupt-controller/arm-gic.h>
display-controller@2220000 {
- compatible = "fsl,imx6sx-lcdif";
+ compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif";
reg = <0x02220000 0x4000>;
interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6SX_CLK_LCDIF1_PIX>,
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH RESEND v4 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks
2025-09-10 2:05 [PATCH RESEND v4 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback Fabio Estevam
@ 2025-09-10 2:05 ` Fabio Estevam
2025-09-10 15:55 ` Frank Li
2025-09-10 2:05 ` [PATCH RESEND v4 3/3] ARM: dts: imx6sl: Provide a more specific lcdif compatible Fabio Estevam
1 sibling, 1 reply; 8+ messages in thread
From: Fabio Estevam @ 2025-09-10 2:05 UTC (permalink / raw)
To: shawnguo
Cc: robh, krzk+dt, conor+dt, dri-devel, devicetree, linux-arm-kernel,
imx, kernel, Fabio Estevam, Ahmad Fatoum
mx6sl.dtsi and imx6sll.dtsi have the following lcdif entries:
compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif";
This causes dt-schema warnings as the current binding only
allow 'fsl,imx6sx-lcdif' as fallback.
['fsl,imx6sl-lcdif', 'fsl,imx28-lcdif'] is too long
['fsl,imx6sll-lcdif', 'fsl,imx28-lcdif'] is too long
The imx6sx-lcdif programming model has more advanced features, such
as overlay plane and the CRC32 support than the imx28-lcdif IP.
Expand the imx6sl/imx6sll lcdif fallbacks to accept a less specific
fsl,imx28-lcdif fallback:
compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif", "fsl,imx28-lcdif";
This helps keeping DT compatibility as well as using the more advanced
lcdif features found on imx6sl and imx6sll.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
index ce31b873fb95..d665f3241e97 100644
--- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
+++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
@@ -23,14 +23,18 @@ properties:
- fsl,imx93-lcdif
- items:
- enum:
- - fsl,imx6sl-lcdif
- - fsl,imx6sll-lcdif
- fsl,imx6ul-lcdif
- fsl,imx7d-lcdif
- fsl,imx8mm-lcdif
- fsl,imx8mn-lcdif
- fsl,imx8mq-lcdif
- const: fsl,imx6sx-lcdif
+ - items:
+ - enum:
+ - fsl,imx6sl-lcdif
+ - fsl,imx6sll-lcdif
+ - const: fsl,imx6sx-lcdif
+ - const: fsl,imx28-lcdif
- items:
- enum:
- fsl,imx6sx-lcdif
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH RESEND v4 3/3] ARM: dts: imx6sl: Provide a more specific lcdif compatible
2025-09-10 2:05 [PATCH RESEND v4 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback Fabio Estevam
2025-09-10 2:05 ` [PATCH RESEND v4 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks Fabio Estevam
@ 2025-09-10 2:05 ` Fabio Estevam
2025-09-10 16:39 ` Frank Li
1 sibling, 1 reply; 8+ messages in thread
From: Fabio Estevam @ 2025-09-10 2:05 UTC (permalink / raw)
To: shawnguo
Cc: robh, krzk+dt, conor+dt, dri-devel, devicetree, linux-arm-kernel,
imx, kernel, Fabio Estevam, Ahmad Fatoum
The LCDIF IP on i.MX6SL and i.MX6SLL is compatible with i.MX6SX.
Provide a more specific "fsl,imx6sx-lcdif" compatible and still keep
"fsl,imx28-lcdif" for DT compatibility.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
arch/arm/boot/dts/nxp/imx/imx6sl.dtsi | 3 ++-
arch/arm/boot/dts/nxp/imx/imx6sll.dtsi | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi
index 7381fb7f8912..074c48b04519 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi
@@ -776,7 +776,8 @@ epdc: epdc@20f4000 {
};
lcdif: lcdif@20f8000 {
- compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif";
+ compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif",
+ "fsl,imx28-lcdif";
reg = <0x020f8000 0x4000>;
interrupts = <0 39 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6SL_CLK_LCDIF_PIX>,
diff --git a/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
index 8c5ca4f9b87f..745f3640e114 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
@@ -657,7 +657,8 @@ pxp: pxp@20f0000 {
};
lcdif: lcd-controller@20f8000 {
- compatible = "fsl,imx6sll-lcdif", "fsl,imx28-lcdif";
+ compatible = "fsl,imx6sll-lcdif", "fsl,imx6sx-lcdif",
+ "fsl,imx28-lcdif";
reg = <0x020f8000 0x4000>;
interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6SLL_CLK_LCDIF_PIX>,
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH RESEND v4 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks
2025-09-10 2:05 ` [PATCH RESEND v4 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks Fabio Estevam
@ 2025-09-10 15:55 ` Frank Li
2025-09-10 16:36 ` Fabio Estevam
0 siblings, 1 reply; 8+ messages in thread
From: Frank Li @ 2025-09-10 15:55 UTC (permalink / raw)
To: Fabio Estevam
Cc: shawnguo, robh, krzk+dt, conor+dt, dri-devel, devicetree,
linux-arm-kernel, imx, kernel, Ahmad Fatoum
On Tue, Sep 09, 2025 at 11:05:24PM -0300, Fabio Estevam wrote:
> mx6sl.dtsi and imx6sll.dtsi have the following lcdif entries:
>
> compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif";
>
> This causes dt-schema warnings as the current binding only
> allow 'fsl,imx6sx-lcdif' as fallback.
>
> ['fsl,imx6sl-lcdif', 'fsl,imx28-lcdif'] is too long
> ['fsl,imx6sll-lcdif', 'fsl,imx28-lcdif'] is too long
>
> The imx6sx-lcdif programming model has more advanced features, such
> as overlay plane and the CRC32 support than the imx28-lcdif IP.
>
> Expand the imx6sl/imx6sll lcdif fallbacks to accept a less specific
> fsl,imx28-lcdif fallback:
>
> compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif", "fsl,imx28-lcdif";
Anyway, you change dts. If you change dts as
compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif";
needn't update binding here.
Frank
>
> This helps keeping DT compatibility as well as using the more advanced
> lcdif features found on imx6sl and imx6sll.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> index ce31b873fb95..d665f3241e97 100644
> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> @@ -23,14 +23,18 @@ properties:
> - fsl,imx93-lcdif
> - items:
> - enum:
> - - fsl,imx6sl-lcdif
> - - fsl,imx6sll-lcdif
> - fsl,imx6ul-lcdif
> - fsl,imx7d-lcdif
> - fsl,imx8mm-lcdif
> - fsl,imx8mn-lcdif
> - fsl,imx8mq-lcdif
> - const: fsl,imx6sx-lcdif
> + - items:
> + - enum:
> + - fsl,imx6sl-lcdif
> + - fsl,imx6sll-lcdif
> + - const: fsl,imx6sx-lcdif
> + - const: fsl,imx28-lcdif
> - items:
> - enum:
> - fsl,imx6sx-lcdif
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH RESEND v4 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks
2025-09-10 15:55 ` Frank Li
@ 2025-09-10 16:36 ` Fabio Estevam
2025-09-10 16:39 ` Frank Li
0 siblings, 1 reply; 8+ messages in thread
From: Fabio Estevam @ 2025-09-10 16:36 UTC (permalink / raw)
To: Frank Li
Cc: shawnguo, robh, krzk+dt, conor+dt, dri-devel, devicetree,
linux-arm-kernel, imx, kernel, Ahmad Fatoum
On Wed, Sep 10, 2025 at 12:56 PM Frank Li <Frank.li@nxp.com> wrote:
> > compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif", "fsl,imx28-lcdif";
>
> Anyway, you change dts. If you change dts as
>
> compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif";
>
> needn't update binding here.
This was discussed in previous iterations.
The change you propose may cause regressions for other device tree
consumers, such as bootloaders, where the match may occur only aganst
"fsl,imx28-lcdif".
That's why "fsl,imx28-lcdif" fallback needs to stay.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH RESEND v4 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks
2025-09-10 16:36 ` Fabio Estevam
@ 2025-09-10 16:39 ` Frank Li
0 siblings, 0 replies; 8+ messages in thread
From: Frank Li @ 2025-09-10 16:39 UTC (permalink / raw)
To: Fabio Estevam
Cc: shawnguo, robh, krzk+dt, conor+dt, dri-devel, devicetree,
linux-arm-kernel, imx, kernel, Ahmad Fatoum
On Wed, Sep 10, 2025 at 01:36:32PM -0300, Fabio Estevam wrote:
> On Wed, Sep 10, 2025 at 12:56 PM Frank Li <Frank.li@nxp.com> wrote:
>
> > > compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif", "fsl,imx28-lcdif";
> >
> > Anyway, you change dts. If you change dts as
> >
> > compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif";
> >
> > needn't update binding here.
>
> This was discussed in previous iterations.
>
> The change you propose may cause regressions for other device tree
> consumers, such as bootloaders, where the match may occur only aganst
> "fsl,imx28-lcdif".
>
> That's why "fsl,imx28-lcdif" fallback needs to stay.
Okay
Reviewed-by: Frank Li <Frank.Li@nxp.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH RESEND v4 3/3] ARM: dts: imx6sl: Provide a more specific lcdif compatible
2025-09-10 2:05 ` [PATCH RESEND v4 3/3] ARM: dts: imx6sl: Provide a more specific lcdif compatible Fabio Estevam
@ 2025-09-10 16:39 ` Frank Li
0 siblings, 0 replies; 8+ messages in thread
From: Frank Li @ 2025-09-10 16:39 UTC (permalink / raw)
To: Fabio Estevam
Cc: shawnguo, robh, krzk+dt, conor+dt, dri-devel, devicetree,
linux-arm-kernel, imx, kernel, Ahmad Fatoum
On Tue, Sep 09, 2025 at 11:05:25PM -0300, Fabio Estevam wrote:
> The LCDIF IP on i.MX6SL and i.MX6SLL is compatible with i.MX6SX.
>
> Provide a more specific "fsl,imx6sx-lcdif" compatible and still keep
> "fsl,imx28-lcdif" for DT compatibility.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
> arch/arm/boot/dts/nxp/imx/imx6sl.dtsi | 3 ++-
> arch/arm/boot/dts/nxp/imx/imx6sll.dtsi | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi
> index 7381fb7f8912..074c48b04519 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi
> @@ -776,7 +776,8 @@ epdc: epdc@20f4000 {
> };
>
> lcdif: lcdif@20f8000 {
> - compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif";
> + compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif",
> + "fsl,imx28-lcdif";
> reg = <0x020f8000 0x4000>;
> interrupts = <0 39 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks IMX6SL_CLK_LCDIF_PIX>,
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
> index 8c5ca4f9b87f..745f3640e114 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
> @@ -657,7 +657,8 @@ pxp: pxp@20f0000 {
> };
>
> lcdif: lcd-controller@20f8000 {
> - compatible = "fsl,imx6sll-lcdif", "fsl,imx28-lcdif";
> + compatible = "fsl,imx6sll-lcdif", "fsl,imx6sx-lcdif",
> + "fsl,imx28-lcdif";
> reg = <0x020f8000 0x4000>;
> interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks IMX6SLL_CLK_LCDIF_PIX>,
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH RESEND v4 3/3] ARM: dts: imx6sl: Provide a more specific lcdif compatible
2025-10-13 20:51 [PATCH RESEND v4 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback Fabio Estevam
@ 2025-10-13 20:51 ` Fabio Estevam
0 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2025-10-13 20:51 UTC (permalink / raw)
To: victor.liu
Cc: marex, stefan, airlied, simona, maarten.lankhorst, mripard,
tzimmermann, robh, krzk+dt, conor+dt, dri-devel, devicetree,
shawnguo, imx, linux-arm-kernel, Fabio Estevam, Ahmad Fatoum
The LCDIF IP on i.MX6SL and i.MX6SLL is compatible with i.MX6SX.
Provide a more specific "fsl,imx6sx-lcdif" compatible and still keep
"fsl,imx28-lcdif" for DT compatibility.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Reviewed-by: Frank Li <Frank.Li@nxp.com
---
arch/arm/boot/dts/nxp/imx/imx6sl.dtsi | 3 ++-
arch/arm/boot/dts/nxp/imx/imx6sll.dtsi | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi
index 7381fb7f8912..074c48b04519 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi
@@ -776,7 +776,8 @@ epdc: epdc@20f4000 {
};
lcdif: lcdif@20f8000 {
- compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif";
+ compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif",
+ "fsl,imx28-lcdif";
reg = <0x020f8000 0x4000>;
interrupts = <0 39 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6SL_CLK_LCDIF_PIX>,
diff --git a/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
index 8c5ca4f9b87f..745f3640e114 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
@@ -657,7 +657,8 @@ pxp: pxp@20f0000 {
};
lcdif: lcd-controller@20f8000 {
- compatible = "fsl,imx6sll-lcdif", "fsl,imx28-lcdif";
+ compatible = "fsl,imx6sll-lcdif", "fsl,imx6sx-lcdif",
+ "fsl,imx28-lcdif";
reg = <0x020f8000 0x4000>;
interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6SLL_CLK_LCDIF_PIX>,
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-10-13 20:52 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-10 2:05 [PATCH RESEND v4 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback Fabio Estevam
2025-09-10 2:05 ` [PATCH RESEND v4 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks Fabio Estevam
2025-09-10 15:55 ` Frank Li
2025-09-10 16:36 ` Fabio Estevam
2025-09-10 16:39 ` Frank Li
2025-09-10 2:05 ` [PATCH RESEND v4 3/3] ARM: dts: imx6sl: Provide a more specific lcdif compatible Fabio Estevam
2025-09-10 16:39 ` Frank Li
-- strict thread matches above, loose matches on Subject: below --
2025-10-13 20:51 [PATCH RESEND v4 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback Fabio Estevam
2025-10-13 20:51 ` [PATCH RESEND v4 3/3] ARM: dts: imx6sl: Provide a more specific lcdif compatible Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).