From: Lee Jones <lee@kernel.org>
To: Srinivas Kandagatla <srini@kernel.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] nvmem: add driver for the eeprom in qnap-mcu controllers
Date: Thu, 11 Sep 2025 09:41:19 +0100 [thread overview]
Message-ID: <20250911084119.GF9224@google.com> (raw)
In-Reply-To: <8721df1d-d8db-4b05-b450-107d936d8715@kernel.org>
On Tue, 09 Sep 2025, Srinivas Kandagatla wrote:
>
>
> On 7/30/25 6:22 PM, Heiko Stuebner wrote:
> > The qnap-mcu also has an eeprom connected to it, that contains some
> > specific product-information like the mac addresses for the network
> > interfaces.
> >
> > Add a nvmem driver for it.
> >
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > ---
> > drivers/mfd/qnap-mcu.c | 1 +
> > drivers/nvmem/Kconfig | 9 +++
> > drivers/nvmem/Makefile | 2 +
> > drivers/nvmem/qnap-mcu-eeprom.c | 110 ++++++++++++++++++++++++++++++++
> > 4 files changed, 122 insertions(+)
> > create mode 100644 drivers/nvmem/qnap-mcu-eeprom.c
> >
> In case Lee you want to take this via MFD,
>
> Acked-by: Srinivas Kandagatla <srini@kernel.org>
Actually this patch should be split up.
I'll take the MFD part, you can take the NVMEM part.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-09-11 8:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 17:22 [PATCH 0/2] qnap-mcu: add nvmem subdevice to read the eeprom Heiko Stuebner
2025-07-30 17:22 ` [PATCH 1/2] dt-bindings: mfd: qnap,ts433-mcu: allow nvmem-layout child node Heiko Stuebner
2025-07-31 0:18 ` Rob Herring (Arm)
2025-07-31 13:47 ` (subset) " Lee Jones
2025-07-31 13:48 ` Lee Jones
2025-07-30 17:22 ` [PATCH 2/2] nvmem: add driver for the eeprom in qnap-mcu controllers Heiko Stuebner
2025-09-09 5:51 ` Srinivas Kandagatla
2025-09-11 8:41 ` Lee Jones [this message]
2025-09-11 8:48 ` Heiko Stübner
2025-09-11 14:44 ` Lee Jones
2025-08-18 6:41 ` (subset) [PATCH 0/2] qnap-mcu: add nvmem subdevice to read the eeprom Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250911084119.GF9224@google.com \
--to=lee@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).