From: David Heidelberg via B4 Relay <devnull+david.ixit.cz@kernel.org>
To: Sumit Semwal <sumit.semwal@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jessica.zhang@oss.qualcomm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Molly Sophia <mollysophia379@gmail.com>,
Arnaud Ferraris <arnaud.ferraris@collabora.com>,
David Heidelberg <david@ixit.cz>
Subject: [PATCH v6 1/3] drm: panel: nt36672a: Make some command sequences optional
Date: Sat, 13 Sep 2025 21:19:47 +0200 [thread overview]
Message-ID: <20250913-nt35596s-v6-1-b5deb05e04af@ixit.cz> (raw)
In-Reply-To: <20250913-nt35596s-v6-0-b5deb05e04af@ixit.cz>
From: Molly Sophia <mollysophia379@gmail.com>
Preparation for the follow-up nt35596s support, where not all sequences
are provided.
Signed-off-by: Molly Sophia <mollysophia379@gmail.com>
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
drivers/gpu/drm/panel/panel-novatek-nt36672a.c | 27 ++++++++++++++------------
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c
index 29e1f6aea48060384f4639999174b67097a6c8a7..f7518ec469176a4e2d4f2b03f8e77f03511a12a7 100644
--- a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c
+++ b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c
@@ -117,12 +117,13 @@ static int nt36672a_panel_unprepare(struct drm_panel *panel)
struct nt36672a_panel *pinfo = to_nt36672a_panel(panel);
int ret;
- /* send off cmds */
- ret = nt36672a_send_cmds(panel, pinfo->desc->off_cmds,
- pinfo->desc->num_off_cmds);
-
- if (ret < 0)
- dev_err(panel->dev, "failed to send DCS off cmds: %d\n", ret);
+ if (pinfo->desc->num_off_cmds != 0) {
+ /* send off cmds if present */
+ ret = nt36672a_send_cmds(panel, pinfo->desc->off_cmds,
+ pinfo->desc->num_off_cmds);
+ if (ret < 0)
+ dev_err(panel->dev, "failed to send DCS off cmds: %d\n", ret);
+ }
ret = mipi_dsi_dcs_set_display_off(pinfo->link);
if (ret < 0)
@@ -200,13 +201,15 @@ static int nt36672a_panel_prepare(struct drm_panel *panel)
goto poweroff;
}
- /* Send rest of the init cmds */
- err = nt36672a_send_cmds(panel, pinfo->desc->on_cmds_2,
- pinfo->desc->num_on_cmds_2);
+ if (pinfo->desc->num_on_cmds_2 != 0) {
+ /* Send rest of the init cmds if present */
+ err = nt36672a_send_cmds(panel, pinfo->desc->on_cmds_2,
+ pinfo->desc->num_on_cmds_2);
- if (err < 0) {
- dev_err(panel->dev, "failed to send DCS Init 2nd Code: %d\n", err);
- goto poweroff;
+ if (err < 0) {
+ dev_err(panel->dev, "failed to send DCS Init 2nd Code: %d\n", err);
+ goto poweroff;
+ }
}
msleep(120);
--
2.51.0
next prev parent reply other threads:[~2025-09-13 19:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-13 19:19 [PATCH v6 0/3] Add driver for Novatek NT35596S panel David Heidelberg via B4 Relay
2025-09-13 19:19 ` David Heidelberg via B4 Relay [this message]
2025-09-15 1:22 ` [PATCH v6 1/3] drm: panel: nt36672a: Make some command sequences optional Dmitry Baryshkov
2025-09-13 19:19 ` [PATCH v6 2/3] drm: panel: nt36672a: Add support for novatek nt35596s panel David Heidelberg via B4 Relay
2025-09-15 1:29 ` Dmitry Baryshkov
2025-09-15 10:11 ` David Heidelberg
2025-09-15 11:11 ` Dmitry Baryshkov
2025-09-15 15:06 ` David Heidelberg
2025-09-15 18:22 ` Dmitry Baryshkov
2025-09-13 19:19 ` [PATCH v6 3/3] dt-bindings: display: panel: Add Novatek NT35596S panel bindings David Heidelberg via B4 Relay
2026-09-11 8:55 ` [PATCH v6 0/3] Add driver for Novatek NT35596S panel Konrad Dybcio
2026-09-11 20:10 ` David Heidelberg
2026-09-13 9:54 ` Alexey Minnekhanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250913-nt35596s-v6-1-b5deb05e04af@ixit.cz \
--to=devnull+david.ixit.cz@kernel.org \
--cc=airlied@gmail.com \
--cc=arnaud.ferraris@collabora.com \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mollysophia379@gmail.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=sumit.semwal@linaro.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox