From: Rob Herring <robh@kernel.org>
To: Charan Pedumuru <charan.pedumuru@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Barker <paul.barker@sancloud.com>,
Marc Murphy <marc.murphy@sancloud.com>,
Tony Lindgren <tony@atomide.com>,
Kishon Vijay Abraham I <kishon@kernel.org>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 1/2] arm: dts: ti: omap: Drop unnecessary or unused properties
Date: Sun, 14 Sep 2025 17:23:48 -0500 [thread overview]
Message-ID: <20250914222348.GA2080538-robh@kernel.org> (raw)
In-Reply-To: <501a4e0a-2d6e-4a57-9006-91413bd2ebb4@gmail.com>
On Sun, Sep 14, 2025 at 12:19:15AM +0530, Charan Pedumuru wrote:
>
>
> On 09-09-2025 12:50, Krzysztof Kozlowski wrote:
> > On Mon, Sep 08, 2025 at 04:17:12PM +0000, Charan Pedumuru wrote:
> >> Remove unnecessary properties like ti,needs-special-reset,
> >> ti,needs-special-hs-handling and cap-mmc-dual-data-rate from the DTS
> >> files as there is no user of them.
> >
> > No user? That's not true:
> >
> > git grep ti,needs-special-reset
>
> Should I remove ti,needs-special-reset property for the compatibles
> "ti,am335-sdhci" and "ti,am437-sdhci" instead of removing for all mmc
> nodes? ti,needs-special-hs-handling and cap-mmc-dual-data-rate were
> defined for board specific, so these two properties should be defined
> in the YAML file to resolve dtb_check errors or can I remove those
> properties for those boards too?
If those 2 compatibles don't use the omap_hsmmc driver then, yes I think
you can remove the properties from those nodes. Otherwise, shrug. Ask
the TI folks if you can't figure it out.
Rob
next prev parent reply other threads:[~2025-09-14 22:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 16:17 [PATCH v2 0/2] dt-bindings: mmc: ti,omap2430-sdhci: Add json schema for the text binding Charan Pedumuru
2025-09-08 16:17 ` [PATCH v2 1/2] arm: dts: ti: omap: Drop unnecessary or unused properties Charan Pedumuru
2025-09-08 17:43 ` Andreas Kemnade
2025-09-09 7:20 ` Krzysztof Kozlowski
2025-09-13 15:10 ` Charan Pedumuru
2025-09-13 18:49 ` Charan Pedumuru
2025-09-14 22:23 ` Rob Herring [this message]
2025-09-20 6:21 ` Charan Pedumuru
2025-09-08 16:17 ` [PATCH v2 2/2] dt-bindings: mmc: sdhci-omap: convert to DT schema Charan Pedumuru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250914222348.GA2080538-robh@kernel.org \
--to=robh@kernel.org \
--cc=charan.pedumuru@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=marc.murphy@sancloud.com \
--cc=paul.barker@sancloud.com \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).