Re: [PATCH 1/4] dt-bindings: usb: uhci: Add reset property

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]

On Mon, Sep 15, 2025 at 03:39:23PM +0800, Ryan Chen wrote:
> The UHCI controller on Aspeed SoCs (including AST2700) requires
> its reset line to be deasserted before the controller can be used.
> Add an optional "resets" property to the UHCI device tree bindings
> to describe the phandle to the reset controller.

Looks like the property is not optional at all for your aspeed devices,
and you should require it for those compatibles.

> 
> This property is optional for platforms which do not require
> explicit reset handling.
> 
> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
> ---
>  Documentation/devicetree/bindings/usb/usb-uhci.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/usb-uhci.yaml b/Documentation/devicetree/bindings/usb/usb-uhci.yaml
> index d8336f72dc1f..b1f2b9bd7921 100644
> --- a/Documentation/devicetree/bindings/usb/usb-uhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/usb-uhci.yaml
> @@ -28,6 +28,9 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  resets:
> +    maxItems: 1
> +
>    '#ports':
>      $ref: /schemas/types.yaml#/definitions/uint32
>  
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]