* [PATCH] arm64: dts: rockchip: Enable DisplayPort for rk3588-evb2 @ 2025-09-16 8:08 Chaoyi Chen 2025-09-16 8:41 ` Quentin Schulz 2025-09-17 15:00 ` Rob Herring (Arm) 0 siblings, 2 replies; 7+ messages in thread From: Chaoyi Chen @ 2025-09-16 8:08 UTC (permalink / raw) To: Heiko Stuebner, Andy Yan Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Quentin Schulz, Dragan Simic, FUKAUMI Naoki, Jonas Karlman, Peter Robinson, Chaoyi Chen, Geert Uytterhoeven, Cristian Ciocaltea, Sebastian Reichel, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel From: Chaoyi Chen <chaoyi.chen@rock-chips.com> The rk3588 evb2 board has a full size DisplayPort connector, enable for it. Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com> --- .../boot/dts/rockchip/rk3588-evb2-v10.dts | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb2-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588-evb2-v10.dts index 91fe810d38d8..0e5af61f66fe 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-evb2-v10.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588-evb2-v10.dts @@ -25,6 +25,18 @@ chosen { stdout-path = "serial2:1500000n8"; }; + dp-con { + compatible = "dp-connector"; + label = "DP OUT"; + type = "full size"; + + port { + dp_con_in: endpoint { + remote-endpoint = <&dp0_out_con>; + }; + }; + }; + hdmi-con { compatible = "hdmi-connector"; type = "a"; @@ -106,6 +118,24 @@ vcc5v0_usbdcin: regulator-vcc5v0-usbdcin { }; }; +&dp0 { + pinctrl-0 = <&dp0m0_pins>; + pinctrl-names = "default"; + status = "okay"; +}; + +&dp0_in { + dp0_in_vp2: endpoint { + remote-endpoint = <&vp2_out_dp0>; + }; +}; + +&dp0_out { + dp0_out_con: endpoint { + remote-endpoint = <&dp_con_in>; + }; +}; + &gpu { mali-supply = <&vdd_gpu_s0>; sram-supply = <&vdd_gpu_mem_s0>; @@ -916,6 +946,8 @@ &usb_host1_xhci { }; &vop { + assigned-clocks = <&cru DCLK_VOP2_SRC>; + assigned-clock-parents = <&cru PLL_V0PLL>; status = "okay"; }; @@ -929,3 +961,10 @@ vp0_out_hdmi0: endpoint@ROCKCHIP_VOP2_EP_HDMI0 { remote-endpoint = <&hdmi0_in_vp0>; }; }; + +&vp2 { + vp2_out_dp0: endpoint@a { + reg = <ROCKCHIP_VOP2_EP_DP0>; + remote-endpoint = <&dp0_in_vp2>; + }; +}; -- 2.49.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Enable DisplayPort for rk3588-evb2 2025-09-16 8:08 [PATCH] arm64: dts: rockchip: Enable DisplayPort for rk3588-evb2 Chaoyi Chen @ 2025-09-16 8:41 ` Quentin Schulz 2025-09-16 9:18 ` Chaoyi Chen 2025-09-17 15:00 ` Rob Herring (Arm) 1 sibling, 1 reply; 7+ messages in thread From: Quentin Schulz @ 2025-09-16 8:41 UTC (permalink / raw) To: Chaoyi Chen, Heiko Stuebner, Andy Yan Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Dragan Simic, FUKAUMI Naoki, Jonas Karlman, Peter Robinson, Chaoyi Chen, Geert Uytterhoeven, Cristian Ciocaltea, Sebastian Reichel, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel Hi Chaoyi Chen, On 9/16/25 10:08 AM, Chaoyi Chen wrote: > From: Chaoyi Chen <chaoyi.chen@rock-chips.com> > > The rk3588 evb2 board has a full size DisplayPort connector, enable > for it. > > Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com> > --- > .../boot/dts/rockchip/rk3588-evb2-v10.dts | 39 +++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb2-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588-evb2-v10.dts > index 91fe810d38d8..0e5af61f66fe 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-evb2-v10.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588-evb2-v10.dts > @@ -25,6 +25,18 @@ chosen { > stdout-path = "serial2:1500000n8"; > }; > > + dp-con { > + compatible = "dp-connector"; > + label = "DP OUT"; > + type = "full size"; This isn't valid according to the dt binding. It should be "full-size" instead. > + > + port { > + dp_con_in: endpoint { > + remote-endpoint = <&dp0_out_con>; > + }; > + }; > + }; > + > hdmi-con { > compatible = "hdmi-connector"; > type = "a"; > @@ -106,6 +118,24 @@ vcc5v0_usbdcin: regulator-vcc5v0-usbdcin { > }; > }; > > +&dp0 { > + pinctrl-0 = <&dp0m0_pins>; > + pinctrl-names = "default"; > + status = "okay"; > +}; > + > +&dp0_in { > + dp0_in_vp2: endpoint { > + remote-endpoint = <&vp2_out_dp0>; > + }; > +}; > + > +&dp0_out { > + dp0_out_con: endpoint { > + remote-endpoint = <&dp_con_in>; > + }; > +}; > + > &gpu { > mali-supply = <&vdd_gpu_s0>; > sram-supply = <&vdd_gpu_mem_s0>; > @@ -916,6 +946,8 @@ &usb_host1_xhci { > }; > > &vop { > + assigned-clocks = <&cru DCLK_VOP2_SRC>; > + assigned-clock-parents = <&cru PLL_V0PLL>; This is surprising, the only other board which has the DP0 enabled (the CoolPi 4B) doesn't set these two. Does HDMI still work as well as it used to with these new properties? Why are those needed? Some context in the commit log or as a comment in the DT would be most welcome! Cheers, Quentin ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Enable DisplayPort for rk3588-evb2 2025-09-16 8:41 ` Quentin Schulz @ 2025-09-16 9:18 ` Chaoyi Chen 2025-09-16 9:24 ` Quentin Schulz 0 siblings, 1 reply; 7+ messages in thread From: Chaoyi Chen @ 2025-09-16 9:18 UTC (permalink / raw) To: Quentin Schulz, Chaoyi Chen, Heiko Stuebner, Andy Yan Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Dragan Simic, FUKAUMI Naoki, Jonas Karlman, Peter Robinson, Geert Uytterhoeven, Cristian Ciocaltea, Sebastian Reichel, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel Hi Quentin, On 9/16/2025 4:41 PM, Quentin Schulz wrote: > Hi Chaoyi Chen, > > On 9/16/25 10:08 AM, Chaoyi Chen wrote: >> From: Chaoyi Chen <chaoyi.chen@rock-chips.com> >> >> The rk3588 evb2 board has a full size DisplayPort connector, enable >> for it. >> >> Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com> >> --- >> .../boot/dts/rockchip/rk3588-evb2-v10.dts | 39 +++++++++++++++++++ >> 1 file changed, 39 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb2-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588-evb2-v10.dts >> index 91fe810d38d8..0e5af61f66fe 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3588-evb2-v10.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3588-evb2-v10.dts >> @@ -25,6 +25,18 @@ chosen { >> stdout-path = "serial2:1500000n8"; >> }; >> + dp-con { >> + compatible = "dp-connector"; >> + label = "DP OUT"; >> + type = "full size"; > > This isn't valid according to the dt binding. It should be "full-size" instead. Will fix in v2. > >> + >> + port { >> + dp_con_in: endpoint { >> + remote-endpoint = <&dp0_out_con>; >> + }; >> + }; >> + }; >> + >> hdmi-con { >> compatible = "hdmi-connector"; >> type = "a"; >> @@ -106,6 +118,24 @@ vcc5v0_usbdcin: regulator-vcc5v0-usbdcin { >> }; >> }; >> +&dp0 { >> + pinctrl-0 = <&dp0m0_pins>; >> + pinctrl-names = "default"; >> + status = "okay"; >> +}; >> + >> +&dp0_in { >> + dp0_in_vp2: endpoint { >> + remote-endpoint = <&vp2_out_dp0>; >> + }; >> +}; >> + >> +&dp0_out { >> + dp0_out_con: endpoint { >> + remote-endpoint = <&dp_con_in>; >> + }; >> +}; >> + >> &gpu { >> mali-supply = <&vdd_gpu_s0>; >> sram-supply = <&vdd_gpu_mem_s0>; >> @@ -916,6 +946,8 @@ &usb_host1_xhci { >> }; >> &vop { >> + assigned-clocks = <&cru DCLK_VOP2_SRC>; >> + assigned-clock-parents = <&cru PLL_V0PLL>; > > This is surprising, the only other board which has the DP0 enabled (the CoolPi 4B) doesn't set these two. > > Does HDMI still work as well as it used to with these new properties? Why are those needed? Some context in the commit log or as a comment in the DT would be most welcome! Yes, HDMI and DP can work normally whether these new properties removed or not. The key point is that when using V0PLL, we can get more usable resolution because DP requires a precise clock. If V0PLL is not explicitly specified here, then dclk_vop2 (VP2) may be divided down on GPLL, CPLL, etc. In this case, only a few frequency points are available. In my case, when V0PLL is not used, only resolutions such as 1024x768 and 640x480 are available. For HDMI, I think it will use clk_hdmiphy_pixel0/1 as clock parent which is provided by the HDMI PHY when it work on TMDS mode so that we don't need to set it . I will add more comment in v2. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Enable DisplayPort for rk3588-evb2 2025-09-16 9:18 ` Chaoyi Chen @ 2025-09-16 9:24 ` Quentin Schulz 2025-09-16 9:48 ` Chaoyi Chen 0 siblings, 1 reply; 7+ messages in thread From: Quentin Schulz @ 2025-09-16 9:24 UTC (permalink / raw) To: Chaoyi Chen, Chaoyi Chen, Heiko Stuebner, Andy Yan Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Dragan Simic, FUKAUMI Naoki, Jonas Karlman, Peter Robinson, Geert Uytterhoeven, Cristian Ciocaltea, Sebastian Reichel, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel On 9/16/25 11:18 AM, Chaoyi Chen wrote: > Hi Quentin, > > On 9/16/2025 4:41 PM, Quentin Schulz wrote: >> Hi Chaoyi Chen, >> >> On 9/16/25 10:08 AM, Chaoyi Chen wrote: >>> From: Chaoyi Chen <chaoyi.chen@rock-chips.com> >>> >>> The rk3588 evb2 board has a full size DisplayPort connector, enable >>> for it. >>> >>> Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com> >>> --- >>> .../boot/dts/rockchip/rk3588-evb2-v10.dts | 39 +++++++++++++++++++ >>> 1 file changed, 39 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb2-v10.dts b/arch/ >>> arm64/boot/dts/rockchip/rk3588-evb2-v10.dts >>> index 91fe810d38d8..0e5af61f66fe 100644 >>> --- a/arch/arm64/boot/dts/rockchip/rk3588-evb2-v10.dts >>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-evb2-v10.dts >>> @@ -25,6 +25,18 @@ chosen { >>> stdout-path = "serial2:1500000n8"; >>> }; >>> + dp-con { >>> + compatible = "dp-connector"; >>> + label = "DP OUT"; >>> + type = "full size"; >> >> This isn't valid according to the dt binding. It should be "full-size" >> instead. > > Will fix in v2. > > >> >>> + >>> + port { >>> + dp_con_in: endpoint { >>> + remote-endpoint = <&dp0_out_con>; >>> + }; >>> + }; >>> + }; >>> + >>> hdmi-con { >>> compatible = "hdmi-connector"; >>> type = "a"; >>> @@ -106,6 +118,24 @@ vcc5v0_usbdcin: regulator-vcc5v0-usbdcin { >>> }; >>> }; >>> +&dp0 { >>> + pinctrl-0 = <&dp0m0_pins>; >>> + pinctrl-names = "default"; >>> + status = "okay"; >>> +}; >>> + >>> +&dp0_in { >>> + dp0_in_vp2: endpoint { >>> + remote-endpoint = <&vp2_out_dp0>; >>> + }; >>> +}; >>> + >>> +&dp0_out { >>> + dp0_out_con: endpoint { >>> + remote-endpoint = <&dp_con_in>; >>> + }; >>> +}; >>> + >>> &gpu { >>> mali-supply = <&vdd_gpu_s0>; >>> sram-supply = <&vdd_gpu_mem_s0>; >>> @@ -916,6 +946,8 @@ &usb_host1_xhci { >>> }; >>> &vop { >>> + assigned-clocks = <&cru DCLK_VOP2_SRC>; >>> + assigned-clock-parents = <&cru PLL_V0PLL>; >> >> This is surprising, the only other board which has the DP0 enabled >> (the CoolPi 4B) doesn't set these two. >> >> Does HDMI still work as well as it used to with these new properties? >> Why are those needed? Some context in the commit log or as a comment >> in the DT would be most welcome! > > Yes, HDMI and DP can work normally whether these new properties removed > or not. > > The key point is that when using V0PLL, we can get more usable > resolution because DP requires a precise clock. If V0PLL is not > explicitly specified here, then dclk_vop2 (VP2) may be divided down on > GPLL, CPLL, etc. In this case, only a few frequency points are > available. In my case, when V0PLL is not used, only resolutions such as > 1024x768 and 640x480 are available. > > For HDMI, I think it will use clk_hdmiphy_pixel0/1 as clock parent which > is provided by the HDMI PHY when it work on TMDS mode so that we don't > need to set it . > Considering the clocks are all internal to the SoC, shouldn't all you have explained be applicable to the CoolPi 4B too (and other boards with DP)? I'm trying to understand if we should add something similar to CoolPi 4B DTS as well? @Andy, you're the one who added support for DP to CoolPi 4B, without these properties, is there something we need to do there as well? Thanks! Quentin ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Enable DisplayPort for rk3588-evb2 2025-09-16 9:24 ` Quentin Schulz @ 2025-09-16 9:48 ` Chaoyi Chen 2025-09-16 10:13 ` Andy Yan 0 siblings, 1 reply; 7+ messages in thread From: Chaoyi Chen @ 2025-09-16 9:48 UTC (permalink / raw) To: Quentin Schulz, Chaoyi Chen, Heiko Stuebner, Andy Yan Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Dragan Simic, FUKAUMI Naoki, Jonas Karlman, Peter Robinson, Geert Uytterhoeven, Cristian Ciocaltea, Sebastian Reichel, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel On 9/16/2025 5:24 PM, Quentin Schulz wrote: > On 9/16/25 11:18 AM, Chaoyi Chen wrote: >> Hi Quentin, >> >> On 9/16/2025 4:41 PM, Quentin Schulz wrote: >>> Hi Chaoyi Chen, >>> >>> On 9/16/25 10:08 AM, Chaoyi Chen wrote: >>>> From: Chaoyi Chen <chaoyi.chen@rock-chips.com> >>>> >>>> The rk3588 evb2 board has a full size DisplayPort connector, enable >>>> for it. >>>> >>>> Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com> >>>> --- >>>> .../boot/dts/rockchip/rk3588-evb2-v10.dts | 39 +++++++++++++++++++ >>>> 1 file changed, 39 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb2-v10.dts b/arch/ arm64/boot/dts/rockchip/rk3588-evb2-v10.dts >>>> index 91fe810d38d8..0e5af61f66fe 100644 >>>> --- a/arch/arm64/boot/dts/rockchip/rk3588-evb2-v10.dts >>>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-evb2-v10.dts >>>> @@ -25,6 +25,18 @@ chosen { >>>> stdout-path = "serial2:1500000n8"; >>>> }; >>>> + dp-con { >>>> + compatible = "dp-connector"; >>>> + label = "DP OUT"; >>>> + type = "full size"; >>> >>> This isn't valid according to the dt binding. It should be "full-size" instead. >> >> Will fix in v2. >> >> >>> >>>> + >>>> + port { >>>> + dp_con_in: endpoint { >>>> + remote-endpoint = <&dp0_out_con>; >>>> + }; >>>> + }; >>>> + }; >>>> + >>>> hdmi-con { >>>> compatible = "hdmi-connector"; >>>> type = "a"; >>>> @@ -106,6 +118,24 @@ vcc5v0_usbdcin: regulator-vcc5v0-usbdcin { >>>> }; >>>> }; >>>> +&dp0 { >>>> + pinctrl-0 = <&dp0m0_pins>; >>>> + pinctrl-names = "default"; >>>> + status = "okay"; >>>> +}; >>>> + >>>> +&dp0_in { >>>> + dp0_in_vp2: endpoint { >>>> + remote-endpoint = <&vp2_out_dp0>; >>>> + }; >>>> +}; >>>> + >>>> +&dp0_out { >>>> + dp0_out_con: endpoint { >>>> + remote-endpoint = <&dp_con_in>; >>>> + }; >>>> +}; >>>> + >>>> &gpu { >>>> mali-supply = <&vdd_gpu_s0>; >>>> sram-supply = <&vdd_gpu_mem_s0>; >>>> @@ -916,6 +946,8 @@ &usb_host1_xhci { >>>> }; >>>> &vop { >>>> + assigned-clocks = <&cru DCLK_VOP2_SRC>; >>>> + assigned-clock-parents = <&cru PLL_V0PLL>; >>> >>> This is surprising, the only other board which has the DP0 enabled (the CoolPi 4B) doesn't set these two. >>> >>> Does HDMI still work as well as it used to with these new properties? Why are those needed? Some context in the commit log or as a comment in the DT would be most welcome! >> >> Yes, HDMI and DP can work normally whether these new properties removed or not. >> >> The key point is that when using V0PLL, we can get more usable resolution because DP requires a precise clock. If V0PLL is not explicitly specified here, then dclk_vop2 (VP2) may be divided down on GPLL, CPLL, etc. In this case, only a few frequency points are available. In my case, when V0PLL is not used, only resolutions such as 1024x768 and 640x480 are available. Oh! This is because GPLL was not initialized to the correct frequency during the U-Boot stage. It should support typical frequencies such as 1080P (148.5M), 4K (594M) . >> >> For HDMI, I think it will use clk_hdmiphy_pixel0/1 as clock parent which is provided by the HDMI PHY when it work on TMDS mode so that we don't need to set it . >> > > Considering the clocks are all internal to the SoC, shouldn't all you have explained be applicable to the CoolPi 4B too (and other boards with DP)? I'm trying to understand if we should add something similar to CoolPi 4B DTS as well? Yes, I think this modification is necessary because some resolutions use special frequencies. > > @Andy, you're the one who added support for DP to CoolPi 4B, without these properties, is there something we need to do there as well? > > Thanks! > Quentin > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re:Re: [PATCH] arm64: dts: rockchip: Enable DisplayPort for rk3588-evb2 2025-09-16 9:48 ` Chaoyi Chen @ 2025-09-16 10:13 ` Andy Yan 0 siblings, 0 replies; 7+ messages in thread From: Andy Yan @ 2025-09-16 10:13 UTC (permalink / raw) To: Quentin Schulz Cc: Quentin Schulz, Chaoyi Chen, Heiko Stuebner, Andy Yan, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Dragan Simic, FUKAUMI Naoki, Jonas Karlman, Peter Robinson, chaoyi.chen@rock-chips.com, Geert Uytterhoeven, Cristian Ciocaltea, Sebastian Reichel, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel Hello Quentin， 在 2025-09-16 17:48:41，"Chaoyi Chen" <chaoyi.chen@rock-chips.com> 写道： >On 9/16/2025 5:24 PM, Quentin Schulz wrote: > >> On 9/16/25 11:18 AM, Chaoyi Chen wrote: >>> Hi Quentin, >>> >>> On 9/16/2025 4:41 PM, Quentin Schulz wrote: >>>> Hi Chaoyi Chen, >>>> >>>> On 9/16/25 10:08 AM, Chaoyi Chen wrote: >>>>> From: Chaoyi Chen <chaoyi.chen@rock-chips.com> >>>>> >>>>> The rk3588 evb2 board has a full size DisplayPort connector, enable >>>>> for it. >>>>> >>>>> Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com> >>>>> --- >>>>> .../boot/dts/rockchip/rk3588-evb2-v10.dts | 39 +++++++++++++++++++ >>>>> 1 file changed, 39 insertions(+) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb2-v10.dts b/arch/ arm64/boot/dts/rockchip/rk3588-evb2-v10.dts >>>>> index 91fe810d38d8..0e5af61f66fe 100644 >>>>> --- a/arch/arm64/boot/dts/rockchip/rk3588-evb2-v10.dts >>>>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-evb2-v10.dts >>>>> @@ -25,6 +25,18 @@ chosen { >>>>> stdout-path = "serial2:1500000n8"; >>>>> }; >>>>> + dp-con { >>>>> + compatible = "dp-connector"; >>>>> + label = "DP OUT"; >>>>> + type = "full size"; >>>> >>>> This isn't valid according to the dt binding. It should be "full-size" instead. >>> >>> Will fix in v2. >>> >>> >>>> >>>>> + >>>>> + port { >>>>> + dp_con_in: endpoint { >>>>> + remote-endpoint = <&dp0_out_con>; >>>>> + }; >>>>> + }; >>>>> + }; >>>>> + >>>>> hdmi-con { >>>>> compatible = "hdmi-connector"; >>>>> type = "a"; >>>>> @@ -106,6 +118,24 @@ vcc5v0_usbdcin: regulator-vcc5v0-usbdcin { >>>>> }; >>>>> }; >>>>> +&dp0 { >>>>> + pinctrl-0 = <&dp0m0_pins>; >>>>> + pinctrl-names = "default"; >>>>> + status = "okay"; >>>>> +}; >>>>> + >>>>> +&dp0_in { >>>>> + dp0_in_vp2: endpoint { >>>>> + remote-endpoint = <&vp2_out_dp0>; >>>>> + }; >>>>> +}; >>>>> + >>>>> +&dp0_out { >>>>> + dp0_out_con: endpoint { >>>>> + remote-endpoint = <&dp_con_in>; >>>>> + }; >>>>> +}; >>>>> + >>>>> &gpu { >>>>> mali-supply = <&vdd_gpu_s0>; >>>>> sram-supply = <&vdd_gpu_mem_s0>; >>>>> @@ -916,6 +946,8 @@ &usb_host1_xhci { >>>>> }; >>>>> &vop { >>>>> + assigned-clocks = <&cru DCLK_VOP2_SRC>; >>>>> + assigned-clock-parents = <&cru PLL_V0PLL>; >>>> >>>> This is surprising, the only other board which has the DP0 enabled (the CoolPi 4B) doesn't set these two. >>>> >>>> Does HDMI still work as well as it used to with these new properties? Why are those needed? Some context in the commit log or as a comment in the DT would be most welcome! >>> >>> Yes, HDMI and DP can work normally whether these new properties removed or not. >>> >>> The key point is that when using V0PLL, we can get more usable resolution because DP requires a precise clock. If V0PLL is not explicitly specified here, then dclk_vop2 (VP2) may be divided down on GPLL, CPLL, etc. In this case, only a few frequency points are available. In my case, when V0PLL is not used, only resolutions such as 1024x768 and 640x480 are available. > >Oh! This is because GPLL was not initialized to the correct frequency during the U-Boot stage. It should support typical frequencies such as 1080P (148.5M), 4K (594M) . > > >>> >>> For HDMI, I think it will use clk_hdmiphy_pixel0/1 as clock parent which is provided by the HDMI PHY when it work on TMDS mode so that we don't need to set it . >>> >> >> Considering the clocks are all internal to the SoC, shouldn't all you have explained be applicable to the CoolPi 4B too (and other boards with DP)? I'm trying to understand if we should add something similar to CoolPi 4B DTS as well? > >Yes, I think this modification is necessary because some resolutions use special frequencies. > > >> >> @Andy, you're the one who added support for DP to CoolPi 4B, without these properties, is there something we need to do there as well? On the CoolPI 4B, since no dedicated PLL was specified, the GPLL would be automatically assigned as the PLL source for dclk_vop2. As the frequency of GPLL is 1188 MHz, we can only get typical clock frequencies such as 74.25, 148.5, 297, 594MHz, which correspond to typical resolutions of 720P, 1080P, 4K30/60. If there are some more special resolutions, such as a 3840x2160 59.94Hz DP resolution that requires a dclk clock of 593.407 MHz, then it cannot be supported. I will conduct more tests later and then submit a patch to specify V0PLL for CoolPi 4B's VP2. And Chaoyi's patch is correct. >> >> Thanks! >> Quentin >> >> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Enable DisplayPort for rk3588-evb2 2025-09-16 8:08 [PATCH] arm64: dts: rockchip: Enable DisplayPort for rk3588-evb2 Chaoyi Chen 2025-09-16 8:41 ` Quentin Schulz @ 2025-09-17 15:00 ` Rob Herring (Arm) 1 sibling, 0 replies; 7+ messages in thread From: Rob Herring (Arm) @ 2025-09-17 15:00 UTC (permalink / raw) To: Chaoyi Chen Cc: linux-kernel, Cristian Ciocaltea, Peter Robinson, linux-arm-kernel, Dragan Simic, Andy Yan, Conor Dooley, Geert Uytterhoeven, Sebastian Reichel, Chaoyi Chen, Jonas Karlman, Quentin Schulz, FUKAUMI Naoki, Krzysztof Kozlowski, Heiko Stuebner, devicetree, linux-rockchip On Tue, 16 Sep 2025 16:08:02 +0800, Chaoyi Chen wrote: > From: Chaoyi Chen <chaoyi.chen@rock-chips.com> > > The rk3588 evb2 board has a full size DisplayPort connector, enable > for it. > > Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com> > --- > .../boot/dts/rockchip/rk3588-evb2-v10.dts | 39 +++++++++++++++++++ > 1 file changed, 39 insertions(+) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade This patch series was applied (using b4) to base: Base: attempting to guess base-commit... Base: tags/next-20250915 (exact match) If this is not the correct base, please add 'base-commit' tag (or use b4 which does this automatically) New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250916080802.125-1-kernel@airkyi.com: arch/arm64/boot/dts/rockchip/rk3588-evb2-v10.dtb: dp-con (dp-connector): type:0: 'full size' is not one of ['full-size', 'mini'] from schema $id: http://devicetree.org/schemas/display/connector/dp-connector.yaml# ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-09-17 15:00 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-09-16 8:08 [PATCH] arm64: dts: rockchip: Enable DisplayPort for rk3588-evb2 Chaoyi Chen 2025-09-16 8:41 ` Quentin Schulz 2025-09-16 9:18 ` Chaoyi Chen 2025-09-16 9:24 ` Quentin Schulz 2025-09-16 9:48 ` Chaoyi Chen 2025-09-16 10:13 ` Andy Yan 2025-09-17 15:00 ` Rob Herring (Arm)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox