From: Lee Jones <lee@kernel.org>
To: Jonathan Brophy <professorjonny98@gmail.com>
Cc: Pavel Machek <pavel@kernel.org>,
Jonathan Brophy <professor_jonny@hotmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Radoslav Tsvetkov <rtsvetkov@gradotech.eu>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH 2/5] leds: rgb: Add Virtual Color LED Group driver to Make
Date: Tue, 16 Sep 2025 13:28:53 +0100 [thread overview]
Message-ID: <20250916122853.GC3585920@google.com> (raw)
In-Reply-To: <20250916110217.45894-2-professorjonny98@gmail.com>
On Tue, 16 Sep 2025, Jonathan Brophy wrote:
> From: Jonathan Brophy <professor_jonny@hotmail.com>
>
> This commit adds the Virtual Color driver to led/rgb Make and Kconfig.
>
> Co-developed-by: Radoslav Tsvetkov <rtsvetkov@gradotech.eu>
> Signed-off-by: Jonathan Brophy <professor_jonny@hotmail.com>
> ---
> drivers/leds/rgb/Kconfig | 17 +++++++++++++++++
> drivers/leds/rgb/Makefile | 1 +
This should be squashed into the patch that introduces the driver.
> 2 files changed, 18 insertions(+)
>
> diff --git a/drivers/leds/rgb/Kconfig b/drivers/leds/rgb/Kconfig
> index 222d943d8..70a80fd46 100644
> --- a/drivers/leds/rgb/Kconfig
> +++ b/drivers/leds/rgb/Kconfig
> @@ -75,4 +75,21 @@ config LEDS_MT6370_RGB
> This driver can also be built as a module. If so, the module
> will be called "leds-mt6370-rgb".
>
> +config LEDS_GROUP_VIRTUALCOLOR
> + tristate "Virtual LED Group Driver with Priority Control"
> + depends on OF || COMPILE_TEST
> + help
> + This option enables support for virtual LED groups that aggregate
> + multiple monochromatic LEDs with priority-based control. It allows
> + managing concurrent LED activation requests by ensuring only the
> + highest-priority LED state is active at any given time.
> +
> + Multiple LEDs can be grouped together and controlled as a single
> + virtual LED with priority levels and blinking support. This is
> + useful for systems that need to manage multiple LED indicators
> + with different priority levels.
> +
> + To compile this driver as a module, choose M here: the module
> + will be called leds-group-virtualcolor.
> +
> endif # LEDS_CLASS_MULTICOLOR
> diff --git a/drivers/leds/rgb/Makefile b/drivers/leds/rgb/Makefile
> index a501fd27f..693fd300b 100644
> --- a/drivers/leds/rgb/Makefile
> +++ b/drivers/leds/rgb/Makefile
> @@ -6,3 +6,4 @@ obj-$(CONFIG_LEDS_NCP5623) += leds-ncp5623.o
> obj-$(CONFIG_LEDS_PWM_MULTICOLOR) += leds-pwm-multicolor.o
> obj-$(CONFIG_LEDS_QCOM_LPG) += leds-qcom-lpg.o
> obj-$(CONFIG_LEDS_MT6370_RGB) += leds-mt6370-rgb.o
> +obj-$(CONFIG_LEDS_GROUP_VIRTUALCOLOR) += leds-group-virtualcolor.o
> --
> 2.43.0
>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-09-16 12:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 11:02 [PATCH 1/5] leds: Add Virtual Color LED Group driver Jonathan Brophy
2025-09-16 11:02 ` [PATCH 2/5] leds: rgb: Add Virtual Color LED Group driver to Make Jonathan Brophy
2025-09-16 12:28 ` Lee Jones [this message]
2025-09-17 3:37 ` kernel test robot
2025-09-17 5:04 ` kernel test robot
2025-09-16 11:02 ` [PATCH 3/5] dt-bindings: leds: Add YAML bindings for Virtual Color LED Group driver Jonathan Brophy
2025-09-16 13:25 ` Rob Herring (Arm)
2025-09-22 16:45 ` Rob Herring
2025-09-22 23:38 ` Jonathan Brophy
2025-09-16 11:02 ` [PATCH 4/5] ABI: sysfs-class-leds-virtualcolor: Document sysfs entries for Virtual Color LEDs Jonathan Brophy
2025-09-16 11:02 ` [PATCH 5/5] dt-bindings: led: add virtual LED bindings Jonathan Brophy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250916122853.GC3585920@google.com \
--to=lee@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=professor_jonny@hotmail.com \
--cc=professorjonny98@gmail.com \
--cc=robh@kernel.org \
--cc=rtsvetkov@gradotech.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).