From: Lee Jones <lee@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Hans de Goede <hansg@kernel.org>,
Aleksandrs Vinarskis <alex@vinarskis.com>,
Pavel Machek <pavel@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
Jacopo Mondi <jacopo@jmondi.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Konrad Dybcio <konradybcio@kernel.org>,
Daniel Thompson <danielt@kernel.org>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
threeway@gmail.com, Andy Shevchenko <andy.shevchenko@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v5 3/4] leds: led-class: Add devicetree support to led_get()
Date: Tue, 16 Sep 2025 17:07:07 +0100 [thread overview]
Message-ID: <20250916160707.GA3893363@google.com> (raw)
In-Reply-To: <g7xkdervsknmcwjg4qgloj643b4itjlfeyiipvsrborszgrhlg@zrp65nvfueqk>
On Tue, 16 Sep 2025, Bjorn Andersson wrote:
> On Thu, Sep 11, 2025 at 11:01:00AM +0200, Hans de Goede wrote:
> > Hi Lee,
> >
> > On 11-Sep-25 10:15 AM, Lee Jones wrote:
> > > On Wed, 10 Sep 2025, Aleksandrs Vinarskis wrote:
> > >
> > >> From: Hans de Goede <hansg@kernel.org>
> > >>
> > >> Add 'name' argument to of_led_get() such that it can lookup LEDs in
> > >> devicetree by either name or index.
> > >>
> > >> And use this modified function to add devicetree support to the generic
> > >> (non devicetree specific) [devm_]led_get() function.
> > >>
> > >> This uses the standard devicetree pattern of adding a -names string array
> > >> to map names to the indexes for an array of resources.
> > >>
> > >> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > >> Reviewed-by: Lee Jones <lee@kernel.org>
> > >
> > > Remind me why this can't go in through LED again?
> >
> > I don't think anyone has discussed how to merge this yet.
> >
> > I believe that the LED tree is the correct tree to merge this
> > entire series through, once the DT bits have been reviewed.
> >
>
> Unless there are some strong reasons (that I'm failing to spot), we
> should merge the DeviceTree binding and implementation through the LED
> tree. Then I merge the DTS change through the Qualcomm DT tree once the
> bindings are available in linux-next.
1-3 have been applied to the LED tree already.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-09-16 16:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 12:01 [PATCH v5 0/4] leds: privacy-led support for devicetree Aleksandrs Vinarskis
2025-09-10 12:01 ` [PATCH v5 1/4] dt-bindings: leds: add generic LED consumer documentation Aleksandrs Vinarskis
2025-09-15 0:01 ` Rob Herring (Arm)
2025-09-10 12:01 ` [PATCH v5 2/4] dt-bindings: leds: commonize leds property Aleksandrs Vinarskis
2025-09-15 0:01 ` Rob Herring (Arm)
2025-09-10 12:01 ` [PATCH v5 3/4] leds: led-class: Add devicetree support to led_get() Aleksandrs Vinarskis
2025-09-10 12:22 ` Konrad Dybcio
2025-09-10 12:54 ` Aleksandrs Vinarskis
2025-09-10 13:00 ` Konrad Dybcio
2025-09-11 8:15 ` Lee Jones
2025-09-11 9:01 ` Hans de Goede
2025-09-16 15:43 ` Bjorn Andersson
2025-09-16 16:07 ` Lee Jones [this message]
2025-09-23 8:36 ` Aleksandrs Vinarskis
2025-09-10 12:01 ` [PATCH v5 4/4] arm64: dts: qcom: sc8280xp-x13s: enable camera privacy indicator Aleksandrs Vinarskis
2025-09-10 12:21 ` Konrad Dybcio
2025-09-10 17:04 ` Steev Klimaszewski
2025-09-10 17:47 ` Steev Klimaszewski
2025-09-16 14:52 ` (subset) [PATCH v5 0/4] leds: privacy-led support for devicetree Lee Jones
2025-10-30 16:25 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250916160707.GA3893363@google.com \
--to=lee@kernel.org \
--cc=alex@vinarskis.com \
--cc=andersson@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=danielt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hansg@kernel.org \
--cc=jacopo@jmondi.org \
--cc=jingoohan1@gmail.com \
--cc=jjhiblot@traphandler.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=threeway@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox