Re: [PATCH v3 8/8] ARM: dts: r9a06g032: Add support for GPIO interrupts

Herve Codina
2025-09-19T13:59:33Z

On Fri, 19 Sep 2025 11:42:46 +0200
Wolfram Sang <wsa+renesas@sang-engineering.com> wrote:

> > + /*
> > + * interrupt-map has to be updated according to GPIO
> > + * usage. The order has to be kept. Only the src irq
> > + * (0 field) has to be updated with the needed GPIO
> > + * interrupt number.
> > + */
> > + interrupt-map = <0 &gic GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>,
> > + <0 &gic GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>,
> > + <0 &gic GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>,
> > + <0 &gic GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>,
> > + <0 &gic GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>,
> > + <0 &gic GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>,
> > + <0 &gic GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>,
> > + <0 &gic GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>;
>
> I'd think this should be dropped from the include and added in the board
> file instead. I did this with my board and it works fine.
>

I can only reduce the table but I need to keep the interrupt-map property.

'interrupt-map' is a required property. If the board doesn't use any interrupt
GPIO, its dts has no reason to set the interrupt-map.

In that case, if I fully remove 'interrupt-map' in the dtsi, dtbs_check
will not be happy. Indeed, a required property is missing.

Also, having the full table containing the 8 items with the correct GIC
interrupt number and the correct order could help a user to route the
GPIO line to one of those 8 items.

The '0' field use as interrupt source matches the registers reset value
of the irq-mux controller.

With that in mind, do you still think that I should reduce this table?

Best regards,
Hervé