Re: [PATCH v3 6/8] dt-bindings: soc: renesas: Add the Renesas RZ/N1 GPIO Interrupt Multiplexer

Conor Dooley
2025-09-18T15:44:11Z

[-- Attachment #1: Type: text/plain, Size: 1793 bytes --]

On Thu, Sep 18, 2025 at 05:39:15PM +0200, Herve Codina wrote:
> On Thu, 18 Sep 2025 16:26:59 +0100
> Conor Dooley <conor@kernel.org> wrote:
>
> > On Thu, Sep 18, 2025 at 05:15:02PM +0200, Herve Codina wrote:
> > > Hi Conor,
> > >
> > > On Thu, 18 Sep 2025 16:06:04 +0100
> > > Conor Dooley <conor@kernel.org> wrote:
> > >
> > > > On Thu, Sep 18, 2025 at 12:40:04PM +0200, Herve Codina (Schneider Electric) wrote:
> > > > > On the Renesas RZ/N1 SoC, GPIOs can generate interruptions. Those
> > > > > interruption lines are multiplexed by the GPIO Interrupt Multiplexer in
> > > > > order to map 32 * 3 GPIO interrupt lines to 8 GIC interrupt lines.
> > > > >
> > > > > The GPIO interrupt multiplexer IP does nothing but select 8 GPIO
> > > > > IRQ lines out of the 96 available to wire them to the GIC input lines.
> > > > >
> > > > > Signed-off-by: Herve Codina (Schneider Electric) <herve.codina@bootlin.com>
> > > > > ---
> > > > > .../soc/renesas/renesas,rzn1-gpioirqmux.yaml | 87 +++++++++++++++++++
> > > > > 1 file changed, 87 insertions(+)
> > > > > create mode 100644 Documentation/devicetree/bindings/soc/renesas/renesas,rzn1-gpioirqmux.yaml
> > > >
> > > > This is an interrupt controller, please move it to that subdirectory.
> > >
> > > Not so sure. It is a nexus node. It routes interrupt signals to the
> > > interrupt controller (interrupt-map) but it is not an interrupt controller
> > > itself.
> > >
> > > I am not sure that it should be moved to the interrupt-controller
> > > directory.
> >
> > Your node name choice disagrees with you!
>
> Oups, you're right, my bad.
>
> What do you think if I change the node name from "interrupt-controller" to
> "interrupt-mux" in the next iteration?

I guess, sure.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]