Re: [PATCH 05/25] dt-bindings: rtc: Add RDA Micro RDA8810PL RTC

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2104 bytes --]

On Thu, Sep 18, 2025 at 11:11:10AM +0700, Dang Huynh wrote:
> On 2025-09-18 03:46, Conor Dooley wrote:
> > On Wed, Sep 17, 2025 at 03:07:22AM +0700, Dang Huynh wrote:
> > > Add documentation describing the RTC found in RDA8810PL SoC.
> > > 
> > > Signed-off-by: Dang Huynh <dang.huynh@mainlining.org>
> > > ---
> > >  .../devicetree/bindings/rtc/rda,8810pl-rtc.yaml    | 30
> > > ++++++++++++++++++++++
> > >  1 file changed, 30 insertions(+)
> > > 
> > > diff --git
> > > a/Documentation/devicetree/bindings/rtc/rda,8810pl-rtc.yaml
> > > b/Documentation/devicetree/bindings/rtc/rda,8810pl-rtc.yaml
> > > new file mode 100644
> > > index 0000000000000000000000000000000000000000..3ceae294921cc3211cd775d9b3890393196faf82
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/rtc/rda,8810pl-rtc.yaml
> > > @@ -0,0 +1,30 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/rtc/rda,8810pl-rtc.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: RDA Micro RDA8810PL Real Time Clock
> > > +
> > > +maintainers:
> > > +  - Dang Huynh <dang.huynh@mainlining.org>
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: rda,8810pl-rtc
> > > +
> > > +  reg:
> > > +    maxItems: 1
> > > +
> > > +required:
> > > +  - compatible
> > > +  - reg
> > 
> > Your driver implements functions that turn on an alarm irq, but there is
> > none mentioned here. What's going on there?
> The RTC doesn't seem to have an AP IRQ associated. I can't find any
> reference to it on downstream kernel and the docs.
> 
> > 
> > Additionally, there's no clocks property? For an onboard RTC I'd have
> > expected there to be a clock sourced outside of the block.

What about the clock?

> > 
> > > +
> > > +additionalProperties: false
> > > +
> > > +examples:
> > > +  - |
> > > +    rtc@1a06000 {
> > > +      compatible = "rda,8810pl-rtc";
> > > +      reg = <0x1a06000 0x1000>;
> > > +    };
> > > 
> > > --
> > > 2.51.0

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]