public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>,
	Wesley Cheng <quic_wcheng@quicinc.com>,
	Jack Pham <quic_jackp@quicinc.com>,
	Raghavendra Thoorpu <rthoorpu@qti.qualcomm.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Mayank Rana <mayank.rana@oss.qualcomm.com>,
	Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Andreas Noever <andreas.noever@gmail.com>,
	Mika Westerberg <westeri@kernel.org>,
	Yehezkel Bernat <YehezkelShB@gmail.com>,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH RFC] dt-bindings: thunderbolt: Add Qualcomm USB4 Host Router
Date: Thu, 18 Sep 2025 17:23:22 +0200	[thread overview]
Message-ID: <20250918152322.GK2912318@black.igk.intel.com> (raw)
In-Reply-To: <035c0d66-bddd-495c-bd23-e1d98570ba7f@oss.qualcomm.com>

Hi,

On Thu, Sep 18, 2025 at 11:05:42AM +0200, Konrad Dybcio wrote:
> > I it hard to change these DT bindings later on? If yes then I would
> > definitely think forward and make this support MSI from the get-go.
> 
> dt-bindings (attempt to) promise an ABI-like interface, so bindings
> for *a given IP block* ("dt-bindings describe the hardware") should
> not change, unless there's something critically wrong (e.g. "this
> could have never really worked").

Then I think it is good to think few steps forward and make sure when
Qualcomm adds MSI to their IP it can be easily desribed in the DT bindings.

> Adding new properties is always OK, marking the new properties  as
> 'required' is not (unless it falls into the aforementioned case).
> 
> It's also totally OK to add MSI properties to e.g. Apple Host Router
> bindings specifically when they come around, as it's simply a different
> piece of hardware. It's also OK to create a usb4-host-router.yaml down
> the line, which will act as a common include and perform any
> maintenance/code churn, so long as it doesn't end up in the bindings
> for any specific hw block (e.g. this QC one) becoming more strict
> than they were on HEAD^.

Okay thanks for the explanation.

  reply	other threads:[~2025-09-18 15:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-16 20:06 [PATCH RFC] dt-bindings: thunderbolt: Add Qualcomm USB4 Host Router Konrad Dybcio
2025-09-16 22:48 ` Dmitry Baryshkov
2025-09-17  6:12 ` Mika Westerberg
2025-09-17 18:36   ` Konrad Dybcio
2025-09-18  5:12     ` Mika Westerberg
2025-09-18  9:05       ` Konrad Dybcio
2025-09-18 15:23         ` Mika Westerberg [this message]
2025-09-18 15:38           ` Konrad Dybcio
2025-09-18 16:23             ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250918152322.GK2912318@black.igk.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=bjorn.andersson@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krishna.kurapati@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=manivannan.sadhasivam@oss.qualcomm.com \
    --cc=mayank.rana@oss.qualcomm.com \
    --cc=quic_jackp@quicinc.com \
    --cc=quic_wcheng@quicinc.com \
    --cc=robh@kernel.org \
    --cc=rthoorpu@qti.qualcomm.com \
    --cc=westeri@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox