Re: [PATCH v6 0/7] ARM: dts: aspeed: Add Balcones system

[Rob Herring <robh@kernel.org>]

On Thu, Sep 18, 2025 at 05:33:06PM -0500, Rob Herring (Arm) wrote:
> 
> On Thu, 18 Sep 2025 13:03:55 -0500, Eddie James wrote:
> > The Balcones system is similar to Bonnell but with a POWER11 processor.
> > 
> > Changes since v5:
> >  - Add patch to add address and size cells to max31790 document
> >  - Don't remove address and size cells in max31785 fixes change
> > 
> > Changes since v4:
> >  - Add patch to fix max31785 warnings
> >  - Add patch to fix missing Bonnell documentation
> > 
> > Changes since v3:
> >  - Add max31785 to the max31790 document instead of to trivial-devices
> >  - Fix minor formatting in dps310 document
> > 
> > Changes since v2:
> >  - Fix a couple of incorrect i2c addresses
> >  - Document dps310 and max31785 properly
> >  - Drop the UCD binding documentation update, it's been fixed
> > 
> > Changes since v1:
> >  - Add all the ucd9000 driver supported compatible strings
> >  - Fix node ordering in Balcones device tree
> >  - Improve commit message to explain addition of ibm-power11-dual.dtsi
> > 
> > Eddie James (7):
> >   dt-bindings: arm: aspeed: add IBM Balcones board
> >   dt-bindings: arm: aspeed: add IBM Bonnell board
> >   dt-bindings: iio: Add Infineon DPS310 sensor documentation
> >   dt-bindings: hwmon: Move max31785 compatibles to max31790 document
> >   dt-bindings: hwmon: max31790: Document address and size cells
> >   ARM: dts: aspeed: Add Balcones system
> >   ARM: dts: aspeed: Fix max31785 fan node naming
> > 
> >  .../bindings/arm/aspeed/aspeed.yaml           |   2 +
> >  .../devicetree/bindings/hwmon/max31785.txt    |  22 -
> >  .../bindings/hwmon/maxim,max31790.yaml        |  12 +-
> >  .../iio/pressure/infineon,dps310.yaml         |  44 +
> >  .../devicetree/bindings/trivial-devices.yaml  |   2 -
> >  MAINTAINERS                                   |   1 +
> >  arch/arm/boot/dts/aspeed/Makefile             |   1 +
> >  .../dts/aspeed/aspeed-bmc-ibm-balcones.dts    | 609 ++++++++++++++
> >  .../dts/aspeed/aspeed-bmc-ibm-bonnell.dts     |   4 +-
> >  .../dts/aspeed/aspeed-bmc-ibm-everest.dts     |   8 +-
> >  .../dts/aspeed/aspeed-bmc-ibm-rainier.dts     |  12 +-
> >  .../boot/dts/aspeed/aspeed-bmc-opp-tacoma.dts |   8 +-
> >  .../arm/boot/dts/aspeed/ibm-power11-dual.dtsi | 779 ++++++++++++++++++
> >  .../arm/boot/dts/aspeed/ibm-power11-quad.dtsi | 769 +----------------
> >  14 files changed, 1465 insertions(+), 808 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/hwmon/max31785.txt
> >  create mode 100644 Documentation/devicetree/bindings/iio/pressure/infineon,dps310.yaml
> >  create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dts
> >  create mode 100644 arch/arm/boot/dts/aspeed/ibm-power11-dual.dtsi
> > 
> > --
> > 2.51.0
> > 
> > 
> > 
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> This patch series was applied (using b4) to base:
>  Base: attempting to guess base-commit...
>  Base: tags/next-20250917 (best guess, 10/11 blobs matched)
> 
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
> 
> New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/aspeed/' for 20250918180402.199373-1-eajames@linux.ibm.com:
> 
> arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: timer (arm,armv7-timer): 'clocks' does not match any of the regexes: '^pinctrl-[0-9]+$'
> 	from schema $id: http://devicetree.org/schemas/timer/arm,arch_timer.yaml#
> arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: /sdram@1e6e0000: failed to match any schema with compatible: ['aspeed,ast2600-sdram-edac', 'syscon']
> arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: bus@1e600000 (aspeed,ast2600-ahbc): compatible: ['aspeed,ast2600-ahbc', 'syscon'] is too long
> 	from schema $id: http://devicetree.org/schemas/bus/aspeed,ast2600-ahbc.yaml#
> arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: syscon@1e6e2000 (aspeed,ast2600-scu): 'smp-memram@180' does not match any of the regexes: '^interrupt-controller@[0-9a-f]+$', '^p2a-control@[0-9a-f]+$', '^pinctrl(@[0-9a-f]+)?$', '^pinctrl-[0-9]+$', '^silicon-id@[0-9a-f]+$'
> 	from schema $id: http://devicetree.org/schemas/mfd/aspeed,ast2x00-scu.yaml#
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dtb: max31785@52 (maxim,max31785a): fan-0: Unevaluated properties are not allowed ('compatible', 'maxim,fan-dual-tach', 'maxim,fan-fault-pin-mon', 'maxim,fan-no-fault-ramp', 'maxim,fan-no-watchdog', 'maxim,fan-pwm-freq', 'maxim,fan-ramp', 'maxim,fan-rotor-input', 'tach-pulses' were unexpected)
> 	from schema $id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml#
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dtb: max31785@52 (maxim,max31785a): fan-1: Unevaluated properties are not allowed ('compatible', 'maxim,fan-dual-tach', 'maxim,fan-fault-pin-mon', 'maxim,fan-no-fault-ramp', 'maxim,fan-no-watchdog', 'maxim,fan-pwm-freq', 'maxim,fan-ramp', 'maxim,fan-rotor-input', 'tach-pulses' were unexpected)
> 	from schema $id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml#
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dtb: max31785@52 (maxim,max31785a): fan-2: Unevaluated properties are not allowed ('compatible', 'maxim,fan-dual-tach', 'maxim,fan-fault-pin-mon', 'maxim,fan-no-fault-ramp', 'maxim,fan-no-watchdog', 'maxim,fan-pwm-freq', 'maxim,fan-ramp', 'maxim,fan-rotor-input', 'tach-pulses' were unexpected)
> 	from schema $id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml#
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dtb: max31785@52 (maxim,max31785a): fan-3: Unevaluated properties are not allowed ('compatible', 'maxim,fan-dual-tach', 'maxim,fan-fault-pin-mon', 'maxim,fan-no-fault-ramp', 'maxim,fan-no-watchdog', 'maxim,fan-pwm-freq', 'maxim,fan-ramp', 'maxim,fan-rotor-input', 'tach-pulses' were unexpected)
> 	from schema $id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml#
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dtb: /ahb/apb/bus@1e78a000/i2c@200/max31785@52/fan-0: failed to match any schema with compatible: ['pmbus-fan']
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dtb: /ahb/apb/bus@1e78a000/i2c@200/max31785@52/fan-1: failed to match any schema with compatible: ['pmbus-fan']
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dtb: /ahb/apb/bus@1e78a000/i2c@200/max31785@52/fan-2: failed to match any schema with compatible: ['pmbus-fan']
> arch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dtb: /ahb/apb/bus@1e78a000/i2c@200/max31785@52/fan-3: failed to match any schema with compatible: ['pmbus-fan']

Sigh. Are you testing this before sending?

None of these "maxim" properties are documented nor used by any driver. 
I don't know what a 'pmbus-fan' is as it is not documented.

For the fan child nodes and their node names, it is quite simple. You 
have 2 options:

fan-[0-9]+:
- no reg property
- no #address-cells or #size-cells in the parent node

fan@[0-9a-f]:
- must have reg property
- must have #address-cells or #size-cells in the parent node

If the parent device has a concept of fan channels (perhaps pages as 
the driver calls them?), then you should use 'reg' to map the fan 
channels to child nodes. For some fan controllers, 'reg' corresponds 
to the PWM number or pin number. Node names are generally not considered 
ABI, so you shouldn't be using them at all. That means the "fan-[0-9]+" 
case has no mapping between the fan node and instances in the fan 
controller.

Rob