* [PATCH v3] arm64: dts: correct the flexspi compatible string to match with yaml
@ 2025-09-19 9:59 Haibo Chen
2025-10-16 6:00 ` Bough Chen
0 siblings, 1 reply; 3+ messages in thread
From: Haibo Chen @ 2025-09-19 9:59 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Michael Walle, Peng Fan, Frank Li, Marco Felsch, Han Xu
Cc: devicetree, imx, linux-arm-kernel, linux-kernel, Frank Li,
Haibo Chen
According to Documentation/devicetree/bindings/spi/spi-nxp-fspi.yaml,
imx93/imx95 should use it's own compatible string and fallback
compatible with imx8mm.
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
PATCH1 adjust the compatible string to align with yaml
---
Changes in v3:
- PATCH1: add Frank's review tag.
- Drop PATCH2~4, according to Peng Fan and Michael's comment, need to move this
limitation to driver side.
- Link to v2: https://lore.kernel.org/r/20250917-flexspi-dts-v2-0-7e2a95e3cf4d@nxp.com
Changes in v2:
- PATCH1: small change of the commit log according to Fabio's comment
- PATCH2~4: fix type and split into 3 patches and add fix tag accordingly.
- Link to v1: https://lore.kernel.org/r/20250916-flexspi-dts-v1-0-61567f969165@nxp.com
---
arch/arm64/boot/dts/freescale/imx91_93_common.dtsi | 2 +-
arch/arm64/boot/dts/freescale/imx95.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi b/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
index 52da571f26c4e8a2703e4476b5541fa7aca52f10..7958cef353766a430df5e626ff2403dc05a974b1 100644
--- a/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
@@ -706,7 +706,7 @@ flexcan2: can@425b0000 {
};
flexspi1: spi@425e0000 {
- compatible = "nxp,imx8mm-fspi";
+ compatible = "nxp,imx93-fspi", "nxp,imx8mm-fspi";
reg = <0x425e0000 0x10000>, <0x28000000 0x10000000>;
reg-names = "fspi_base", "fspi_mmap";
#address-cells = <1>;
diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi b/arch/arm64/boot/dts/freescale/imx95.dtsi
index 1292677cbe4eb8c5f3ec2874a17ad6efd0111192..a0ff7002be9fa0529ba5712df4c056c56f0e3242 100644
--- a/arch/arm64/boot/dts/freescale/imx95.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx95.dtsi
@@ -945,7 +945,7 @@ flexcan3: can@42600000 {
};
flexspi1: spi@425e0000 {
- compatible = "nxp,imx8mm-fspi";
+ compatible = "nxp,imx95-fspi", "nxp,imx8mm-fspi";
reg = <0x425e0000 0x10000>, <0x28000000 0x8000000>;
reg-names = "fspi_base", "fspi_mmap";
#address-cells = <1>;
---
base-commit: c3067c2c38316c3ef013636c93daa285ee6aaa2e
change-id: 20250916-flexspi-dts-24af8b6bf468
Best regards,
--
Haibo Chen <haibo.chen@nxp.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH v3] arm64: dts: correct the flexspi compatible string to match with yaml
2025-09-19 9:59 [PATCH v3] arm64: dts: correct the flexspi compatible string to match with yaml Haibo Chen
@ 2025-10-16 6:00 ` Bough Chen
2025-10-16 6:11 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Bough Chen @ 2025-10-16 6:00 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Michael Walle, Peng Fan, Frank Li, Marco Felsch, Han Xu
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Frank Li
Gentle ping...
> -----Original Message-----
> From: Bough Chen <haibo.chen@nxp.com>
> Sent: 2025年9月19日 18:00
> To: Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>;
> Conor Dooley <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>;
> Sascha Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Michael
> Walle <michael@walle.cc>; Peng Fan <peng.fan@nxp.com>; Frank Li
> <frank.li@nxp.com>; Marco Felsch <m.felsch@pengutronix.de>; Han Xu
> <han.xu@nxp.com>
> Cc: devicetree@vger.kernel.org; imx@lists.linux.dev;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Frank Li
> <frank.li@nxp.com>; Bough Chen <haibo.chen@nxp.com>
> Subject: [PATCH v3] arm64: dts: correct the flexspi compatible string to match
> with yaml
>
> According to Documentation/devicetree/bindings/spi/spi-nxp-fspi.yaml,
> imx93/imx95 should use it's own compatible string and fallback compatible with
> imx8mm.
>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
> PATCH1 adjust the compatible string to align with yaml
> ---
> Changes in v3:
> - PATCH1: add Frank's review tag.
> - Drop PATCH2~4, according to Peng Fan and Michael's comment, need to move
> this
> limitation to driver side.
> - Link to v2:
> https://lore.kernel.org/r/20250917-flexspi-dts-v2-0-7e2a95e3cf4d@nxp.com
>
> Changes in v2:
> - PATCH1: small change of the commit log according to Fabio's comment
> - PATCH2~4: fix type and split into 3 patches and add fix tag accordingly.
> - Link to v1:
> https://lore.kernel.org/r/20250916-flexspi-dts-v1-0-61567f969165@nxp.com
> ---
> arch/arm64/boot/dts/freescale/imx91_93_common.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/imx95.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
> b/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
> index
> 52da571f26c4e8a2703e4476b5541fa7aca52f10..7958cef353766a430df5e626ff
> 2403dc05a974b1 100644
> --- a/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
> @@ -706,7 +706,7 @@ flexcan2: can@425b0000 {
> };
>
> flexspi1: spi@425e0000 {
> - compatible = "nxp,imx8mm-fspi";
> + compatible = "nxp,imx93-fspi", "nxp,imx8mm-fspi";
> reg = <0x425e0000 0x10000>, <0x28000000 0x10000000>;
> reg-names = "fspi_base", "fspi_mmap";
> #address-cells = <1>;
> diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi
> b/arch/arm64/boot/dts/freescale/imx95.dtsi
> index
> 1292677cbe4eb8c5f3ec2874a17ad6efd0111192..a0ff7002be9fa0529ba5712df4
> c056c56f0e3242 100644
> --- a/arch/arm64/boot/dts/freescale/imx95.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx95.dtsi
> @@ -945,7 +945,7 @@ flexcan3: can@42600000 {
> };
>
> flexspi1: spi@425e0000 {
> - compatible = "nxp,imx8mm-fspi";
> + compatible = "nxp,imx95-fspi", "nxp,imx8mm-fspi";
> reg = <0x425e0000 0x10000>, <0x28000000 0x8000000>;
> reg-names = "fspi_base", "fspi_mmap";
> #address-cells = <1>;
>
> ---
> base-commit: c3067c2c38316c3ef013636c93daa285ee6aaa2e
> change-id: 20250916-flexspi-dts-24af8b6bf468
>
> Best regards,
> --
> Haibo Chen <haibo.chen@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v3] arm64: dts: correct the flexspi compatible string to match with yaml
2025-10-16 6:00 ` Bough Chen
@ 2025-10-16 6:11 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2025-10-16 6:11 UTC (permalink / raw)
To: Bough Chen, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Michael Walle, Peng Fan, Frank Li, Marco Felsch, Han Xu
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On 16/10/2025 08:00, Bough Chen wrote:
> Gentle ping...
Why maintainer would take it if it cannot be spotted?
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-16 6:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-19 9:59 [PATCH v3] arm64: dts: correct the flexspi compatible string to match with yaml Haibo Chen
2025-10-16 6:00 ` Bough Chen
2025-10-16 6:11 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).