From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 567561EF38E for ; Fri, 19 Sep 2025 19:08:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758308916; cv=none; b=sksUN6Dcv5KN10d9VtuwquPKYsRKU3Obve1qGdQTKfW+rCjBmAPvUssTR4ufkGL1UlYOnshNLwFwLScLbsbsZAa8cfqsKtMbgTTUf6MbYxpVAAHCgwP6UgdJERhMHnmFdNE/CdRoX7ChAAw+/ZwCtbCjvyzdm2NxxczbVKVnbC4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758308916; c=relaxed/simple; bh=zukaVKtCam3T0s4P5Dx8x5fIeFUMjIn/NWf4ujlgXE8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hqj8ieke3OO5BnIIzgUuTK+gAmmiWgCjs9V1IDRUWcubD8P+GlBI6qtFIqWFM8DoW3e8dX96Ts2fgEKPqdJraxJBA8yfBg9/0hyWRUEtrJr9+f15illFUUtxmqr8fnyYM42vUkM9B1cXfM7eQcogMaBaG9WFFScjPeZpXZ2m8vs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uzgSv-0002ob-RX; Fri, 19 Sep 2025 21:08:17 +0200 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uzgSs-0029dN-2q; Fri, 19 Sep 2025 21:08:14 +0200 Received: from pengutronix.de (ip-185-104-138-125.ptr.icomera.net [185.104.138.125]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 425AF4751ED; Fri, 19 Sep 2025 19:08:13 +0000 (UTC) Date: Fri, 19 Sep 2025 21:08:12 +0200 From: Marc Kleine-Budde To: Peng Fan Cc: Vincent Mailhol , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Aswath Govindraju , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Haibo Chen , linux-can@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 2/9] phy: phy-can-transceiver: Introduce can_transceiver_priv Message-ID: <20250919-tall-speedy-parrot-8510db-mkl@pengutronix.de> References: <20250909-can-v6-0-1cc30715224c@nxp.com> <20250909-can-v6-2-1cc30715224c@nxp.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cd3z7kopob7ivfax" Content-Disposition: inline In-Reply-To: <20250909-can-v6-2-1cc30715224c@nxp.com> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org --cd3z7kopob7ivfax Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v6 2/9] phy: phy-can-transceiver: Introduce can_transceiver_priv MIME-Version: 1.0 On 09.09.2025 13:40:12, Peng Fan wrote: > To prepare for dual-channel phy support, introduce can_transceiver_priv as > a higher level encapsulation for phy and mux_state. >=20 > No functional changes. >=20 > Reviewed-by: Frank Li > Signed-off-by: Peng Fan > --- > drivers/phy/phy-can-transceiver.c | 41 ++++++++++++++++++++++++++-------= ------ > 1 file changed, 27 insertions(+), 14 deletions(-) >=20 > diff --git a/drivers/phy/phy-can-transceiver.c b/drivers/phy/phy-can-tran= sceiver.c > index f59caff4b3d4c267feca4220bf1547b6fad08f95..6415c6af0e8414a6cc8d15958= a17ee749a3f28e9 100644 > --- a/drivers/phy/phy-can-transceiver.c > +++ b/drivers/phy/phy-can-transceiver.c > @@ -23,6 +23,11 @@ struct can_transceiver_phy { > struct phy *generic_phy; > struct gpio_desc *standby_gpio; > struct gpio_desc *enable_gpio; > + struct can_transceiver_priv *priv; Can you convert this into a flexible-array? This reduces the overhead of a 2nd allocation. Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung N=C3=BCrnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 | --cd3z7kopob7ivfax Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEn/sM2K9nqF/8FWzzDHRl3/mQkZwFAmjNqhkACgkQDHRl3/mQ kZwACgf/b5xzS9pWKSdkZcmVns9SIHHO1d1PGZP3mJEVq1zZWfnBMx0PSJCfosmF Z6vfc8EMPd+XZhNRcltvC56VojbtsS8DQceTIuWGcShPDtN6gFp5N6MTUXGESNe5 F8ttf96l1LrLZoCsUW+TrBBdHNh6OWxZaOMALi7i3Y9xAqBALu1XAiVZE4VIRpcm OPENZKma3l0f3nnG7jHqXditf4Uc8Vs0Pjon4iQAvMqOPogZvwwsfi1aV0aBaICA EBpB5Uk48XiZnSCaOMU1KFnUF+xLqr4IBh0hI4ni/9pazDxJRxQf1790YzHZ2bkF BnzXsTZF/syHHEADDEP2WXU4PfjefQ== =4N72 -----END PGP SIGNATURE----- --cd3z7kopob7ivfax--