devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v6 1/4] dt-bindings: rtc: Document NVIDIA VRS RTC
@ 2025-09-19 13:59 Shubhi Garg
  2025-09-22 19:53 ` Rob Herring
  0 siblings, 1 reply; 4+ messages in thread
From: Shubhi Garg @ 2025-09-19 13:59 UTC (permalink / raw)
  To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Catalin Marinas, Will Deacon, Alexandre Belloni, Jonathan Hunter
  Cc: devicetree, linux-arm-kernel, linux-rtc, linux-tegra, Shubhi Garg

Add device tree bindings for NVIDIA VRS (Voltage Regulator Specification)
RTC device. NVIDIA VRS is a Power Management IC (PMIC) that implements a
power sequencing solution with I2C interface. The device includes RTC
which provides functionality to get/set system time, retain system
time across boot, wake system from suspend and shutdown state.

Supported platforms:
- NVIDIA Jetson AGX Orin Developer Kit
- NVIDIA IGX Orin Development Kit
- NVIDIA Jetson Orin NX Developer Kit
- NVIDIA Jetson Orin Nano Developer Kit

Signed-off-by: Shubhi Garg <shgarg@nvidia.com>
---

v6:
- compatible name fixes to "nvidia,vrs-10"
- changed dtb node name to pmic@3c

v5:
- moved device tree bindings from mfd to rtc
- changed dtb node name to rtc@3c
- changed compatible string to "nvidia,vrs10-rtc"

v4:
- no changes

v3:
- fixed device tree node name to generic "pmic@3c"
- fixed indentation

v2:
- fixed copyrights
- updated description with RTC information
- added status node in dtb node example

 .../bindings/rtc/nvidia,vrs10-rtc.yaml        | 59 +++++++++++++++++++
 1 file changed, 59 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/rtc/nvidia,vrs10-rtc.yaml

diff --git a/Documentation/devicetree/bindings/rtc/nvidia,vrs10-rtc.yaml b/Documentation/devicetree/bindings/rtc/nvidia,vrs10-rtc.yaml
new file mode 100644
index 000000000000..e8f3c25607e0
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/nvidia,vrs10-rtc.yaml
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/nvidia,vrs10-rtc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NVIDIA Voltage Regulator Specification Real Time Clock
+
+maintainers:
+  - Shubhi Garg <shgarg@nvidia.com>
+
+description:
+  NVIDIA VRS-10 (Voltage Regulator Specification) is a Power Management IC
+  (PMIC) that implements a power sequencing solution with I2C interface.
+  The device includes a real-time clock (RTC) with 32kHz clock output and
+  backup battery support, alarm functionality for system wake-up from
+  suspend and shutdown states, OTP memory for power sequencing configuration,
+  and an interrupt controller for managing VRS events.
+
+properties:
+  compatible:
+    const: nvidia,vrs-10
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  interrupt-controller: true
+
+  '#interrupt-cells':
+    const: 2
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - interrupt-controller
+  - '#interrupt-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        pmic@3c {
+            compatible = "nvidia,vrs-10";
+            reg = <0x3c>;
+            interrupt-parent = <&pmc>;
+            interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
+            interrupt-controller;
+            #interrupt-cells = <2>;
+        };
+    };
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v6 1/4] dt-bindings: rtc: Document NVIDIA VRS RTC
  2025-09-19 13:59 [PATCH v6 1/4] dt-bindings: rtc: Document NVIDIA VRS RTC Shubhi Garg
@ 2025-09-22 19:53 ` Rob Herring
  2025-09-22 20:08   ` Jon Hunter
  0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2025-09-22 19:53 UTC (permalink / raw)
  To: Shubhi Garg
  Cc: Lee Jones, Krzysztof Kozlowski, Conor Dooley, Catalin Marinas,
	Will Deacon, Alexandre Belloni, Jonathan Hunter, devicetree,
	linux-arm-kernel, linux-rtc, linux-tegra

On Fri, Sep 19, 2025 at 01:59:50PM +0000, Shubhi Garg wrote:
> Add device tree bindings for NVIDIA VRS (Voltage Regulator Specification)
> RTC device. NVIDIA VRS is a Power Management IC (PMIC) that implements a
> power sequencing solution with I2C interface. The device includes RTC
> which provides functionality to get/set system time, retain system
> time across boot, wake system from suspend and shutdown state.

I only see this patch. The threading of this is broken.

> 
> Supported platforms:
> - NVIDIA Jetson AGX Orin Developer Kit
> - NVIDIA IGX Orin Development Kit
> - NVIDIA Jetson Orin NX Developer Kit
> - NVIDIA Jetson Orin Nano Developer Kit
> 
> Signed-off-by: Shubhi Garg <shgarg@nvidia.com>
> ---
> 
> v6:
> - compatible name fixes to "nvidia,vrs-10"
> - changed dtb node name to pmic@3c
> 
> v5:
> - moved device tree bindings from mfd to rtc
> - changed dtb node name to rtc@3c
> - changed compatible string to "nvidia,vrs10-rtc"
> 
> v4:
> - no changes
> 
> v3:
> - fixed device tree node name to generic "pmic@3c"
> - fixed indentation
> 
> v2:
> - fixed copyrights
> - updated description with RTC information
> - added status node in dtb node example
> 
>  .../bindings/rtc/nvidia,vrs10-rtc.yaml        | 59 +++++++++++++++++++

Filename should match compatible string.

>  1 file changed, 59 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rtc/nvidia,vrs10-rtc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/rtc/nvidia,vrs10-rtc.yaml b/Documentation/devicetree/bindings/rtc/nvidia,vrs10-rtc.yaml
> new file mode 100644
> index 000000000000..e8f3c25607e0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/nvidia,vrs10-rtc.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/nvidia,vrs10-rtc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NVIDIA Voltage Regulator Specification Real Time Clock
> +
> +maintainers:
> +  - Shubhi Garg <shgarg@nvidia.com>
> +
> +description:
> +  NVIDIA VRS-10 (Voltage Regulator Specification) is a Power Management IC
> +  (PMIC) that implements a power sequencing solution with I2C interface.
> +  The device includes a real-time clock (RTC) with 32kHz clock output and
> +  backup battery support, alarm functionality for system wake-up from
> +  suspend and shutdown states, OTP memory for power sequencing configuration,
> +  and an interrupt controller for managing VRS events.
> +
> +properties:
> +  compatible:
> +    const: nvidia,vrs-10
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  interrupt-controller: true
> +
> +  '#interrupt-cells':
> +    const: 2
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - interrupt-controller
> +  - '#interrupt-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        pmic@3c {
> +            compatible = "nvidia,vrs-10";
> +            reg = <0x3c>;
> +            interrupt-parent = <&pmc>;
> +            interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> +            interrupt-controller;
> +            #interrupt-cells = <2>;
> +        };
> +    };
> -- 
> 2.43.0
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v6 1/4] dt-bindings: rtc: Document NVIDIA VRS RTC
  2025-09-22 19:53 ` Rob Herring
@ 2025-09-22 20:08   ` Jon Hunter
  2025-09-25  5:36     ` Shubhi Garg
  0 siblings, 1 reply; 4+ messages in thread
From: Jon Hunter @ 2025-09-22 20:08 UTC (permalink / raw)
  To: Rob Herring, Shubhi Garg
  Cc: Lee Jones, Krzysztof Kozlowski, Conor Dooley, Catalin Marinas,
	Will Deacon, Alexandre Belloni, devicetree, linux-arm-kernel,
	linux-rtc, linux-tegra


On 22/09/2025 20:53, Rob Herring wrote:
> On Fri, Sep 19, 2025 at 01:59:50PM +0000, Shubhi Garg wrote:
>> Add device tree bindings for NVIDIA VRS (Voltage Regulator Specification)
>> RTC device. NVIDIA VRS is a Power Management IC (PMIC) that implements a
>> power sequencing solution with I2C interface. The device includes RTC
>> which provides functionality to get/set system time, retain system
>> time across boot, wake system from suspend and shutdown state.
> 
> I only see this patch. The threading of this is broken.

Yep I see the same. I am not sure what happened here, but let me work 
with Shubhi to get this resent.

Jon

-- 
nvpublic


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v6 1/4] dt-bindings: rtc: Document NVIDIA VRS RTC
  2025-09-22 20:08   ` Jon Hunter
@ 2025-09-25  5:36     ` Shubhi Garg
  0 siblings, 0 replies; 4+ messages in thread
From: Shubhi Garg @ 2025-09-25  5:36 UTC (permalink / raw)
  To: Jon Hunter, Rob Herring
  Cc: Lee Jones, Krzysztof Kozlowski, Conor Dooley, Catalin Marinas,
	Will Deacon, Alexandre Belloni, devicetree, linux-arm-kernel,
	linux-rtc, linux-tegra



On 23/09/25 1:38 am, Jon Hunter wrote:
> 
> On 22/09/2025 20:53, Rob Herring wrote:
>> On Fri, Sep 19, 2025 at 01:59:50PM +0000, Shubhi Garg wrote:
>>> Add device tree bindings for NVIDIA VRS (Voltage Regulator 
>>> Specification)
>>> RTC device. NVIDIA VRS is a Power Management IC (PMIC) that implements a
>>> power sequencing solution with I2C interface. The device includes RTC
>>> which provides functionality to get/set system time, retain system
>>> time across boot, wake system from suspend and shutdown state.
>>
>> I only see this patch. The threading of this is broken.
> 
> Yep I see the same. I am not sure what happened here, but let me work 
> with Shubhi to get this resent.

Yes, patches got sent individually so threading is broken.
I am fixing it and will send V7 version with more fixes.

-- 
Regards,
Shubhi


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-09-25  5:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-19 13:59 [PATCH v6 1/4] dt-bindings: rtc: Document NVIDIA VRS RTC Shubhi Garg
2025-09-22 19:53 ` Rob Herring
2025-09-22 20:08   ` Jon Hunter
2025-09-25  5:36     ` Shubhi Garg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).