From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D71B01B4223; Fri, 19 Sep 2025 12:40:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758285620; cv=none; b=MAoK5w4ZuLP1237Lubv+tcLt0lf0piF2XZYRDBWc/KEknwleI+4IHZuX8946sKsh/DbxetLX5iiXoVdICv4klDxaqPXNJ5GR1DmHqex49ZYCXRK1ir+ho5aDkpbJEBEyp/7aJ0sFEpYAqAItIhSbXI1Y5WuAOwtxmI6M7jo73Zk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758285620; c=relaxed/simple; bh=DSsKSdHuufHzAGTSQtvAWgVv0FxqTvtqiK5WHmKVQ4g=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tQ/EoZq4o2PP0iBGJjhMNHRvRROsRXNLsmLFvrMpx8SA+jLfZb+7er2mchyYzyfG0cplSY41RoefnFWR3wbN0qp0OPAFVqL2NWEYH7qZPv/ZkPYm23qcJ0oy2h2RzO2HtsLhWiKLi4kTMSqShb7k2BXrikWBQDopAo9i1c70bFQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=AuqWETXe; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="AuqWETXe" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 9246B1A0F14; Fri, 19 Sep 2025 12:40:10 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 65297606A8; Fri, 19 Sep 2025 12:40:10 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id AD3FD102F1C98; Fri, 19 Sep 2025 14:39:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1758285609; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=I/Pe5qOhDxLMMUTgQVYyG2nRgbxXtQ8qXCPs6Wd2cUo=; b=AuqWETXeUarHezFGbq2vVyHeR0fm0mGPzoxJSNsnyuyJDb3A8hskSO4A0xBJx2dVO7K8nw sX35hXyxsYCS9i6fhoWx6uYufk+f+vQ9xtWDpHubiV/E9nH3TaSopqcXTjhYLHDJHzG718 RzP6I4gME8qDEo1wk/bjvYJg684Q85D3QkD+fwNOZL8WeA0muaFXcVAExot8bfoFBO92DH IiPdODvDzT1jWoFeZ6hKJrGTFNeQG3JJnqIdDKYpQoM1q7PUkhDKAd1T4kBUBMcxbJy/z4 V8HwDoA5LUKQPTRhO6N89xKJfTCJiz49vkFlNu9p48y9IIhCdkXk8OZWC1c63g== Date: Fri, 19 Sep 2025 14:39:51 +0200 From: Herve Codina To: Wolfram Sang Cc: Thomas Gleixner , Hoan Tran , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Saravana Kannan , Serge Semin , Phil Edworthy , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Pascal Eberhard , Miquel Raynal , Thomas Petazzoni Subject: Re: [PATCH v3 6/8] dt-bindings: soc: renesas: Add the Renesas RZ/N1 GPIO Interrupt Multiplexer Message-ID: <20250919143951.15a1b4e6@bootlin.com> In-Reply-To: References: <20250918104009.94754-1-herve.codina@bootlin.com> <20250918104009.94754-7-herve.codina@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Hi Wolfram, On Fri, 19 Sep 2025 11:34:51 +0200 Wolfram Sang wrote: > > + interrupt-map: > > + description: > > + Specifies the mapping from external GPIO interrupt lines to the output > > + interrupts. The array items have to be ordered with the first item > > + related to the output line 0 (IRQ 103), the next one to the output line 1 > > + (IRQ 104) and so on up to the output line 8 (IRQ 110). > > maxItems 8? Yes indeed and probably both minItems: 1 maxItems: 8 > > > + /* > > + * The child interrupt number is computed using the following formula: > > + * gpio_bank * 32 + gpio_number > > + * > > + * with: > > + * - gpio_bank: The GPIO bank number > > + * - 0 for GPIO0A, > > + * - 1 for GPIO1A, > > + * - 2 for GPIO2A > > + * - gpio_number: Number of the gpio in the bank (0..31) > > + */ > > I wonder if this comment wouldn't be better in the interrupt-map > description above? > I will move in the description. Best regards, Hervé