From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDA55313D4B for ; Fri, 19 Sep 2025 13:59:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758290376; cv=none; b=RiDGksGMfRCgQedOHQRc7NjOyo7f9LWzUD8OAG/CFWalCJzy1LgppXbifHX1ohFzpM6R6jsz07rcyDua5oViA+87FuwjGM5P9F/KIT4Groww/YeFzUUWGxnlvkonrsy6Blfr09GogeG4fiNYvapdzJX91QhYycvhhNZnu9Vj0rw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758290376; c=relaxed/simple; bh=rYm7TDSt7m3UIo26WMvRENt6r9Gc+DAQRE/S6hKjId4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kOD5gz5TqzXSHL9TA3hJVbFHKMQC5Ye+RFT8DIbpH1w1PGztVPZAyOrTsE/61AcZ+GGnhn43QEw8smYsoaU8J9sBAQjeJb6phKnT7/1rUrukqtJgqbKcylqjpMTrJ+sbIpls7QbeompGo5LKgq5PUOdGNSgRotFkXgN/n3duKpU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=S8U1p6lk; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="S8U1p6lk" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 2D628C8F1C5; Fri, 19 Sep 2025 13:59:15 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id B6B02606A8; Fri, 19 Sep 2025 13:59:31 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 757D2102F1BCB; Fri, 19 Sep 2025 15:59:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1758290370; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=dWYgA9dXzIHOPv9DWHE+oxQc2sRvSmlPdD1Mhljo75M=; b=S8U1p6lkz1TkcMx0Lx7dsXI7Kddmg+uVELN9GHpySFHyJ2gk1ThiVW0Ya+PpybT6exc9ir wIbyd/ulU+97JOw74n87KFkRy2DwhRKtueVABl1T4qIL8gyh7hWyH5b1zwBUig4Uj5+qF+ wBUbg8bHk6dIV4ydjeSwxjXKSMAI/WFc4zzB9bodtyq0MM7BUh6IuYi/AhSiwVZstgnFTo rGoYqdY/RafwrWkZRO3L7Yhavyw4azaKKvM+itxgU5CFgpv9YsidHU9AjU7xbERlbPW6D8 PpD1EfNJvk7BY5MFrpomAw46ybV6NP/ps8+UcccH7gEU1RO8YZXoNhbGyVcKTg== Date: Fri, 19 Sep 2025 15:59:10 +0200 From: Herve Codina To: Wolfram Sang Cc: Thomas Gleixner , Hoan Tran , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Saravana Kannan , Serge Semin , Phil Edworthy , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Pascal Eberhard , Miquel Raynal , Thomas Petazzoni Subject: Re: [PATCH v3 8/8] ARM: dts: r9a06g032: Add support for GPIO interrupts Message-ID: <20250919155910.4d106256@bootlin.com> In-Reply-To: References: <20250918104009.94754-1-herve.codina@bootlin.com> <20250918104009.94754-9-herve.codina@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 On Fri, 19 Sep 2025 11:42:46 +0200 Wolfram Sang wrote: > > + /* > > + * interrupt-map has to be updated according to GPIO > > + * usage. The order has to be kept. Only the src irq > > + * (0 field) has to be updated with the needed GPIO > > + * interrupt number. > > + */ > > + interrupt-map = <0 &gic GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>, > > + <0 &gic GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>, > > + <0 &gic GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>, > > + <0 &gic GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>, > > + <0 &gic GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>, > > + <0 &gic GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>, > > + <0 &gic GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>, > > + <0 &gic GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>; > > I'd think this should be dropped from the include and added in the board > file instead. I did this with my board and it works fine. > I can only reduce the table but I need to keep the interrupt-map property. 'interrupt-map' is a required property. If the board doesn't use any interrupt GPIO, its dts has no reason to set the interrupt-map. In that case, if I fully remove 'interrupt-map' in the dtsi, dtbs_check will not be happy. Indeed, a required property is missing. Also, having the full table containing the 8 items with the correct GIC interrupt number and the correct order could help a user to route the GPIO line to one of those 8 items. The '0' field use as interrupt source matches the registers reset value of the irq-mux controller. With that in mind, do you still think that I should reduce this table? Best regards, Hervé