* [PATCH 1/5] arm64: dts: rk3399-pinephone-pro: Add light/proximity sensor support
2025-09-21 6:41 [PATCH 0/5] Upstreaming Pinephone Pro Patches Rudraksha Gupta via B4 Relay
@ 2025-09-21 6:41 ` Rudraksha Gupta via B4 Relay
2025-09-21 6:41 ` [PATCH 2/5] arm64: dts: rk3399-pinephone-pro: Add accelerometer " Rudraksha Gupta via B4 Relay
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Rudraksha Gupta via B4 Relay @ 2025-09-21 6:41 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
Rudraksha Gupta, Ondrej Jirman
From: Ondrej Jirman <megi@xff.cz>
Pinephone Pro uses STK3311
Signed-off-by: Ondrej Jirman <megi@xff.cz>
Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
---
.../boot/dts/rockchip/rk3399-pinephone-pro.dts | 23 ++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index 6f97e57f36f5599f4027a0f3db98bcbc69cef5e5..7d1257a3f2e0cbdc65a810062ecd5117f9f5b687 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -520,6 +520,17 @@ touchscreen@14 {
touchscreen-size-x = <720>;
touchscreen-size-y = <1440>;
};
+
+ light-sensor@48 {
+ compatible = "sensortek,stk3311";
+ reg = <0x48>;
+ interrupt-parent = <&gpio4>;
+ interrupts = <RK_PD3 IRQ_TYPE_EDGE_FALLING>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&stk3311_int>;
+ vdd-supply = <&vcc_3v0>;
+ leda-supply = <&vcc_3v0>;
+ };
};
&i2c4 {
@@ -689,6 +700,18 @@ vcc1v8_codec_en: vcc1v8-codec-en {
};
};
+ stk3311 {
+ stk3311_int: stk3311-int {
+ rockchip,pins = <4 RK_PD3 RK_FUNC_GPIO &pcfg_input_pull_up>;
+ };
+ };
+
+ usb-typec {
+ vcc5v0_typec_en: vcc5v0_typec_en {
+ rockchip,pins = <0 RK_PA6 RK_FUNC_GPIO &pcfg_pull_up>;
+ };
+ };
+
wireless-bluetooth {
bt_wake_pin: bt-wake-pin {
rockchip,pins = <2 RK_PD2 RK_FUNC_GPIO &pcfg_pull_none>;
--
2.51.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/5] arm64: dts: rk3399-pinephone-pro: Add accelerometer sensor support
2025-09-21 6:41 [PATCH 0/5] Upstreaming Pinephone Pro Patches Rudraksha Gupta via B4 Relay
2025-09-21 6:41 ` [PATCH 1/5] arm64: dts: rk3399-pinephone-pro: Add light/proximity sensor support Rudraksha Gupta via B4 Relay
@ 2025-09-21 6:41 ` Rudraksha Gupta via B4 Relay
2025-09-21 6:41 ` [PATCH 3/5] arm64: dts: rk3399-pinephone-pro: Add magnetometer " Rudraksha Gupta via B4 Relay
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Rudraksha Gupta via B4 Relay @ 2025-09-21 6:41 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
Rudraksha Gupta, Ondrej Jirman
From: Ondrej Jirman <megi@xff.cz>
Pinephone Pro uses mpu6500.
Signed-off-by: Ondrej Jirman <megi@xff.cz>
Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index 7d1257a3f2e0cbdc65a810062ecd5117f9f5b687..da7ce905152269436410b959be937e07c23772b2 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -544,7 +544,13 @@ mpu6500@68 {
reg = <0x68>;
interrupt-parent = <&gpio1>;
interrupts = <RK_PC6 IRQ_TYPE_LEVEL_LOW>;
+ vdd-supply = <&vcc_1v8>;
vddio-supply = <&vcc_1v8>;
+
+ mount-matrix =
+ "1", "0", "0",
+ "0", "-1", "0",
+ "0", "0", "1";
};
};
--
2.51.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/5] arm64: dts: rk3399-pinephone-pro: Add magnetometer sensor support
2025-09-21 6:41 [PATCH 0/5] Upstreaming Pinephone Pro Patches Rudraksha Gupta via B4 Relay
2025-09-21 6:41 ` [PATCH 1/5] arm64: dts: rk3399-pinephone-pro: Add light/proximity sensor support Rudraksha Gupta via B4 Relay
2025-09-21 6:41 ` [PATCH 2/5] arm64: dts: rk3399-pinephone-pro: Add accelerometer " Rudraksha Gupta via B4 Relay
@ 2025-09-21 6:41 ` Rudraksha Gupta via B4 Relay
2025-09-21 6:41 ` [PATCH 4/5] arm64: dts: rk3399-pinephone-pro: Add mount-matrix for magnetometer Rudraksha Gupta via B4 Relay
2025-09-21 6:41 ` [PATCH 5/5] arm64: dts: rk3399-pinephone-pro: Fix voltage threshold for volume down key Rudraksha Gupta via B4 Relay
4 siblings, 0 replies; 6+ messages in thread
From: Rudraksha Gupta via B4 Relay @ 2025-09-21 6:41 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
Rudraksha Gupta, Ondrej Jirman
From: Ondrej Jirman <megi@xff.cz>
Pinephone Pro uses AF8133J.
Signed-off-by: Ondrej Jirman <megi@xff.cz>
Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index da7ce905152269436410b959be937e07c23772b2..8ff64004b0a6e3b472077516ab360c29852d7c9f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -554,6 +554,16 @@ mpu6500@68 {
};
};
+&i2c4 {
+ af8133j: compass@1c {
+ compatible = "voltafield,af8133j";
+ reg = <0x1c>;
+ reset-gpios = <&gpio1 RK_PA1 GPIO_ACTIVE_LOW>;
+ avdd-supply = <&vcc_3v0>;
+ dvdd-supply = <&vcc_1v8>;
+ };
+};
+
&io_domains {
bt656-supply = <&vcc1v8_dvp>;
audio-supply = <&vcca1v8_codec>;
--
2.51.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 4/5] arm64: dts: rk3399-pinephone-pro: Add mount-matrix for magnetometer
2025-09-21 6:41 [PATCH 0/5] Upstreaming Pinephone Pro Patches Rudraksha Gupta via B4 Relay
` (2 preceding siblings ...)
2025-09-21 6:41 ` [PATCH 3/5] arm64: dts: rk3399-pinephone-pro: Add magnetometer " Rudraksha Gupta via B4 Relay
@ 2025-09-21 6:41 ` Rudraksha Gupta via B4 Relay
2025-09-21 6:41 ` [PATCH 5/5] arm64: dts: rk3399-pinephone-pro: Fix voltage threshold for volume down key Rudraksha Gupta via B4 Relay
4 siblings, 0 replies; 6+ messages in thread
From: Rudraksha Gupta via B4 Relay @ 2025-09-21 6:41 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
Rudraksha Gupta, Leonardo G. Trombetta
From: "Leonardo G. Trombetta" <lgtrombetta@gmx.com>
After experimenting with the magnetometer on the Pinephone Pro I found
out the mount-matrix currently reported by the AF8133J driver is just
the identity matrix (no rotation), which is wrong. It would seem to me
that there is currently no `mount-matrix` info and that's why the driver
reports a trivial answer. As far as I can tell from my tests, a 90
degree clockwise rotation in the XY plane would align it properly.
Signed-off-by: Leonardo G. Trombetta <lgtrombetta@gmx.com>
Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index 8ff64004b0a6e3b472077516ab360c29852d7c9f..9442ca4c9ae47d639ed6139c370bacf1bffa65b6 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -561,6 +561,11 @@ af8133j: compass@1c {
reset-gpios = <&gpio1 RK_PA1 GPIO_ACTIVE_LOW>;
avdd-supply = <&vcc_3v0>;
dvdd-supply = <&vcc_1v8>;
+
+ mount-matrix =
+ "0", "1", "0",
+ "-1", "0", "0",
+ "0", "0", "1";
};
};
--
2.51.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 5/5] arm64: dts: rk3399-pinephone-pro: Fix voltage threshold for volume down key
2025-09-21 6:41 [PATCH 0/5] Upstreaming Pinephone Pro Patches Rudraksha Gupta via B4 Relay
` (3 preceding siblings ...)
2025-09-21 6:41 ` [PATCH 4/5] arm64: dts: rk3399-pinephone-pro: Add mount-matrix for magnetometer Rudraksha Gupta via B4 Relay
@ 2025-09-21 6:41 ` Rudraksha Gupta via B4 Relay
4 siblings, 0 replies; 6+ messages in thread
From: Rudraksha Gupta via B4 Relay @ 2025-09-21 6:41 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
Rudraksha Gupta, Ondrej Jirman
From: Ondrej Jirman <megi@xff.cz>
U-Boot and Linux use different algorithms for determining voltage ranges
for comparison. Pick value that will work with both.
Signed-off-by: Ondrej Jirman <megi@xff.cz>
Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index 9442ca4c9ae47d639ed6139c370bacf1bffa65b6..82e29e547fe25ea0c7fa681813514da6e06ecacd 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -46,7 +46,7 @@ button-up {
button-down {
label = "Volume Down";
linux,code = <KEY_VOLUMEDOWN>;
- press-threshold-microvolt = <600000>;
+ press-threshold-microvolt = <400000>;
};
};
--
2.51.0
^ permalink raw reply related [flat|nested] 6+ messages in thread