devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] ASoC: tas2781: Correct the wrong description and register address on tas2781
@ 2025-09-20  6:20 Baojun Xu
  2025-09-22  8:15 ` Mark Brown
  0 siblings, 1 reply; 3+ messages in thread
From: Baojun Xu @ 2025-09-20  6:20 UTC (permalink / raw)
  To: broonie
  Cc: tiwai, andriy.shevchenko, 13916275206, alsa-devel, shenghao-ding,
	baojun.xu, linux-sound, linux-kernel, lgirdwood, robh, krzk+dt,
	conor+dt, devicetree, k-yi, henry.lo, robinchen, jesse-ji,
	will-wang, jim.shil, toastcheng, chinkaiting

Correct the wrong description for TAS257X. Combined TAS5825 with TAS2563,
as they use the same register address and number.
Correct the register address and number for TAS5827.

Fixes: 7095d688de38 ("ASoC: tas2781: Add tas2118, tas2x20, tas5825 support")
Signed-off-by: Baojun Xu <baojun.xu@ti.com>
---
 .../devicetree/bindings/sound/ti,tas2781.yaml | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
index 011211112be4..bd00afa47d62 100644
--- a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
+++ b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
@@ -11,11 +11,13 @@ maintainers:
   - Shenghao Ding <shenghao-ding@ti.com>
 
 description: |
-  The TAS2118/TAS2X20/TAS257x is mono, digital input Class-D audio
+  The TAS2118/TAS2X20 is mono, digital input Class-D audio
   amplifier optimized for efficiently driving high peak power into
   small loudspeakers.
-  Integrated speaker voltage and current sense provides for
-  real time monitoring of loudspeaker behavior.
+  The TAS257x is mono, digital input Class-D audio amplifier optimized
+  for efficiently driving high peak power into small loudspeakers.
+  Integrated speaker voltage and current sense provides for real time
+  monitoring of loudspeaker behavior.
   The TAS2563/TAS2781 is a mono, digital input Class-D audio
   amplifier optimized for efficiently driving high peak power into
   small loudspeakers. An integrated on-chip DSP supports Texas
@@ -25,9 +27,7 @@ description: |
   The TAS5825/TAS5827 is a stereo, digital input Class-D audio
   amplifier optimized for efficiently driving high peak power into
   small loudspeakers. An integrated on-chip DSP supports Texas
-  Instruments Smart Amp speaker protection algorithm. The
-  integrated speaker voltage and current sense provides for real time
-  monitoring of loudspeaker behavior.
+  Instruments Smart Amp speaker protection algorithm.
 
   Specifications about the audio amplifier can be found at:
     https://www.ti.com/lit/gpn/tas2120
@@ -131,6 +131,7 @@ allOf:
           contains:
             enum:
               - ti,tas2563
+              - ti,tas5825
     then:
       properties:
         reg:
@@ -181,15 +182,14 @@ allOf:
         compatible:
           contains:
             enum:
-              - ti,tas5825
               - ti,tas5827
     then:
       properties:
         reg:
-          maxItems: 4
+          maxItems: 6
           items:
-            minimum: 0x4c
-            maximum: 0x4f
+            minimum: 0x60
+            maximum: 0x65
 
 additionalProperties: false
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] ASoC: tas2781: Correct the wrong description and register address on tas2781
  2025-09-20  6:20 [PATCH v1] ASoC: tas2781: Correct the wrong description and register address on tas2781 Baojun Xu
@ 2025-09-22  8:15 ` Mark Brown
  2025-09-22  8:22   ` Takashi Iwai
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2025-09-22  8:15 UTC (permalink / raw)
  To: Baojun Xu
  Cc: tiwai, andriy.shevchenko, 13916275206, alsa-devel, shenghao-ding,
	linux-sound, linux-kernel, lgirdwood, robh, krzk+dt, conor+dt,
	devicetree, k-yi, henry.lo, robinchen, jesse-ji, will-wang,
	jim.shil, toastcheng, chinkaiting

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

On Sat, Sep 20, 2025 at 02:20:44PM +0800, Baojun Xu wrote:
> Correct the wrong description for TAS257X. Combined TAS5825 with TAS2563,
> as they use the same register address and number.
> Correct the register address and number for TAS5827.

This depends on commits in Takashi's tree so it needs to go via there:

Acked-by: Mark Brown <broonie@kernel.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] ASoC: tas2781: Correct the wrong description and register address on tas2781
  2025-09-22  8:15 ` Mark Brown
@ 2025-09-22  8:22   ` Takashi Iwai
  0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2025-09-22  8:22 UTC (permalink / raw)
  To: Mark Brown
  Cc: Baojun Xu, andriy.shevchenko, 13916275206, alsa-devel,
	shenghao-ding, linux-sound, linux-kernel, lgirdwood, robh,
	krzk+dt, conor+dt, devicetree, k-yi, henry.lo, robinchen,
	jesse-ji, will-wang, jim.shil, toastcheng, chinkaiting

On Mon, 22 Sep 2025 10:15:48 +0200,
Mark Brown wrote:
> 
> On Sat, Sep 20, 2025 at 02:20:44PM +0800, Baojun Xu wrote:
> > Correct the wrong description for TAS257X. Combined TAS5825 with TAS2563,
> > as they use the same register address and number.
> > Correct the register address and number for TAS5827.
> 
> This depends on commits in Takashi's tree so it needs to go via there:
> 
> Acked-by: Mark Brown <broonie@kernel.org>

OK, applied now to for-next branch.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-09-22  8:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-20  6:20 [PATCH v1] ASoC: tas2781: Correct the wrong description and register address on tas2781 Baojun Xu
2025-09-22  8:15 ` Mark Brown
2025-09-22  8:22   ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).