From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F9321E5213; Sat, 20 Sep 2025 11:33:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758368032; cv=none; b=pPBl51Ge3FpCIjjorxVdPd5V7KQ5YXV6cg7VXHs/kloqLYxYMh6UdaddSl2MedxIdFLtf3W/mCg+yKgfPk0MPvc03QvLh+9LwaVW0sZbOmFtjKph2y0b+wNcfzptVs+cQuH5MDecZdix6yhw9o0ticx+qLT040C/lCcPVudLH0M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758368032; c=relaxed/simple; bh=5oKaAyIfDbfN4oIwDxNdn4sdEmPGeHjHCUSfIsQsjCE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=V2nDU7zPYLWR3Wtp59clDkhz2iFTUxzpaKcmUXnYfi1qtamQsFyYd4ZfsIRpIKyvQOyvVuVyDtpuP9wqbFfUV5YanyoWFcR+Yun86EQsvkZ3iH4jAhwfU+dyUtZo6Ez7YlgkROJFILb3JgzUk0RYoUDsrnjxY8cx7tfbDHHpYEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p5MTR39o; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p5MTR39o" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2C0FC4CEEB; Sat, 20 Sep 2025 11:33:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758368031; bh=5oKaAyIfDbfN4oIwDxNdn4sdEmPGeHjHCUSfIsQsjCE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=p5MTR39oi36TPPP+ihRxqinyXWMj9xhV5AyizMmf2uNSTULMsJogoM1lcieBL8TuQ DrM7mxskvn8DOZ72bw/Dhd4xbNCRhPivl5jdzOu1VYKSQiW46wajMyYG4zuAJzx8r0 ojsvYHhI5K3SU6XNligZxEO3qwbSj/Pmf1uQnZq0nFzG8Pf1lvBR5Jv9MsPVKz10Io /KdQ80l8V6KlaaomtECJSo9jrjR+UlFLifsMHG7R/IwjYqgELV9udMrmzqdUchDu0k 9AVGl+9ng6svzm891NaPzUdb0W1DiJcgKF4MuLxt7qhAqiq5P6V9PNy98DW/mPAUmW 2afzVgtM87/XQ== Date: Sat, 20 Sep 2025 12:33:40 +0100 From: Jonathan Cameron To: Marius Cristea Cc: David Lechner , Nuno =?UTF-8?B?U8Oh?= , "Andy Shevchenko" , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley , , , , jdelvare@suse.com, linux@roeck-us.net, linux-hwmon@vger.kernel.org Subject: Re: [PATCH 0/2] Add support for Microchip EMC1812 Message-ID: <20250920123340.1b1d03be@jic23-huawei> In-Reply-To: <20250917-iio-emc1812-v1-0-0b1f74cea7ab@microchip.com> References: <20250917-iio-emc1812-v1-0-0b1f74cea7ab@microchip.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.50; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 17 Sep 2025 15:21:56 +0300 Marius Cristea wrote: > This is the iio driver for EMC1812/13/14/15/33 multichannel Low-Voltage > Remote Diode Sensor Family. The chips in the family have one internal > and different numbers of external channels, ranging from 1 (EMC1812) to > 4 channels (EMC1815). > Reading diodes in anti-parallel connection is supported by EMC1814, EMC1815 > and EMC1833. > > Current version of driver does not support interrupts, events and data > buffering. Hi Marius, For a temperature monitoring device like this, the opening question is always why not HWMON? There are various reasons we have temp sensors in IIO but mostly they are not described as being monitors and this one is. IIO may well be the right choice for this part, but good to lay out your reasoning and +CC the hwmon list and maintainers. There is an emc1403 driver already in hwmon, so perhaps compare and contrast with that. I've +CC Jean, Guenter and list to save sending a v2 just to do that. Jonathan > > Differences related to previous patch: > > v1: > - initial version. > > Signed-off-by: Marius Cristea > --- > Marius Cristea (2): > dt-bindings: iio: temperature: add support for EMC1812 > iio: temperature: add support for EMC1812 > > .../iio/temperature/microchip,emc1812.yaml | 223 ++++++ > MAINTAINERS | 7 + > drivers/iio/temperature/Kconfig | 10 + > drivers/iio/temperature/Makefile | 1 + > drivers/iio/temperature/emc1812.c | 792 +++++++++++++++++++++ > 5 files changed, 1033 insertions(+) > --- > base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494 > change-id: 20250805-iio-emc1812-e666183b07b5 > > Best regards,