Re: [PATCH net-next v13 13/18] net: phy: marvell10g: Support SFP through phy_port

Maxime Chevallier
2025-09-24T03:55:00Z

On 24/09/2025 06:54, Jakub Kicinski wrote:
> On Sun, 21 Sep 2025 21:34:11 +0530 Maxime Chevallier wrote:
>> +/**
>> + * phy_port_restrict_mediums - Mask away some of the port's supported mediums
>> + * @port: The port to act upon
>> + * @mediums: A mask of mediums to support on the port
>> + *
>> + * This helper allows removing some mediums from a port's list of supported
>> + * mediums, which occurs once we have enough information about the port to
>> + * know its nature.
>> + *
>> + * Returns 0 if the change was donne correctly, a negative value otherwise.
>
> kdoc likes colons after return so:
>
> Returns 0 -> Return: 0
>
> sorry for only providing an automated nit pick..

It's OK, the series no longer applies with Russell's sfp_module_caps
series being here, so a new version is due anyway.

Russell, I missed this series of yours as I wasn't available at all at
that time, but as this phy_port series has been in the pipe for quite a
while, and you commented on the used of sfp_parse_support et.al. that
was being replaced, I'd have appreciated to be in CC :(

Given my schedule, next iteration is probably going to be for the next
cycle anyway so no harm :)

Thanks,

Maxime

>
>> + */
>> +int phy_port_restrict_mediums(struct phy_port *port, unsigned long mediums)