Re: [PATCH net-next v13 13/18] net: phy: marvell10g: Support SFP through phy_port

Jakub Kicinski
2025-09-24T01:24:32Z

On Sun, 21 Sep 2025 21:34:11 +0530 Maxime Chevallier wrote:
> +/**
> + * phy_port_restrict_mediums - Mask away some of the port's supported mediums
> + * @port: The port to act upon
> + * @mediums: A mask of mediums to support on the port
> + *
> + * This helper allows removing some mediums from a port's list of supported
> + * mediums, which occurs once we have enough information about the port to
> + * know its nature.
> + *
> + * Returns 0 if the change was donne correctly, a negative value otherwise.

kdoc likes colons after return so:

Returns 0 -> Return: 0

sorry for only providing an automated nit pick..

> + */
> +int phy_port_restrict_mediums(struct phy_port *port, unsigned long mediums)
--
pw-bot: cr