From: Rob Herring <robh@kernel.org>
To: Dzmitry Sankouski <dsankouski@gmail.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>, Lee Jones <lee@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v3 1/3] dt-bindings: max77705: add interrupt-controller node
Date: Mon, 22 Sep 2025 10:30:45 -0500 [thread overview]
Message-ID: <20250922153045.GA4143633-robh@kernel.org> (raw)
In-Reply-To: <20250912-starqltechn-correct_max77705_nodes-v3-1-4ce9f694ecd9@gmail.com>
On Fri, Sep 12, 2025 at 07:47:01PM +0300, Dzmitry Sankouski wrote:
> Add interrupt-controller node, because it has dedicated interrupt source
> register, to determine which sub device triggered an interrupt.
The subject and commit msg are wrong. You aren't adding a node.
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
> Documentation/devicetree/bindings/mfd/maxim,max77705.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml b/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml
> index 0ec89f0adc64..d265c8213a08 100644
> --- a/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml
> +++ b/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml
> @@ -26,6 +26,18 @@ properties:
> interrupts:
> maxItems: 1
>
> + interrupt-controller:
> + description:
> + The driver implements an interrupt controller for the sub devices.
> + The interrupt number mapping is as follows
> + 0 - charger
> + 1 - topsys
> + 2 - fuelgauge
> + 3 - usb type-c management block.
> +
> + '#interrupt-cells':
> + const: 1
> +
> haptic:
> type: object
> additionalProperties: false
> @@ -120,8 +132,10 @@ examples:
> reg = <0x66>;
> interrupt-parent = <&pm8998_gpios>;
> interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-controller;
> pinctrl-0 = <&chg_int_default>;
> pinctrl-names = "default";
> + #interrupt-cells = <1>;
>
> leds {
> compatible = "maxim,max77705-rgb";
>
> --
> 2.39.5
>
next prev parent reply other threads:[~2025-09-22 15:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 16:47 [PATCH v3 0/3] starqltechn: fix max77705 device irqs Dzmitry Sankouski
2025-09-12 16:47 ` [PATCH v3 1/3] dt-bindings: max77705: add interrupt-controller node Dzmitry Sankouski
2025-09-15 7:49 ` Konrad Dybcio
2025-09-15 15:46 ` Dzmitry Sankouski
2025-09-25 13:11 ` Konrad Dybcio
2025-09-25 19:27 ` Dzmitry Sankouski
2025-09-22 15:30 ` Rob Herring [this message]
2025-09-12 16:47 ` [PATCH v3 2/3] arm64: dts: qcom: sdm845-starqltechn: remove (address|size)-cells Dzmitry Sankouski
2025-09-15 7:50 ` Konrad Dybcio
2025-09-12 16:47 ` [PATCH v3 3/3] arch: arm64: dts: qcom: sdm845-starqltechn: fix max77705 interrupts Dzmitry Sankouski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250922153045.GA4143633-robh@kernel.org \
--to=robh@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dsankouski@gmail.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).