From: Rob Herring <robh@kernel.org>
To: Max Shevchenko <wctrl@proton.me>
Cc: Sean Wang <sean.wang@mediatek.com>, Vinod Koul <vkoul@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Long Cheng <long.cheng@mediatek.com>,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: dma: mediatek,uart-dma: drop mediatek,dma-33bits property
Date: Mon, 22 Sep 2025 15:47:56 -0500 [thread overview]
Message-ID: <20250922204756.GA1294776-robh@kernel.org> (raw)
In-Reply-To: <20250921-uart-apdma-v1-1-107543c7102c@proton.me>
On Sun, Sep 21, 2025 at 02:03:40PM +0300, Max Shevchenko wrote:
> Many newer SoCs support more than 33 bits for DMA.
> Drop the property in order to switch to the platform data.
>
> The reference SoCs were taken from the downstream kernel (6.6) for
> the MT6991 SoC.
>
> Signed-off-by: Max Shevchenko <wctrl@proton.me>
> ---
> Documentation/devicetree/bindings/dma/mediatek,uart-dma.yaml | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/mediatek,uart-dma.yaml b/Documentation/devicetree/bindings/dma/mediatek,uart-dma.yaml
> index dab468a88942d694525aa391f695c44d192f0c42..9dfdfe81af7edbe3540e4b757547a5d5e6ae810c 100644
> --- a/Documentation/devicetree/bindings/dma/mediatek,uart-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/mediatek,uart-dma.yaml
> @@ -22,12 +22,14 @@ properties:
> - items:
> - enum:
> - mediatek,mt2712-uart-dma
> - - mediatek,mt6795-uart-dma
> - mediatek,mt8365-uart-dma
> - mediatek,mt8516-uart-dma
> - const: mediatek,mt6577-uart-dma
> - enum:
> - - mediatek,mt6577-uart-dma
> + - mediatek,mt6577-uart-dma # 32 bits
> + - mediatek,mt6795-uart-dma # 33 bits
Unless all existing s/w supported mediatek,mt6795-uart-dma, you just
broke this platform which was relying on the fallback compatible.
> + - mediatek,mt6779-uart-dma # 34 bits
> + - mediatek,mt6985-uart-dma # 35 bits
>
> reg:
> minItems: 1
> @@ -56,10 +58,6 @@ properties:
> Number of virtual channels of the UART APDMA controller
> maximum: 16
>
> - mediatek,dma-33bits:
> - type: boolean
> - description: Enable 33-bits UART APDMA support
If this is in use, you need to mark it 'deprecated' instead.
> -
> required:
> - compatible
> - reg
> @@ -116,7 +114,6 @@ examples:
> dma-requests = <12>;
> clocks = <&pericfg CLK_PERI_AP_DMA>;
> clock-names = "apdma";
> - mediatek,dma-33bits;
> #dma-cells = <1>;
> };
> };
>
> --
> 2.51.0
>
next prev parent reply other threads:[~2025-09-22 20:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-21 11:03 [PATCH 0/3] Rewrite MediaTek UART APDMA driver to support more than 33 bits Max Shevchenko via B4 Relay
2025-09-21 11:03 ` [PATCH 1/3] dt-bindings: dma: mediatek,uart-dma: drop mediatek,dma-33bits property Max Shevchenko via B4 Relay
2025-09-22 20:47 ` Rob Herring [this message]
2025-09-23 12:17 ` Max Shevchenko
2025-09-21 11:03 ` [PATCH 2/3] dmaengine: mediatek: mtk-uart-apdma: support more than 33 bits for DMA bitmask Max Shevchenko via B4 Relay
2025-09-22 10:42 ` AngeloGioacchino Del Regno
2025-09-21 11:03 ` [PATCH 3/3] arm64: dts: mediatek: mt6795: drop mediatek,dma-33bits property Max Shevchenko via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250922204756.GA1294776-robh@kernel.org \
--to=robh@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=long.cheng@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@mediatek.com \
--cc=vkoul@kernel.org \
--cc=wctrl@proton.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).