From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFC9930EF6E for ; Tue, 23 Sep 2025 05:31:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758605469; cv=none; b=ncVczeqKnO/8MoDJDslJk69A6I3a1n+E/pLpXjW0eJZ+Q/trsbF1BKvPPQStfkEZ9kF65Frg/+PMrX1S6YGF92nECQ8nFQamROy4akD95cB7UFH+1LqsEckJ8IGIqX5triLXP5dl7m6p097sRb2APIKFM5VR4AVZrkF1wnNmNd4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758605469; c=relaxed/simple; bh=UlEmTEBxCQKvli5sclXOy+aXQ3rK6Vt3k+Kr6iD12k0=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=QSGIHFx9+FcPPjL8bDoTCs+1MrjfD9eZhgAXsU/Ub1d99RvqLP5bT+HEolkCitG4Qtap2kWyO6lfsI22I4ZVGx/l8G/ND1K/ygAHj+kDFLLWD2rYQSN2DZ1Wy0hLNbGeZxEkT2twMpnnZBV5CTupGwUQJZbo7Qcju0TMHmg0J4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=agPiiTZl; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="agPiiTZl" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-4060b4b1200so237985f8f.3 for ; Mon, 22 Sep 2025 22:31:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758605465; x=1759210265; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=uWNVfdZNe2vnmg1ugAUULGSoetsURECd1is6oN3vOGo=; b=agPiiTZljefaKJCHVrwlFl36Bmf2sj35Jeq9CaZnNWYELSYzTryqiZbjtsO3NwvF9D HjsVG1a5b353eWUQPvYjYttNq+sne5QU+UZhDPdzVmiByqLCHdibvWmx/7Xcx4n/u9hN RiufV2Q5Z6muGR0Exl7Sdh6zsch+s8g3yFmItQUZOBb7gqI0G29y+d72MX9rhpsART40 +cUslNJpFTqcd2seThBVUG2NcHkI1KYrqhEHO+09h4eRc/yeqVa+1fdl9atq7C+3uQJF 5pZjrNq528sASlTaf18med7dwzP7AfY3gLDHzwfHqSHWAD512BGP1g/Ii3hWtOyOL0tN hPww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758605465; x=1759210265; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uWNVfdZNe2vnmg1ugAUULGSoetsURECd1is6oN3vOGo=; b=eRDJXplByo324G57yedwj07wRmMB+3ctg5BdcwNgqvwd/wjp8wRnAtlEiV0XfIZ+m5 AK5lZsT+CVEfLa7DQbrytM6iS1+K+rbH6URfHAN3TYiDx5bxcz5IQ0Q2C/wfxlxzRnon g14yryh+4DfnlnRwmft3nwponcTdy2V4sARd/YsswkKpF37OKEKW5S0nuxnETA/zFeyL fXWAgtCTIrnXRgIv/nyDppUg2hr/a1/LTxSPnyrgvc3pOqEb7+5r8/g30I8ZwlnjPxdA Xc/f+lTTRX08ijAE1cZEGxlsXSwFYo9t8JmLoxw9ZGF+ZIGRZ6M6kUz+ZzsilSK2+Pqr 5OiQ== X-Forwarded-Encrypted: i=1; AJvYcCVEySB5Cc76PVphSkrudK87uCdlxKXRaz1CDJ98/fYq6dkhSIeKuldpb+BKAUsH6+GUr0AVQsK34pyj@vger.kernel.org X-Gm-Message-State: AOJu0YwQL72nN0oEZNnG9NmmobKj95zHWxkBSkx6yFWFbbhXrN3eG7vU osREenNMH6IMtiFGuKcp+9iyNo3h+Jl5HFluXRFYdbtag6FZLuCEQLSCMyqQSHVj5AU= X-Gm-Gg: ASbGncvbDjrImWJttjkwm0J2boLt4RcUshteXijxxnryorHrOeigLJLroNzvHbTXBPX r81oDIdhprIV4x0hue9FfzAnY8xLF0OsGMs64IwiIPrGaAkOx6/MTOUiQ49+Ay8fe8CI5zKWIf9 +vkiTFfaoXCONHWmeDmZSxM8DtD2nPzzwd7tG6oW+/ya+bhjds0yY4cvVP/1NRONghd+zJHFmDb hinrFvQqckZjlvwcKuhp+RmstPox9dhxfDVDcw+JdjYAntuFgStdzYndU3jQOWf75shp6rRAhBy MHcUz0yT9aGZNCrM2aW2WxkagfN2xTQ9ObppHcLtURHl2Gne8QGQv5C0veKuSQeRAh54MYjkh+C l6i6hokYKF73DyOi7nYtEFA1SiHLI X-Google-Smtp-Source: AGHT+IH9N4ZKtf2QZGrRBXmYOhVuZlTRd+48ApBr4A1D93zo1NkZQS0UX41zNNwFEY5f/LBcpzC0tw== X-Received: by 2002:a05:6000:2282:b0:3ec:6259:5095 with SMTP id ffacd0b85a97d-405c49a2556mr826539f8f.12.1758605464888; Mon, 22 Sep 2025 22:31:04 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3ee0fbfedd6sm22741022f8f.60.2025.09.22.22.31.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Sep 2025 22:31:04 -0700 (PDT) Date: Tue, 23 Sep 2025 08:31:00 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Marius Cristea , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Marius Cristea Subject: Re: [PATCH 2/2] iio: temperature: add support for EMC1812 Message-ID: <202509231015.K3B5TN1Q-lkp@intel.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250917-iio-emc1812-v1-2-0b1f74cea7ab@microchip.com> Hi Marius, kernel test robot noticed the following build warnings: url: https://github.com/intel-lab-lkp/linux/commits/Marius-Cristea/dt-bindings-iio-temperature-add-support-for-EMC1812/20250917-202833 base: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494 patch link: https://lore.kernel.org/r/20250917-iio-emc1812-v1-2-0b1f74cea7ab%40microchip.com patch subject: [PATCH 2/2] iio: temperature: add support for EMC1812 config: powerpc64-randconfig-r071-20250922 (https://download.01.org/0day-ci/archive/20250923/202509231015.K3B5TN1Q-lkp@intel.com/config) compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project cafc064fc7a96b3979a023ddae1da2b499d6c954) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202509231015.K3B5TN1Q-lkp@intel.com/ smatch warnings: drivers/iio/temperature/emc1812.c:645 emc1812_parse_fw_config() warn: passing zero to 'dev_err_probe' vim +/dev_err_probe +645 drivers/iio/temperature/emc1812.c 56c661fffa897b2 Marius Cristea 2025-09-17 611 static int emc1812_parse_fw_config(struct emc1812_priv *priv, struct device *dev, 56c661fffa897b2 Marius Cristea 2025-09-17 612 int device_nr_channels) 56c661fffa897b2 Marius Cristea 2025-09-17 613 { 56c661fffa897b2 Marius Cristea 2025-09-17 614 unsigned int reg_nr, iio_idx, tmp; 56c661fffa897b2 Marius Cristea 2025-09-17 615 int ret; 56c661fffa897b2 Marius Cristea 2025-09-17 616 56c661fffa897b2 Marius Cristea 2025-09-17 617 priv->apdd_en = device_property_read_bool(dev, "microchip,enable-anti-parallel"); 56c661fffa897b2 Marius Cristea 2025-09-17 618 priv->recd12_en = device_property_read_bool(dev, "microchip,parasitic-res-on-channel1-2"); 56c661fffa897b2 Marius Cristea 2025-09-17 619 priv->recd34_en = device_property_read_bool(dev, "microchip,parasitic-res-on-channel3-4"); 56c661fffa897b2 Marius Cristea 2025-09-17 620 56c661fffa897b2 Marius Cristea 2025-09-17 621 memset32(priv->beta_values, 16, ARRAY_SIZE(priv->beta_values)); 56c661fffa897b2 Marius Cristea 2025-09-17 622 device_property_read_u32(dev, "microchip,beta1", &priv->beta_values[0]); 56c661fffa897b2 Marius Cristea 2025-09-17 623 device_property_read_u32(dev, "microchip,beta2", &priv->beta_values[1]); 56c661fffa897b2 Marius Cristea 2025-09-17 624 if (priv->beta_values[0] > 16 || priv->beta_values[1] > 16) 56c661fffa897b2 Marius Cristea 2025-09-17 625 return dev_err_probe(dev, -EINVAL, "Invalid beta value\n"); 56c661fffa897b2 Marius Cristea 2025-09-17 626 56c661fffa897b2 Marius Cristea 2025-09-17 627 priv->num_channels = device_get_child_node_count(dev) + 1; 56c661fffa897b2 Marius Cristea 2025-09-17 628 56c661fffa897b2 Marius Cristea 2025-09-17 629 if (priv->num_channels > priv->chip->phys_channels) 56c661fffa897b2 Marius Cristea 2025-09-17 630 return dev_err_probe(dev, -E2BIG, "More channels than the chip supports\n"); 56c661fffa897b2 Marius Cristea 2025-09-17 631 56c661fffa897b2 Marius Cristea 2025-09-17 632 priv->iio_chan[0] = EMC1812_CHAN(0, 0, EMC1812_CH_ADDR(0)); 56c661fffa897b2 Marius Cristea 2025-09-17 633 56c661fffa897b2 Marius Cristea 2025-09-17 634 priv->labels[0] = "internal_diode"; 56c661fffa897b2 Marius Cristea 2025-09-17 635 iio_idx = 1; 56c661fffa897b2 Marius Cristea 2025-09-17 636 device_for_each_child_node_scoped(dev, child) { 56c661fffa897b2 Marius Cristea 2025-09-17 637 ret = fwnode_property_read_u32(child, "reg", ®_nr); 56c661fffa897b2 Marius Cristea 2025-09-17 638 if (ret || reg_nr >= priv->chip->phys_channels) 56c661fffa897b2 Marius Cristea 2025-09-17 639 return dev_err_probe(dev, -EINVAL, 56c661fffa897b2 Marius Cristea 2025-09-17 640 "The index of the channels does not match the chip\n"); 56c661fffa897b2 Marius Cristea 2025-09-17 641 56c661fffa897b2 Marius Cristea 2025-09-17 642 ret = fwnode_property_read_u32(child, "microchip,ideality-factor", &tmp); 56c661fffa897b2 Marius Cristea 2025-09-17 643 if (ret == 0) { 56c661fffa897b2 Marius Cristea 2025-09-17 644 if (tmp < 8 || tmp > 63) 56c661fffa897b2 Marius Cristea 2025-09-17 @645 return dev_err_probe(dev, ret, "Invalid ideality value\n"); Change ret to -EINVAL. 56c661fffa897b2 Marius Cristea 2025-09-17 646 priv->ideality_value[reg_nr - 1] = tmp; 56c661fffa897b2 Marius Cristea 2025-09-17 647 } else { 56c661fffa897b2 Marius Cristea 2025-09-17 648 priv->ideality_value[reg_nr - 1] = 18; 56c661fffa897b2 Marius Cristea 2025-09-17 649 } 56c661fffa897b2 Marius Cristea 2025-09-17 650 56c661fffa897b2 Marius Cristea 2025-09-17 651 fwnode_property_read_string(child, "label", &priv->labels[reg_nr]); 56c661fffa897b2 Marius Cristea 2025-09-17 652 56c661fffa897b2 Marius Cristea 2025-09-17 653 priv->iio_chan[iio_idx++] = EMC1812_CHAN(reg_nr, reg_nr, EMC1812_CH_ADDR(reg_nr)); 56c661fffa897b2 Marius Cristea 2025-09-17 654 } 56c661fffa897b2 Marius Cristea 2025-09-17 655 56c661fffa897b2 Marius Cristea 2025-09-17 656 return 0; 56c661fffa897b2 Marius Cristea 2025-09-17 657 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki