devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: broadcom: bcm2712: Enable RNG
@ 2025-09-24  9:01 Peter Robinson
  2025-09-24 10:47 ` Stefan Wahren
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Robinson @ 2025-09-24  9:01 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Florian Fainelli,
	Broadcom internal kernel review list, Dave Stevenson,
	Stefan Wahren, Phil Elwell, Andrea della Porta, devicetree,
	linux-rpi-kernel, linux-arm-kernel
  Cc: Peter Robinson

The RNG is the same IP as in the bcm2711 so add the
device tree block to enable the device.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
index 4cd51d80d40d0..6976a88c262f4 100644
--- a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
@@ -226,6 +226,12 @@ system_timer: timer@7c003000 {
 			clock-frequency = <1000000>;
 		};
 
+		random: rng@7d208000 {
+			compatible = "brcm,bcm2711-rng200";
+			reg = <0x7d208000 0x28>;
+			status = "okay";
+		};
+
 		mailbox: mailbox@7c013880 {
 			compatible = "brcm,bcm2835-mbox";
 			reg = <0x7c013880 0x40>;
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: broadcom: bcm2712: Enable RNG
  2025-09-24  9:01 [PATCH] arm64: dts: broadcom: bcm2712: Enable RNG Peter Robinson
@ 2025-09-24 10:47 ` Stefan Wahren
  2025-09-24 10:53   ` Peter Robinson
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Wahren @ 2025-09-24 10:47 UTC (permalink / raw)
  To: Peter Robinson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Florian Fainelli, Broadcom internal kernel review list,
	Dave Stevenson, Phil Elwell, Andrea della Porta, devicetree,
	linux-rpi-kernel, linux-arm-kernel

Hi Peter,

Am 24.09.25 um 11:01 schrieb Peter Robinson:
> The RNG is the same IP as in the bcm2711 so add the
> device tree block to enable the device.
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>   arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
> index 4cd51d80d40d0..6976a88c262f4 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
> +++ b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
> @@ -226,6 +226,12 @@ system_timer: timer@7c003000 {
>   			clock-frequency = <1000000>;
>   		};
>   
> +		random: rng@7d208000 {
> +			compatible = "brcm,bcm2711-rng200";
> +			reg = <0x7d208000 0x28>;
> +			status = "okay";
> +		};
thank you for the patch. I know the order is already messed up, but 
could you please try to add it after uart10?
> +
>   		mailbox: mailbox@7c013880 {
>   			compatible = "brcm,bcm2835-mbox";
>   			reg = <0x7c013880 0x40>;


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: broadcom: bcm2712: Enable RNG
  2025-09-24 10:47 ` Stefan Wahren
@ 2025-09-24 10:53   ` Peter Robinson
  2025-09-24 10:58     ` Stefan Wahren
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Robinson @ 2025-09-24 10:53 UTC (permalink / raw)
  To: Stefan Wahren
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Florian Fainelli,
	Broadcom internal kernel review list, Dave Stevenson, Phil Elwell,
	Andrea della Porta, devicetree, linux-rpi-kernel,
	linux-arm-kernel

On Wed, 24 Sept 2025 at 11:48, Stefan Wahren <wahrenst@gmx.net> wrote:
>
> Hi Peter,
>
> Am 24.09.25 um 11:01 schrieb Peter Robinson:
> > The RNG is the same IP as in the bcm2711 so add the
> > device tree block to enable the device.
> >
> > Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> > ---
> >   arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 6 ++++++
> >   1 file changed, 6 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
> > index 4cd51d80d40d0..6976a88c262f4 100644
> > --- a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
> > +++ b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
> > @@ -226,6 +226,12 @@ system_timer: timer@7c003000 {
> >                       clock-frequency = <1000000>;
> >               };
> >
> > +             random: rng@7d208000 {
> > +                     compatible = "brcm,bcm2711-rng200";
> > +                     reg = <0x7d208000 0x28>;
> > +                     status = "okay";
> > +             };
> thank you for the patch. I know the order is already messed up, but
> could you please try to add it after uart10?

Sure, can you let me know the preferred ordering so I can understand
what we're aiming for overall?

> > +
> >               mailbox: mailbox@7c013880 {
> >                       compatible = "brcm,bcm2835-mbox";
> >                       reg = <0x7c013880 0x40>;
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: broadcom: bcm2712: Enable RNG
  2025-09-24 10:53   ` Peter Robinson
@ 2025-09-24 10:58     ` Stefan Wahren
  0 siblings, 0 replies; 4+ messages in thread
From: Stefan Wahren @ 2025-09-24 10:58 UTC (permalink / raw)
  To: Peter Robinson
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Florian Fainelli,
	Broadcom internal kernel review list, Dave Stevenson, Phil Elwell,
	Andrea della Porta, devicetree, linux-rpi-kernel,
	linux-arm-kernel

Hi Peter,

Am 24.09.25 um 12:53 schrieb Peter Robinson:
> On Wed, 24 Sept 2025 at 11:48, Stefan Wahren <wahrenst@gmx.net> wrote:
>> Hi Peter,
>>
>> Am 24.09.25 um 11:01 schrieb Peter Robinson:
>>> The RNG is the same IP as in the bcm2711 so add the
>>> device tree block to enable the device.
>>>
>>> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>>> ---
>>>    arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 6 ++++++
>>>    1 file changed, 6 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
>>> index 4cd51d80d40d0..6976a88c262f4 100644
>>> --- a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
>>> +++ b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
>>> @@ -226,6 +226,12 @@ system_timer: timer@7c003000 {
>>>                        clock-frequency = <1000000>;
>>>                };
>>>
>>> +             random: rng@7d208000 {
>>> +                     compatible = "brcm,bcm2711-rng200";
>>> +                     reg = <0x7d208000 0x28>;
>>> +                     status = "okay";
>>> +             };
>> thank you for the patch. I know the order is already messed up, but
>> could you please try to add it after uart10?
> Sure, can you let me know the preferred ordering so I can understand
> what we're aiming for overall?
Sure, all nodes with an unit address should be ordered ascending by unit 
address.

https://docs.kernel.org/devicetree/bindings/dts-coding-style.html
>
>>> +
>>>                mailbox: mailbox@7c013880 {
>>>                        compatible = "brcm,bcm2835-mbox";
>>>                        reg = <0x7c013880 0x40>;


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-09-24 10:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-24  9:01 [PATCH] arm64: dts: broadcom: bcm2712: Enable RNG Peter Robinson
2025-09-24 10:47 ` Stefan Wahren
2025-09-24 10:53   ` Peter Robinson
2025-09-24 10:58     ` Stefan Wahren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).