From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BCA02F60B6 for ; Fri, 26 Sep 2025 13:11:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758892295; cv=none; b=RmY25me6iBb8rp086Nuw+c6OyVXmlFQqmwBT44gJzM+zDgBuh+zOILevLPobXYImJuyQQId9/NmBZ2JBJe4b+TbJsd2Ap1r25F9Qdr4E0d3vD5YApq9T0R4R28hw9ociwaA3FkQF00ft1fmr92JbPOCnx9p9KmUVo2FOUZx8RxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758892295; c=relaxed/simple; bh=fN1yQSZa9dGNYApiBN9DJ0yzGqYY3io2zaEeifTv+AY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NsLt8+1qVmptgBUhQDUYKlPNjplwAvgYdui+N9Suvy4P6PI7VanYpkPkAgpcSVSKLU56M1KsAR7iaRU3ZrOUPaBzvhaJry0DcA5DR3JWCsDCd6HDSr/eKfsxq4cD+ruk/2mL/CQ9aX9GgGNx4IcrWFk9e88QQiR0KLU464/vLmk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=fbfy3VJj; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="fbfy3VJj" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-57d8ff3944dso2221493e87.3 for ; Fri, 26 Sep 2025 06:11:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1758892290; x=1759497090; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nuHd6eGYommvO3UskpqEqtJdP8+N3udV7UPBSp5lsjc=; b=fbfy3VJjC1yaYytPKZzTYRVoy+OCnUkOEtEIUZ3x3cYqigUyyXha5Va4UzDiOILmAI z/9bf24ITk1PxUsoK1WCTsDg7wY0GXAeUPCKIViGPcEP9BCiaDJ+LwEYvb6cDV8LIwkb D5w2rHp5jiXapkSCe1hEBuefH3fRV5/UiEHiY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758892290; x=1759497090; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nuHd6eGYommvO3UskpqEqtJdP8+N3udV7UPBSp5lsjc=; b=wv1ObPZP1IoNU732VqbWebxMH8PNpuqML6cksgYkQ6Uq/rUAQD5+8UHJ1P6TrUYWJv CnugyWOMzIx4SuD84Lh3kWhVOrQS/DBL+h82aOpnjusAFQdg7J3QxNVLmjce4Cor/suZ zdMIHfpiZc6qaLUiUtlonbJsUObnwxMAQN+Be1y9MqIR5Qw5gTNhenyngCvRYhnzfGby WcwkJl+NizGWH4DOBTWnnwoH4392omY1c3/RMrnWI9J5IOeEiG09gEaxG9Go+JNQEcBD U0X4EfJeKMotDyhCp8neKNVynZWBtw0jqjg1hI9Sc+uyAgS+Cl/IvWv8W8ML9IK3+i/j hl4w== X-Forwarded-Encrypted: i=1; AJvYcCUuwNBIOIoculu8Hb/fa6NjIGIi8mt2ngmFD55O0qSt4kKsoYL8HSexu5t5dY0PfomculxK3qw/NK9t@vger.kernel.org X-Gm-Message-State: AOJu0YzGA0wFN5Jiv6cFWIPgVoMOj7HG5Mrl3nxs4dv8dwbotWJcgflP Tg1ErK8SeYRrLMKXXvAw1hOFMtcttNjK3pQyrOQi9XXVsZ0CoZ9W5TAuehRN2Vv30Q== X-Gm-Gg: ASbGncu48WHRo69Dvz0DYe199JwIfON5etB6Pfw278Uqgn1FuD7iQghJc+hZHpDgHd7 gh/0TPxryXeuIpHWUaDQ1ED5xyJmXUjERx3AYiw+FAixEK5Qmh4ki1TV13ydYm5kPN1iHBHaCJ5 oUbONPcYRnOTPp+6X3pUpm8+vL5XZ/VjOvo/o6ChHjeYJrYd8uARAEfdCh63lZG2/BqUfNc2AQO q1oXNSTnsM00zhm4wVQ1Wzl/umH18enyOJi56p/XEv/D2z4pn4I7FVaxld5fAXRCPN1iD4vRkHQ 3Xluw4T4L5pD7lPYRAyyj+MVvwqnZ2/oKuQ+jFZbm8EjMn930dWIMnvn1eL7MmV6h0Mia1DoQ0Q r0wyfln56E19rGXF3B5dM6bdsVCDcY/n6g36C4WyvrJ90PtIATCb/iGTIz7NHq94iXhbaqASIqa J3S376Y6rFvZd3EzF6ecObBtc= X-Google-Smtp-Source: AGHT+IGBibbMbWnp4wsYYpcAZc4iOvKmHvOhd0/KxBOtu8sk83ypjF+oQ0w3P1LE9KQVYZ/8hnbPDg== X-Received: by 2002:a05:6512:61b1:b0:57c:2474:3743 with SMTP id 2adb3069b0e04-582d2f24dbfmr2344139e87.32.1758892290146; Fri, 26 Sep 2025 06:11:30 -0700 (PDT) Received: from ribalda.c.googlers.com (64.153.228.35.bc.googleusercontent.com. [35.228.153.64]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-58527c6b014sm123872e87.43.2025.09.26.06.11.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Sep 2025 06:11:29 -0700 (PDT) From: Ricardo Ribalda Date: Fri, 26 Sep 2025 13:11:25 +0000 Subject: [PATCH v3 01/12] media: uvcvideo: Always set default_value Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250926-uvc-orientation-v3-1-6dc2fa5b4220@chromium.org> References: <20250926-uvc-orientation-v3-0-6dc2fa5b4220@chromium.org> In-Reply-To: <20250926-uvc-orientation-v3-0-6dc2fa5b4220@chromium.org> To: Hans de Goede , Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski , "Rafael J. Wysocki" , Len Brown , Robert Moore , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, Ricardo Ribalda , stable@vger.kernel.org X-Mailer: b4 0.14.2 If the control does not support GET_DEF, the field default_value will be left uninitialized during queryctrl. Fixes: c0efd232929c ("V4L/DVB (8145a): USB Video Class driver") Cc: stable@vger.kernel.org Reviewed-by: Laurent Pinchart Reviewed-by: Hans de Goede Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c index 2905505c240c060e5034ea12d33b59d5702f2e1f..a869257e9b7c07eaa7d725d107bd1cb57d3c7377 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -1542,10 +1542,11 @@ static int __uvc_queryctrl_boundaries(struct uvc_video_chain *chain, return ret; } - if (ctrl->info.flags & UVC_CTRL_FLAG_GET_DEF) { + if (ctrl->info.flags & UVC_CTRL_FLAG_GET_DEF) v4l2_ctrl->default_value = uvc_mapping_get_s32(mapping, UVC_GET_DEF, uvc_ctrl_data(ctrl, UVC_CTRL_DATA_DEF)); - } + else + v4l2_ctrl->default_value = 0; switch (mapping->v4l2_type) { case V4L2_CTRL_TYPE_MENU: -- 2.51.0.536.g15c5d4f767-goog