From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CCD335950 for ; Fri, 26 Sep 2025 07:30:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758871808; cv=none; b=jk8gSYhwHmvzw1gyTM+PQacCgDVWVCZNu2uCeX4Z+jguYu0sW56u7tX4onLZX+Cu6jRPGDYZVtcQW6/9pISVb/LpR3y3wSL9oc4aGAiZqjXqB9cSQdXvLasC/jC2hrkkBx9FpCWufJzI+jfNNpr3eCN28lzOYH98b2kWYU0aYgg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758871808; c=relaxed/simple; bh=B9tSdkHs2Yg94R47L+fGUJTllZ1iYKjZrE7h+YiOBsE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=neZEYMpvaRgEFWi528jjCNnR7wZ0T9pm4gcVQSLvoDie/cvyFGiUTVC0Fuu+ODqtcNi+izaJubkSzRgV2IUhBBXYuvVpHKpc/ek16icVRGN/rRzgT3YG+2TuBvk11zyuQyJWpFwvHTKhC9ZMuUep967AJ9RA8dWhhN1T4koq1sY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D558smNv; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D558smNv" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-27eec33b737so8375615ad.1 for ; Fri, 26 Sep 2025 00:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758871806; x=1759476606; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Mm7nBZJ8GEby0mK5cxdZtoEeYLLJ3ejp8euQ7RZMF2I=; b=D558smNvNnZiUCj6F+E7/mOoa3zWkUoorW5QTbSA525Sf+XOWpuDN6erMd44WHk+cy SFOxYmGn+PfldUeVEbSf61xf3/CJ5vNOn60j8OK0/mwe9rGBAsqxVsY7oHh0Gzg3uRZP CQBEGfv0fcm1I6C9OPdJh3ZbdZ5xMbPZLlpvuXTtPepvrRx9xHkyrFYDibQldAclGOuz kK7G1870DmlwPJWcfzFEagUymqQ8HgQ48yW/1zctSJYMMDB7O1KODPa/WA4/3Z67nNFA q2+plW98tOfzgm0Og6jupSVu7uFm+9h4100+rPPEofjXLmSBf/8diYZbApNt2wZp9HqH TBXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758871806; x=1759476606; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Mm7nBZJ8GEby0mK5cxdZtoEeYLLJ3ejp8euQ7RZMF2I=; b=hnxgH07BKRLAT62oq3h3fli7jAAdacdAihOeq/InH0KQoAZ1IJqnxn9RZPFn1QjtiB ypzYAF2B+DZEvYRIV/fRGAEOANTz/D8zBfSt0M5/Q0eqWEszeaFBqDKODuCP4HReH+t5 XzALLbLe/NoW9nquZJap1ZAdejLD+Gkf8g2rtVNjNc54ij6iCKlRCEADTWmnsIvtrILE MDr3TwrSD4lpIRMqnhGkYSpjepz0lbsSxJJ6V5OC4rYT9KN8dnjzG1F61KlenMSr50ye EIBdBCVKBslxQDqx+7eZ/2w6a02fv316pa6PLJHmMoUWhJcluah1aA9+japUlbFqUBfC qmFA== X-Forwarded-Encrypted: i=1; AJvYcCV88w6HaDEfgGAnFO3g1r/cCxvSbysvOnXkD67RT1qW6eFfcdFAnaRTJOM+WpfEJEVxE9pof5j2yUKW@vger.kernel.org X-Gm-Message-State: AOJu0YzVHt+6KCeVHGbQiVWmGDHLcdm9t6CiFEDBFmkQ5w84rwwJNTpY g4mZWOkXaN11LfOiNsxjfgwPzoFWYXWMEXXU81ICNglpzZX/YG96idc/ X-Gm-Gg: ASbGncvlNamwki48KYtMio8OV4QtjK7HRWTMskpPR6roPcNIChJOA7IW08r/7JzmVU3 7/p7TBg+Em3ni3qymJycH31S0Of8fKUUW5apAbvqYp83HZyM+Y2/dd7JG9UrqNNWHHAu72KxJwA jTejjCNHv3iXYbbvmIppECv/TLfbsmCWT5mw6QlHOhk5fFr8rRrcbZA3CslJTQuBOX3qi+xhf3b IwOZHOkIfNbbdCAx31kK8LbrLHmZD2GMb2u8dFGtQ8aFJbwtGdtI0EJR6i+YgOWHw3BVOQ1FaLC ywyeduwcgRCdBRjlDJh6qgzPAIzOeSiBTYz7DdLXqsMD72NhOqtH7y+8Iv13TkTnT6XFRi4bjtO ijY2cynfmSlOXiJOONqi0 X-Google-Smtp-Source: AGHT+IGI+U3QK7iLuAmmvXRmiYoOumdYgGGFoBVB3R//J+qy9voB0vaTp3PbDWtHrr0QJs4yRB3UPg== X-Received: by 2002:a17:902:e54d:b0:24c:cb60:f6f0 with SMTP id d9443c01a7336-27ed4a67210mr74057675ad.58.1758871806190; Fri, 26 Sep 2025 00:30:06 -0700 (PDT) Received: from rockpi-5b ([45.112.0.216]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-27ed69a98b9sm44083065ad.111.2025.09.26.00.30.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Sep 2025 00:30:04 -0700 (PDT) From: Anand Moon To: Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Jonathan Hunter , linux-pci@vger.kernel.org (open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-tegra@vger.kernel.org (open list:TEGRA ARCHITECTURE SUPPORT), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon , Mikko Perttunen Subject: [PATCH v1 3/5] PCI: tegra: Use readl_poll_timeout() for link status polling Date: Fri, 26 Sep 2025 12:57:44 +0530 Message-ID: <20250926072905.126737-4-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250926072905.126737-1-linux.amoon@gmail.com> References: <20250926072905.126737-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the manual `do-while` polling loops with the readl_poll_timeout() helper when checking the link DL_UP and DL_LINK_ACTIVE status bits during link bring-up. This simplifies the code by removing the open-coded timeout logic in favor of the standard, more robust iopoll framework. The change improves readability and reduces code duplication. Cc: Thierry Reding Cc: Mikko Perttunen Signed-off-by: Anand Moon --- v1: dropped the include header file. --- drivers/pci/controller/pci-tegra.c | 37 +++++++++++------------------- 1 file changed, 14 insertions(+), 23 deletions(-) diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c index 07a61d902eae..b0056818a203 100644 --- a/drivers/pci/controller/pci-tegra.c +++ b/drivers/pci/controller/pci-tegra.c @@ -2169,37 +2169,28 @@ static bool tegra_pcie_port_check_link(struct tegra_pcie_port *port) value |= RP_PRIV_MISC_PRSNT_MAP_EP_PRSNT; writel(value, port->base + RP_PRIV_MISC); - do { - unsigned int timeout = TEGRA_PCIE_LINKUP_TIMEOUT; + while (retries--) { + int err; - do { - value = readl(port->base + RP_VEND_XP); - - if (value & RP_VEND_XP_DL_UP) - break; - - usleep_range(1000, 2000); - } while (--timeout); - - if (!timeout) { + err = readl_poll_timeout(port->base + RP_VEND_XP, value, + value & RP_VEND_XP_DL_UP, + 1000, + TEGRA_PCIE_LINKUP_TIMEOUT * 1000); + if (err) { dev_dbg(dev, "link %u down, retrying\n", port->index); goto retry; } - timeout = TEGRA_PCIE_LINKUP_TIMEOUT; - - do { - value = readl(port->base + RP_LINK_CONTROL_STATUS); - - if (value & RP_LINK_CONTROL_STATUS_DL_LINK_ACTIVE) - return true; - - usleep_range(1000, 2000); - } while (--timeout); + err = readl_poll_timeout(port->base + RP_LINK_CONTROL_STATUS, + value, + value & RP_LINK_CONTROL_STATUS_DL_LINK_ACTIVE, + 1000, TEGRA_PCIE_LINKUP_TIMEOUT * 1000); + if (!err) + return true; retry: tegra_pcie_port_reset(port); - } while (--retries); + } return false; } -- 2.50.1