[PATCH] arm64: dts: qcom: sdm845-oneplus: Correct gpio used for slider

[PATCH] arm64: dts: qcom: sdm845-oneplus: Correct gpio used for slider

[David Heidelberg via B4 Relay]

From: Gergo Koteles <soyer@irl.hu>

The previous GPIO numbers were wrong. Update them to the correct
ones and fix the label.

Fixes: 288ef8a42612 ("arm64: dts: sdm845: add oneplus6/6t devices")
Signed-off-by: Gergo Koteles <soyer@irl.hu>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
index dcfffb271fcf3146aeabda8fc19e61b456b76887..51a9a276399ac7de42f4269ace257120236fa81a 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
@@ -803,8 +803,8 @@ hall_sensor_default: hall-sensor-default-state {
 		bias-disable;
 	};
 
-	tri_state_key_default: tri-state-key-default-state {
-		pins = "gpio40", "gpio42", "gpio26";
+	alert_slider_default: alert-slider-default-state {
+		pins = "gpio126", "gpio52", "gpio24";
 		function = "gpio";
 		drive-strength = <2>;
 		bias-disable;

---
base-commit: 262858079afde6d367ce3db183c74d8a43a0e83f
change-id: 20250927-slider-correct-d34490847d95

Best regards,
-- 
David Heidelberg <david@ixit.cz>

Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: Correct gpio used for slider

[Konrad Dybcio]

On 9/27/25 1:20 PM, David Heidelberg via B4 Relay wrote:
> From: Gergo Koteles <soyer@irl.hu>
> 
> The previous GPIO numbers were wrong. Update them to the correct
> ones and fix the label.
> 
> Fixes: 288ef8a42612 ("arm64: dts: sdm845: add oneplus6/6t devices")
> Signed-off-by: Gergo Koteles <soyer@irl.hu>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---

This is currently unused, can you bundle (or squash?) this with the
"add slider" series instead?

Konrad

Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: Correct gpio used for slider

[David Heidelberg]

On 06/10/2025 16:15, Konrad Dybcio wrote:
> On 9/27/25 1:20 PM, David Heidelberg via B4 Relay wrote:
>> From: Gergo Koteles <soyer@irl.hu>
>>
>> The previous GPIO numbers were wrong. Update them to the correct
>> ones and fix the label.
>>
>> Fixes: 288ef8a42612 ("arm64: dts: sdm845: add oneplus6/6t devices")
>> Signed-off-by: Gergo Koteles <soyer@irl.hu>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
> 
> This is currently unused, can you bundle (or squash?) this with the
> "add slider" series instead?

The seriess didn't received any attention or reviews, so I hoped in 
least fixing the upstream device-tree before someone will have time to 
look at the whole.

Would you recommend sending the "Add support for sound profile switching 
and leverage for OnePlus 6 slider" again, just with this small split 
improvement now?

Thanks
David

> 
> Konrad

-- 
David Heidelberg

Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: Correct gpio used for slider

[Konrad Dybcio]

On 10/6/25 4:32 PM, David Heidelberg wrote:
> On 06/10/2025 16:15, Konrad Dybcio wrote:
>> On 9/27/25 1:20 PM, David Heidelberg via B4 Relay wrote:
>>> From: Gergo Koteles <soyer@irl.hu>
>>>
>>> The previous GPIO numbers were wrong. Update them to the correct
>>> ones and fix the label.
>>>
>>> Fixes: 288ef8a42612 ("arm64: dts: sdm845: add oneplus6/6t devices")
>>> Signed-off-by: Gergo Koteles <soyer@irl.hu>
>>> Signed-off-by: David Heidelberg <david@ixit.cz>
>>> ---
>>
>> This is currently unused, can you bundle (or squash?) this with the
>> "add slider" series instead?
> 
> The seriess didn't received any attention or reviews, so I hoped in least fixing the upstream device-tree before someone will have time to look at the whole.
> 
> Would you recommend sending the "Add support for sound profile switching and leverage for OnePlus 6 slider" again, just with this small split improvement now?

It's been a good 2 months, so it wouldn't hurt.. perhaps wait
one more week for -rc1 to come out, in case anyone you depend on
is *that* pedantic..

Konrad

Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: Correct gpio used for slider

[Bjorn Andersson]

On Sat, 27 Sep 2025 13:20:28 +0200, David Heidelberg wrote:
> The previous GPIO numbers were wrong. Update them to the correct
> ones and fix the label.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: sdm845-oneplus: Correct gpio used for slider
      commit: d7ec7d34237498fab7a6afed8da4b7139b0e387c

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>